Skip to content

refactor(linking): refresh fixed-anchor Rust ownership RED on current main - #752

Closed
seonghobae wants to merge 1 commit into
mainfrom
replacement/fixed-anchor-linking-rust-main-20260811-v2
Closed

refactor(linking): refresh fixed-anchor Rust ownership RED on current main#752
seonghobae wants to merge 1 commit into
mainfrom
replacement/fixed-anchor-linking-rust-main-20260811-v2

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Controlled current-main replacement for #737 / issue #662

Fresh compare against protected main proved #737 is 30 protected-main commits behind and its only unique delta is tests/test_linking_fixed_anchor_rust_ownership.py. Its previous OpenCode handoff was explicitly bound to protected main 7b57f777..., so that write lease is stale. This Draft recreates the exact fail-first ownership contract on current protected main without transferring predecessor checks/reviews.

Intentional RED

The test replaces proposed _core.link_fixed_item_parameters with a sentinel linked result and requires public link_fixed_item_parameters() to return Rust-owned theta/alpha/b plus scale/shift evidence. Current Python-owned fixed-anchor affine arithmetic should therefore fail the delegation assertion after normal Rust/PyO3 package setup.

Exact identity

  • protected base at creation: 8a56d7b1b024e18a5a96a94db4ede1bf6648ead1;
  • clean replacement head: ac6c200fea7e0cb47a870e020faf753a61744b33;
  • changed path: tests/test_linking_fixed_anchor_rust_ownership.py only.

Minimum GREEN

Move the exact current fixed-anchor scale/shift and linked theta/alpha/b transformation arithmetic into mlsirm-core; expose a thin _core.link_fixed_item_parameters PyO3 boundary. Python retains bounded validation, immutable marshalling and result/evidence construction only; missing compatible compiled capability fails closed. Preserve anchor/factor validation, dimensions without anchors, positive finite slopes, xi/zeta/tau, return types and caller immutability. Add direct Rust/public parity plus known-affine coefficient and parameter recovery using bias/MAE/RMSE, then complete docs/rustdoc/APA traceability and changelog after GREEN. Require one unchanged head with full Python 3.12/3.14, Rust/PyO3, package/reinstall, existing GPU/fuzz, Security/SAST and current-head governance gates.

Do not substitute another linking criterion, add GPU without benchmark evidence, change dependencies/workflows/version/release/hosted state, or create competing canonical docs. Advances #662. Supersedes #737 once established.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2206cbaf-5bfe-4ecf-a72e-dd5b4b6b2e68

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Superseded by GREEN ownership PR (#753 form assembly / #755 linking). Closing RED test-only refresh.

@seonghobae seonghobae closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant