refactor(linking): refresh fixed-anchor Rust ownership RED on current main - #752
Closed
seonghobae wants to merge 1 commit into
Closed
refactor(linking): refresh fixed-anchor Rust ownership RED on current main#752seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 11, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Controlled current-main replacement for #737 / issue #662
Fresh compare against protected
mainproved #737 is 30 protected-main commits behind and its only unique delta istests/test_linking_fixed_anchor_rust_ownership.py. Its previous OpenCode handoff was explicitly bound to protected main7b57f777..., so that write lease is stale. This Draft recreates the exact fail-first ownership contract on current protected main without transferring predecessor checks/reviews.Intentional RED
The test replaces proposed
_core.link_fixed_item_parameterswith a sentinel linked result and requires publiclink_fixed_item_parameters()to return Rust-owned theta/alpha/b plus scale/shift evidence. Current Python-owned fixed-anchor affine arithmetic should therefore fail the delegation assertion after normal Rust/PyO3 package setup.Exact identity
8a56d7b1b024e18a5a96a94db4ede1bf6648ead1;ac6c200fea7e0cb47a870e020faf753a61744b33;tests/test_linking_fixed_anchor_rust_ownership.pyonly.Minimum GREEN
Move the exact current fixed-anchor scale/shift and linked theta/alpha/b transformation arithmetic into
mlsirm-core; expose a thin_core.link_fixed_item_parametersPyO3 boundary. Python retains bounded validation, immutable marshalling and result/evidence construction only; missing compatible compiled capability fails closed. Preserve anchor/factor validation, dimensions without anchors, positive finite slopes, xi/zeta/tau, return types and caller immutability. Add direct Rust/public parity plus known-affine coefficient and parameter recovery using bias/MAE/RMSE, then complete docs/rustdoc/APA traceability and changelog after GREEN. Require one unchanged head with full Python 3.12/3.14, Rust/PyO3, package/reinstall, existing GPU/fuzz, Security/SAST and current-head governance gates.Do not substitute another linking criterion, add GPU without benchmark evidence, change dependencies/workflows/version/release/hosted state, or create competing canonical docs. Advances #662. Supersedes #737 once established.