🎨 Palette: [UX improvement] Fix empty state tag to improve accessibility

[seonghobae]

💡 What: Changed the HTML wrapper for empty states in validation reports from a <p> tag to a generic <div> tag, maintaining the role="status" and aria-atomic="true" attributes. Updated the corresponding test.

🎯 Why: To improve accessibility. Overriding the implicit native role of a semantic element (like <p>, which has an implicit role of paragraph) with a specific ARIA role like status can sometimes confuse screen readers or trigger warnings in strict accessibility evaluation tools. Using a generic <div> container is the standard, cleaner approach for custom ARIA live regions.

📸 Before/After: No visual changes. This is purely a semantic/accessibility update.

♿ Accessibility: This change directly enhances the robustness of ARIA live regions, ensuring that conditionally rendered empty states (e.g., when no identifiers are present) are reliably announced by assistive technologies without semantic conflicts.

---

PR created automatically by Jules for task 16101784260817165238 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1dd5d5c0-648d-49bd-95bb-f5fd47a3ccfd

📥 Commits

Reviewing files that changed from the base of the PR and between a7be9eb and cbc48af.

📒 Files selected for processing (2)

• python/fast_mlsirm/scoring/essay/validation_report_html.py
• tests/test_scoring_essay_validation_report_html.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[opencode-agent]

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head cbc48af2469e9b6e71020ba1497cf9821c8ae64b.

• Head SHA: cbc48af2469e9b6e71020ba1497cf9821c8ae64b

• Workflow run: 31429513245

• Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file: validation_report_html.py"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file: validation_report_html.py"]
  R1 --> V1["required checks"]
  Evidence --> S2["Test: test_scoring_essay_validation_report_html.py"]
  S2 --> I2["regression suite"]
  I2 --> R2["Review risk: Test: test_scoring_essay_validation_report_html.py"]
  R2 --> V2["targeted test run"]

Loading

[opencode-agent]

OpenCode Review Overview

• Head SHA: cbc48af2469e9b6e71020ba1497cf9821c8ae64b
• Workflow run: 31429513245
• Workflow attempt: 1
• Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head cbc48af2469e9b6e71020ba1497cf9821c8ae64b.

• Head SHA: cbc48af2469e9b6e71020ba1497cf9821c8ae64b

• Workflow run: 31429513245

• Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file: validation_report_html.py"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file: validation_report_html.py"]
  R1 --> V1["required checks"]
  Evidence --> S2["Test: test_scoring_essay_validation_report_html.py"]
  S2 --> I2["regression suite"]
  I2 --> R2["Review risk: Test: test_scoring_essay_validation_report_html.py"]
  R2 --> V2["targeted test run"]

Loading

[seonghobae]

Closing unmerged as a proven duplicate of the already adjudicated #619 accessibility proposal. The current diff is the same product change (<p class="empty-state" role="status" aria-atomic="true"> → <div ... role="status" ...>) plus the matching test expectation. #619 was closed after exact standards review because W3C ARIA in HTML permits the explicit status role on p, WAI-ARIA defines the live-region behavior on the status role itself, and the repository's existing doctoring deliberately avoids claiming a cross-screen-reader/initial-render guarantee. No new evidence in #672 establishes a standards-required or buyer-visible accessibility improvement over current protected main. Current CI/Security/SAST being green does not make an unnecessary semantic churn valuable, and the same-head OpenCode review is also non-approving due external coverage-evidence infrastructure. No unique product behavior remains to preserve; lineage is #619.

[google-labs-jules]

Closing unmerged as a proven duplicate of the already adjudicated #619 accessibility proposal. The current diff is the same product change (<p class="empty-state" role="status" aria-atomic="true"> → <div ... role="status" ...>) plus the matching test expectation. #619 was closed after exact standards review because W3C ARIA in HTML permits the explicit status role on p, WAI-ARIA defines the live-region behavior on the status role itself, and the repository's existing doctoring deliberately avoids claiming a cross-screen-reader/initial-render guarantee. No new evidence in #672 establishes a standards-required or buyer-visible accessibility improvement over current protected main. Current CI/Security/SAST being green does not make an unnecessary semantic churn valuable, and the same-head OpenCode review is also non-approving due external coverage-evidence infrastructure. No unique product behavior remains to preserve; lineage is #619.

Understood. Acknowledging that this work is now closed as a duplicate of #619 and stopping work on this task.