Skip to content

🎨 Palette: [UX improvement] Fix empty state tag to improve accessibility #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

🎨 Palette: [UX improvement] Fix empty state tag to improve accessibility #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/fast_mlsirm/scoring/essay/validation_report_html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ def _identifier_list(
"""Render identifier evidence as a list or explicit atomic status region."""
if not identifiers:
return (
'<p class="empty-state" role="status" aria-atomic="true">'
f"{escape(empty_message)}</p>"
'<div class="empty-state" role="status" aria-atomic="true">'
f"{escape(empty_message)}</div>"
)
items = "".join(
f"<li><code>{escape(identifier)}</code></li>" for identifier in identifiers
Expand Down
15 changes: 6 additions & 9 deletions tests/test_scoring_essay_validation_report_html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,12 @@ def test_custom_title_and_identifiers_are_escaped(tmp_path: Path) -> None:

def test_empty_identifier_list_renders_explicit_state() -> None:
"""An empty evidence list keeps paragraph spacing and atomic status semantics."""
assert (
validation_report_html._identifier_list(
(),
empty_message="No boundary is available.",
)
== (
'<p class="empty-state" role="status" aria-atomic="true">'
"No boundary is available.</p>"
)
assert validation_report_html._identifier_list(
(),
empty_message="No boundary is available.",
) == (
'<div class="empty-state" role="status" aria-atomic="true">'
"No boundary is available.</div>"
)


Expand Down
Loading