🛡️ Sentinel: [HIGH] 저장된 SSRF 취약점 방지 및 URL 검증 간 예외(AttributeError) 패치

[seonghobae]

🚨 Severity: HIGH
💡 Vulnerability:

1. /api/v1/webhook 엔드포인트에서 웹훅 URL을 데이터베이스에 저장할 때 사전에 안전성을 검증하지 않아 저장된 SSRF(Stored SSRF) 취약점 발생 가능성이 있었습니다.
2. _is_safe_url() 검증 로직에 타입 체크가 없어 악의적인 사용자(예: JSON 본문에 URL을 정수형이나 배열로 전달)가 호출 시 urllib.parse.urlparse에 의한 예기치 못한 예외 처리(AttributeError)가 유발되어, 어플리케이션 충돌(API 500 에러)로 이어질 수 있었습니다.

🎯 Impact: 공격자가 내부 인프라망(localhost 또는 링크 로컬)으로의 임의 HTTP 요청(SSRF)을 성공시키거나, 형변환이 안 되는 데이터를 활용하여 API 응답을 마비시킬 수 있는 가용성 저하 리스크가 존재했습니다.

🔧 Fix:

• 웹훅을 등록하는 set_webhook() 이전에 _is_safe_url()로 url 필드의 무결성을 평가하도록 POST 핸들러(appguardrail_core/controlplane.py)를 개선했습니다.
• CLI와 Control Plane 양쪽의 _is_safe_url() 내부에 명시적인 타입 체크(isinstance(url, str)) 로직을 추가하여, 비문자열 타입이 주입되더라도 사전에 거부되도록 보완했습니다.

✅ Verification:

• tests/test_ssrf_protection.py 및 tests/test_controlplane.py에 올바르지 않은 타입(정수 등) 주입 및 Localhost URL 요청을 거부하는 SSRF 테스트를 추가하여 보안 강화가 올바르게 작동하는지 확인했습니다.
• 테스트 스위트 커버리지를 91%로 유지하며 전체 940개 테스트에 성공했습니다.

---

PR created automatically by Jules for task 14678305360862845164 started by @seonghobae

Summary by CodeRabbit

• 버그 수정

  • 웹훅 URL 검증을 강화해 안전하지 않은 HTTP(S) URL과 잘못된 입력을 거부합니다.
  • 유효하지 않은 웹훅 설정에 대해 서버 오류 대신 400 Bad Request를 반환합니다.
  • 숫자, 불리언, null 등 비문자열 URL 입력으로 인한 처리 오류를 방지합니다.

• 테스트

  • localhost 대상 URL, 숫자형 URL 및 비문자열 입력에 대한 보안 검증 테스트를 추가했습니다.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d181075-d0ed-4fca-b517-7e477c2bd743

📥 Commits

Reviewing files that changed from the base of the PR and between 67725ad and 24a3083.

📒 Files selected for processing (2)

• appguardrail_core/controlplane.py
• tests/test_controlplane.py

📝 Walkthrough

Walkthrough

웹훅 설정 API가 JSON 객체와 안전한 HTTP(S) URL만 허용합니다. 비문자열 URL과 localhost 대상 URL은 400 응답으로 거부합니다. CLI와 control-plane의 _is_safe_url도 비문자열 입력을 거부합니다.

Changes

웹훅 SSRF 보호

Layer / File(s)	Summary
URL 입력 검증 계약 appguardrail_core/controlplane.py, scanner/cli/appguardrail.py, tests/test_ssrf_protection.py	_is_safe_url이 URL 파싱 전에 문자열 타입을 확인합니다. None, 정수, 불리언 입력은 False를 반환합니다.
웹훅 설정 API 검증 appguardrail_core/controlplane.py, tests/test_controlplane.py, .jules/sentinel.md	웹훅 POST 요청이 JSON 객체와 안전한 URL을 검증합니다. 잘못된 본문이나 URL에는 400 Bad Request와 invalid webhook url 오류를 반환합니다. 유효한 URL 또는 null만 저장하고 응답합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• ContextualWisdomLab/appguardrail#910: 웹훅 URL 검증과 _is_safe_url 변경이 직접 연결됩니다.
• ContextualWisdomLab/appguardrail#914: _is_safe_url에서 URL 파싱 전 비문자열 입력을 거부하는 변경과 연결됩니다.
• ContextualWisdomLab/appguardrail#919: control-plane과 CLI에 비문자열 검증 및 관련 테스트를 추가한 변경과 겹칩니다.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목은 저장된 SSRF 방지와 URL 검증 중 AttributeError 수정을 명확하고 간결하게 설명하며 변경 사항과 직접 관련됩니다.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/sentinel-ssrf-type-check-14678305360862845164

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@appguardrail_core/controlplane.py`:
- Around line 635-641: Update the request-body handling used by the webhook
update flow around _body() and set_webhook so an empty Content-Length body is
rejected with 400 "invalid JSON body" instead of being normalized to {}.
Preserve explicit deletion only when the parsed JSON contains "url": null, and
add a regression test covering an empty-body request.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 587943ff-a058-422d-b761-80bd0ca312ba

📥 Commits

Reviewing files that changed from the base of the PR and between 932f98f and 67725ad.

📒 Files selected for processing (5)

• .jules/sentinel.md
• appguardrail_core/controlplane.py
• scanner/cli/appguardrail.py
• tests/test_controlplane.py
• tests/test_ssrf_protection.py