🛡️ Sentinel: [HIGH] Fix AttributeError in URL parsing

[seonghobae]

🚨 Severity: HIGH
💡 Vulnerability: _is_safe_url 함수에 문자열이 아닌 값(True, None, 123 등)이 전달될 경우 urllib.parse.urlparse에서 AttributeError 예외가 발생하여 애플리케이션 충돌 및 API 500 에러를 유발할 수 있습니다.
🎯 Impact: 잘못된 입력 값으로 인한 프로세스 비정상 종료 및 서비스 가용성 저하 (Denial of Service).
🔧 Fix: URL 문자열 파싱 전 isinstance(url, str) 체크를 추가하여, 문자열이 아닌 입력값에 대해서는 안전하게 False를 반환(Fail Closed)하도록 수정했습니다.
✅ Verification: pytest tests/test_ssrf_protection.py를 통해 문자열 외 타입에 대해 올바르게 실패하는지 검증 완료.

---

PR created automatically by Jules for task 13393151165230795568 started by @seonghobae

Summary by CodeRabbit

• 버그 수정

  • URL 검증 시 문자열이 아닌 입력을 안전하지 않은 URL로 처리하도록 개선했습니다.
  • 잘못된 입력으로 인한 처리 오류 대신 안전하게 실패합니다.

• 테스트

  • 불리언, 숫자, None, 목록 등 다양한 비문자열 입력에 대한 검증을 추가했습니다.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f794855b-0b78-4765-a781-47a7c10b8cba

📥 Commits

Reviewing files that changed from the base of the PR and between 0d07baa and bdc3adf.

📒 Files selected for processing (4)

• .jules/sentinel.md
• appguardrail_core/controlplane.py
• scanner/cli/appguardrail.py
• tests/test_ssrf_protection.py

---

📝 Walkthrough

Walkthrough

두 _is_safe_url 함수가 URL 파싱 전에 문자열 타입을 확인합니다. 문자열이 아닌 입력은 False로 처리됩니다. 불리언, 정수, None, 리스트 입력에 대한 테스트와 요구사항이 추가되었습니다.

Changes

URL 입력 검증

Layer / File(s)	Summary
안전한 URL 입력 경계 .jules/sentinel.md, appguardrail_core/controlplane.py, scanner/cli/appguardrail.py, tests/test_ssrf_protection.py	두 _is_safe_url 구현이 문자열이 아닌 입력을 즉시 거부합니다. 관련 요구사항이 추가되었습니다. 비문자열 입력이 모두 False를 반환하는지 테스트합니다.

Estimated code review effort: 1 (매우 낮음) | ~5분

Possibly related PRs

• ContextualWisdomLab/appguardrail#877: 동일한 _is_safe_url 구현의 URL 안전성 검증을 수정합니다.
• ContextualWisdomLab/appguardrail#885: 동일한 _is_safe_url 검증을 리다이렉트 보안에 사용합니다.
• ContextualWisdomLab/appguardrail#910: 동일한 두 _is_safe_url 구현에서 비문자열 입력을 거부합니다.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목은 비문자열 URL 입력으로 발생하는 AttributeError 수정이라는 주요 변경 사항을 명확하게 설명합니다.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentinel-ssrf-type-check-13393151165230795568

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[opencode-agent]

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head bdc3adfde3d0abfd0ec14e3fdd12e2383843512d.

• Head SHA: bdc3adfde3d0abfd0ec14e3fdd12e2383843512d

• Workflow run: 31361242910

• Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (3 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (3 files)"]
  R1 --> V1["required checks"]
  Evidence --> S2["Test: test_ssrf_protection.py"]
  S2 --> I2["regression suite"]
  I2 --> R2["Review risk: Test: test_ssrf_protection.py"]
  R2 --> V2["targeted test run"]

Loading

[opencode-agent]

OpenCode Review Overview

• Head SHA: bdc3adfde3d0abfd0ec14e3fdd12e2383843512d
• Workflow run: 31361242910
• Workflow attempt: 1
• Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head bdc3adfde3d0abfd0ec14e3fdd12e2383843512d.

• Head SHA: bdc3adfde3d0abfd0ec14e3fdd12e2383843512d

• Workflow run: 31361242910

• Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (3 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (3 files)"]
  R1 --> V1["required checks"]
  Evidence --> S2["Test: test_ssrf_protection.py"]
  S2 --> I2["regression suite"]
  I2 --> R2["Review risk: Test: test_ssrf_protection.py"]
  R2 --> V2["targeted test run"]

Loading

[seonghobae]

Closing as superseded by #919 with the functional lineage preserved. Both branches add the same fail-closed string-type guard to the CLI and control-plane _is_safe_url boundaries on the same protected develop@0d07baae44a40edfcaec5e42c7fb9351510ca9f0. #919 additionally makes the public type contract truthful (object), documents both boundary functions, and tests integer, boolean, None, list, and mapping inputs. This branch has no distinct product behavior that is lost; #919 remains open and is not merge-ready while its current OpenCode coverage-evidence blocker and unrelated formatting churn are unresolved.

[google-labs-jules]

Closing as superseded by #919 with the functional lineage preserved. Both branches add the same fail-closed string-type guard to the CLI and control-plane _is_safe_url boundaries on the same protected develop@0d07baae44a40edfcaec5e42c7fb9351510ca9f0. #919 additionally makes the public type contract truthful (object), documents both boundary functions, and tests integer, boolean, None, list, and mapping inputs. This branch has no distinct product behavior that is lost; #919 remains open and is not merge-ready while its current OpenCode coverage-evidence blocker and unrelated formatting churn are unresolved.

Understood. Acknowledging that this work is superseded and stopping work on this task.