Skip to content

feat(api): mint interpretation-run lookup stored-request GET from a dedicated CLI - #470

Merged
seonghobae merged 1 commit into
feat/interpretation-run-lookup-stored-request-get-gap-003afrom
feat/interpretation-run-lookup-stored-request-cli-gap-003a
Sep 1, 2026
Merged

feat(api): mint interpretation-run lookup stored-request GET from a dedicated CLI#470
seonghobae merged 1 commit into
feat/interpretation-run-lookup-stored-request-get-gap-003afrom
feat/interpretation-run-lookup-stored-request-cli-gap-003a

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Superseded by fold into #469

Closed as superseded_by_fold, not discarded. #470 was based exactly on #469's prior head 6a68f98971986f3ea9562fd7a73c5974e5a4af6e. The surviving #469 branch was fast-forwarded without force to this PR's exact head 5b46d78aef81902ab12b8ad691fd83be68d616cc, so the published tepp-interpretation-run-lookup-request get CLI, stored-request lookup route, tests, RED/GREEN lineage, and this discussion remain preserved in the consolidated Analysis Run application/adapter vehicle.

Canonical surviving vehicle: #469 (feat(api): consolidate interpretation-run retrieval, lookup, and stored-request adapters).

This route does not establish an independent bounded context or architecture authority; operation-specific ADR identity remains implementation lineage pending #437 normalization. Do not reopen unless the surviving exact head demonstrably loses unique behavior or evidence.

…edicated CLI

Publish tepp-interpretation-run-lookup-request get so operators who hold a
202 receipt can recover the stored create onto spawned
tepp-orchestrator-loopback TCP. Empty stdin admitted. Metric-free.
Naruon and LineageWeave refused.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment on lines +366 to +367
let stored = InterpretationRunRequest::from_json(&response.body)?;
stored.to_json()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Wrong run response accepted

Given any valid stored-request response, render_interpretation_run_lookup_stored_request_cli_stdout prints it without binding it to the requested run. A misrouted response returns another run's request as success.

Prompt for agents
The lookup stored-request response contains only InterpretationRunRequest, so render_interpretation_run_lookup_stored_request_cli_stdout cannot verify that a successful body belongs to invocation.interpretation_run_id. The neighboring lookup CLI validates the returned run ID, and the idempotency-key stored-request CLI validates the returned idempotency key. Extend the response contract or execution flow so this CLI receives a verifiable binding between the requested interpretation_run_id and the stored request, reject mismatches before printing, and add a contract test with a valid request from a different run.
Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@seonghobae
seonghobae merged commit 5b46d78 into feat/interpretation-run-lookup-stored-request-get-gap-003a Sep 1, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant