feat(analysis): bind provenance-is-not-transition refusals to an analysis-run profile - #426
feat(analysis): bind provenance-is-not-transition refusals to an analysis-run profile#426seonghobae wants to merge 1 commit into
Conversation
…ysis-run profile GAP-004 leftover / ADR 0064. Bind existing citation_edge refuse_provenance_as_transition to cutoff-safe citation_edge_v1. edge_kind_recovery_rate stays library-side. Distinct from lineage-criterion (#423), corpus-background (#422), modality-source (#421), prompt-source (#419), style-source (#418), copy-identity (#416), and method-effects (#415). Not GPU, not MCMC, and not topic birth/split/merge.
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| pub struct CitationEdgeDocument { | ||
| document_id: String, | ||
| kind: ProvenanceKind, | ||
| } |
There was a problem hiding this comment.
🔴 Future evidence enters historical censuses
CitationEdgeDocument carries no availability time, so execute_citation_edge_run cannot exclude documents unavailable at the requested cutoff. Historical censuses can include future evidence.
Prompt for agents
The citation-edge profile is publicly described as cutoff-safe, but CitationEdgeDocument contains only document_id and kind. Add validated availability metadata or another immutable eligibility proof to each input row, then make execute_citation_edge_run enforce availability at or before knowledge_cutoff before counting. Define whether late rows are excluded or rejected consistently with the analysis-engine cutoff contract, preserve duplicate checks for the admitted set as appropriate, and add integration tests proving evidence after the cutoff cannot enter the artifact.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Summary
GAP-004 leftover / ADR 0064. Bind existing
citation_edge::refuse_provenance_as_transitionto a cutoff-safecitation_edge_v1analysis-run profile (tepp.citation_edge.v1).provenance_is_not_a_state_transition.edge_kind_recovery_ratestays library-side; inspect payloads stay metric-free (scientific_acceptancenever appears).fit_lineage_criterion_posteriors), feat(analysis): bind corpus-background refusals to an analysis-run profile #422 corpus-background, feat(analysis): bind non-lexical modality refusals to an analysis-run profile #421 modality-source, feat(analysis): bind prompt-boilerplate refusals to an analysis-run profile #419 prompt-source, feat(analysis): bind house-voice style refusals to an analysis-run profile #418 style-source, feat(analysis): bind template-copy identity refusals to an analysis-run profile #416 copy-identity, and feat(analysis): bind simulation method-effect labels to an analysis-run profile #415 simulation method-effect census.Not GPU. Not MCMC. Not topic birth/split/merge. Not implemented-main.
Distinct from live slices
Does not duplicate #425 (interpretation-run CLI), #424 (project-history collection GET), #423 (lineage-criterion), #422 (corpus-background), #421 (modality-source), #420 (project-history CLI), #419 (prompt-source), #418 (style-source), #417 (export-retrieval CLI), #416 (copy-identity), #415 (method-effects), #414 (temporal-context CLI), #413 (case-deletion), #412 (composed fitted-K+lineage), #411 (export GET), #351 (Leiden), or Driver p.16 std-family micro-PRs.
Verification
cargo test -p analysis_enginecargo clippy -p analysis_engine --all-targets -- -D warningspython3 scripts/validate_documentation.pyMerge gate
Two independent current-head APPROVEs required. Author/bot COMMENTED is not independent APPROVE. Exact-head Checks on this SHA only. Predecessor Checks do not transfer. Do not self-approve. Do not merge without two independent approvals.