test(browser): require sampled Chromium process-set termination evidence - #144
Draft
seonghobae wants to merge 11 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
August 26, 2026 22:05
seonghobae
marked this pull request as draft
August 27, 2026 11:34
…termination-evidence' into test/agent-task-process-set-termination-evidence Signed-off-by: Seongho Bae <me@seonghobae.me>
Preserve process-set runtime behavior and both cleanup release records while adopting the parent's real failure-path regression. Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28. Current head is
3c0c5c363c2da0b4e8a621226e2f7766c735b743, an ordinary two-parent integration of prior child09f2e087d0c20fe81386c18099e739a9e611a8adand current #14344fd9a450f864feff5cf2ba2883425a71ba10b9b.Buyer / reliability boundary
Controlled Chromium is multi-process. Root exit alone cannot prove renderer, GPU or utility exit. This Draft captures a bounded set of sampled process IDs, matches the root to its expected PID/start-time identity, binds still-live descendants to start times observed during later capture, and requires those retained identities to exit before success. Profile cleanup and browser-task success remain separate evidence.
Test-first parent adoption / current local proof
The previous head passed 194 Python contracts but collected only three of the five failure-path contracts now owned by #143. The expected-five assertion failed before integration. Read-only merge-tree reproduced a CHANGELOG-only conflict. The ordinary merge retains both failure-path and expanded success-path release records and carries the parent's behavioral regression unchanged. The production runner and child process-set test are byte-for-byte identical to the previous child.
The integrated tree passes all five focused failure-path contracts, all 196 Python repository contracts, compileall, Rust 1.97.1 formatting, workspace/all-target check and tests, strict Clippy, rustdoc, and pinned-nightly owned-production coverage enforcement. Coverage is 100% of 415 functions, 3,555 lines, 4,444 regions and 476 branches. Local success is not hosted or browser-runtime acceptance.
Current exact-head hosted CI
33956094018and Manifest V3 Compatibility33956094011are queued, not GREEN. The previous child-head runs33916685294and33916685137were cancelled. No old-head result transfers to the integrated head.Informational review / measured limits
Controlled probes of the real helpers on unchanged production source established:
All three informational threads are resolved; this is not an eligible formal approval. No production timeout, workflow or quality gate was changed.
Historical provenance — not current acceptance
Test-only
d20fd0f0d02e4c9d58a5c471b25b13e82d9ddac3established the original missing process-set contract. Earlier non-force integration5ed8fb140f031fbc637175169fd7796692e6d6c3on then-parent452927dd0c6040fc7814b277e553ce6eff9e1479had successful CI32606913420and compatibility32606913450; those results do not transfer to the current head or prerequisite.Authority / next dependency
Keep this PR Draft while its prerequisite is unprotected and hosted acceptance is pending. #145 separately owns late-failure process-set evidence and must adopt this current parent without losing its child delta. Current hosted checks, live rules and eligible independent approval remain separate requirements.
This scope does not establish cgroup/task ownership, processes appearing after sampling, cross-platform supervision, authenticated Chromium/ChromeDriver provenance or OS-wide orphan absence. No protected merge, self-approval, bypass, force-push, workflow/ruleset/secret mutation, tag, release or publication is included.
Instrumentation limit: a fresh report from the pinned cargo-llvm-cov 0.8.6 branch data emits
warning: --branch option is unstable. The repository's four-dimension numerical coverage verifier passes, but the instrumentation is experimental and this is not warning-free measurement or release acceptance. The warning is recorded, not suppressed or bypassed; Rust compiler/Clippy/rustdoc results remain separate.