feat(network): parse typed WebDriver BiDi session.status results - #250
feat(network): parse typed WebDriver BiDi session.status results#250seonghobae wants to merge 33 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Parent-first review adds one new prerequisite rather than copying a common protocol rule into this stale child. The 3 Sep 2026 WebDriver BiDi Editor's Draft types ErrorResponse.error as the finite ErrorCode vocabulary. #250 currently retains envelope.error_code() as an owned String in RemoteProtocolError, while canonical common-envelope #247 currently validates only that error is text. Review 5111407394 on #247 records the root repair: reject non-ErrorCode values at the common envelope before command-specific correlation/retention. Keep this child Draft and do not add a second error-code allow-list here. Its non-force reconstruction must wait for the repaired/verified ancestor stack and then preserve only the five command-specific result-parser paths. Also, the direct parent #249 has since repaired its documentation gate and moved to 422ac8cce072cb016af16ed37e0de357a9ce854d; its CI 33859271719 remains non-terminal. This is a repair/dependency note, not approval.
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Parent/base RCA completed for exact head The prior coverage failure was inherited from the command-correlation parent. I merged the current #249 head ( Local evidence on this exact tree: documentation contracts 22 passed / 177 subtests; rustfmt clean; strict all-target/all-feature Clippy clean; full workspace tests passed; rustdoc with warnings denied passed; pinned-nightly LLVM production functions, lines, regions, and branches are 100% covered. One first macOS coverage attempt hit the existing revoked-loopback socket timing failure ( |
Commit-Message-Assisted-by: Claude (via Claude Code) Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Exact-head parent refresh: |
Commit-Message-Assisted-by: Claude (via Claude Code) Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Non-force restacked on PR #249 exact head |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head focused review for stacked child 0eab23d5e388c5c8b984c0021a58316680c9ba8b over #249 017d6e816f5a86544a63821b3ceaba94d5f17f44: no actionable parser or correlation defect found. Command-specific projection runs only after the bounded common RFC 8259 envelope rejects duplicate top-level members, invalid syntax, excessive depth, and invalid ids; it then requires unique typed ready/message, bounds decoded message bytes, redacts message content from Debug/errors, and consumes only the exact typed outstanding command after a valid projection. Local exact-head evidence: rustfmt passed; all 7 focused response/hostile tests passed; strict all-target/all-feature Clippy and warnings-denied rustdoc passed. Keep Draft and parent-first; its two hosted checks remain queued.
Preserve the five status-response owner blobs while merging the canonical opening fixture and discoverable correlation release contract from current #249. Verify the integrated tree without transferring predecessor hosted evidence. Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
Preserve the session.end sender, exports and both child Rust integration tests while adopting #250 ec433b8. Resolve the changelog-only conflict by retaining both release records. Native release contract: 0 discovered RED to 1 executed GREEN. Full 142 Python tests, compileall, Rust fmt/check/test/Clippy/rustdoc and enforced 100% coverage pass (1037 functions, 10647 lines, 13681 regions, 1192 branches). The pinned branch instrumentation still warns that its option is unstable; this is not warning-free or hosted acceptance. Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
Boundary
Draft child of #249. This slice owns bounded typed WebDriver BiDi
session.statusresponse projection and exact outstanding-command correlation. Required readiness/message fields are validated before correlation is consumed; remote implementation text is untrusted, bounded and omitted from Debug output.Current exact head is
ec433b844a121f8554c062f92267991af9cacb6fon exact #24984b9407978ae0f6c115f01170b6069c601b21104. Five child-owned production/test blobs remain unchanged from their verified predecessor; common ErrorCode validation stays in its canonical envelope owner.Local verification passed 142 Python contracts, compileall, Rust 1.97.1 fmt/check/workspace tests/strict Clippy/rustdoc and numeric coverage 1023 functions / 10518 lines / 13525 regions / 1186 branches = 100% with the known unstable branch-option warning.
Exact-current hosted CI
33955410724is terminal success. This repository quality result does not create browser authority, received-connection provenance, process/profile cleanup, central security/review, protected integration or release acceptance.Keep Draft and parent-first integration. No merge, Close, self-approval, bypass, force update, destructive rebase, workflow/ruleset/secret mutation, tag, release or publication was performed.