test(browser): retain Agent Task process teardown evidence after failure - #143
Draft
seonghobae wants to merge 5 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
August 26, 2026 22:05
seonghobae
marked this pull request as draft
August 27, 2026 11:34
…termination-evidence' into test/agent-task-failure-process-termination-evidence Signed-off-by: Seongho Bae <me@seonghobae.me>
Exercise the real controlled failure and cleanup path for observed exit, a surviving identity, and process-observation errors. Record the evidence limits without changing runtime behavior. Commit-Message-Assisted-by: Codex (via Codex) Signed-off-by: Seongho Bae <me@seonghobae.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28, based on current PR #142 head
015025f2539e4fb1dbd7d259ec22dad50f944396.Buyer / reliability boundary
After the controlled browser's PID/start-time identity is captured, a reviewed browser failure retains a bounded failure type and an observed root-process teardown result. Temporary-profile cleanup is recorded separately. Successful cleanup never converts a failed task into a pass. Raw exception messages and command paths are not retained.
This is evidence about the original controlled Chrome root identity only: descendant-process teardown, cross-platform supervision, arbitrary browser recovery and OS-wide orphan absence remain separate work.
Current review repair and RED → GREEN
Current head:
44fd9a450f864feff5cf2ba2883425a71ba10b9b; parent:015025f2539e4fb1dbd7d259ec22dad50f944396. Runtime behavior is unchanged fromc1dd380be91c0604b797b6914f8cfef2e96f99b7.A new release-record regression failed before the missing Unreleased entry and evidence-limit documentation were added. A controlled regression invokes both real browser-pass and isolated-trial helpers without launching a browser. It checks observed exit, a surviving identity, and process-observation failure; each remains a failed trial, driver shutdown occurs, and private exception text does not enter the result.
If process observation itself fails, termination remains unproven. The outer trial records the bounded observation-error type and profile cleanup, without a termination flag; the original browser-failure type is not retained in this fallback record. This limitation is documented rather than replaced with fabricated success or an unimplemented causal chain.
Exact-current local verification
Local controlled tests are not real Linux process or pinned-Chromium runtime evidence. Fresh exact-head hosted checks must be evaluated independently; queued or historical successful runs are not current acceptance.
Historical provenance — not current acceptance
The original test-only head
e847d0768d7006771b6ee10d56c52e555c0fc168produced the failure-path retention RED. An earlier stack integration452927dd0c6040fc7814b277e553ce6eff9e1479had successful CI32606887326and Manifest V3 Compatibility32606887322; those runs do not attest this current head or base.Stack / authority
This remains Draft while #142 and earlier prerequisites are active. #144 must adopt and revalidate this exact head before downstream acceptance. Informational thread resolution is not a formal eligible approval, and no local result substitutes for required hosted CI, current rules, or independent approval. No merge, workflow, secret, ruleset, tag, release or publication mutation is included.