feat(reports): leftover observed on grouping comparison graphic (v2.73.0) - #856
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Cycle 2026-08-31 08:52 KST: exact head |
1a2f11c to
c7a8680
Compare
|
Exact head now |
…3.0) Name leftover observed Y on grouping comparison leftover-map pair segments (ADR 0316). After make seed, closest and farthest leftover pairs sit above the member list with leftover observed Y next to leftover residual R on that comparison graphic; click opens that post. Rank-0 unused axes still name Y 0.00 when that persisted leftover observed is finite. A missing or non-finite Y omits that leftover-map comparison graphic observed caption and keeps leftover residual R. Never invent a leftover score. Never invent a theta.
c7a8680 to
cf3b6d4
Compare
|
Rebased onto #855 @ Comparison-graphic leftover observed uses distinct accessible name Leave open for independent review. Do not self-approve. Do not squash-merge without independent APPROVE + exact-head required success. Next buyer increment after this residual: leftover expected |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| aria-label={tf( | ||
| variant === "comparison" | ||
| ? LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_OBSERVED | ||
| : LEFTOVER_MAP_PLOT_SEGMENT_OBSERVED, | ||
| { label: segment.observedLabel }, | ||
| )} |
There was a problem hiding this comment.
📝 Info: Observed values remain data-backed
observedLabel still uses persisted observed_response through its finite-value formatter. The variant branch changes only the accessible name, preserving independent omission.
Was this helpful? React with 👍 or 👎 to provide feedback.
| aria-label={tf( | ||
| variant === "comparison" | ||
| ? LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_OBSERVED | ||
| : LEFTOVER_MAP_PLOT_SEGMENT_OBSERVED, | ||
| { label: segment.observedLabel }, | ||
| )} |
There was a problem hiding this comment.
📝 Info: Plot variants keep separate labels
The comparison branch receives the new translation key. Report plots retain LEFTOVER_MAP_PLOT_SEGMENT_OBSERVED, so their accessible contract stays unchanged.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Cycle 2026-08-31 08:19 KST: exact head |
1 participant
Summary
make seed, closest and farthest leftover pairs sit above the member list with the Gabriel biplot of already-named coordinates, leftover-map axis share when finite, leftover-map complete-case coverage when leftoverMapCoverageCounts returns usable complete-case integers, leftover-map item complete-case coverage when leftoverMapItemCoverageCounts returns usable complete-case integers, leftover-map incomplete post coverage when leftoverMapIncompletePostCount returns a usable dropped integer, leftover-map incomplete item coverage when leftoverMapIncompleteItemCount returns a usable dropped integer, leftover-map reconstruction R̂ when formatLeftoverMapReconstruction returns a usable signed badge, leftover-map explained leftover share e when formatLeftoverMapExplainedShare returns a usable badge, leftover-map unexplained leftover share s when formatLeftoverMapUnexplainedShare returns a usable badge, leftover-map cross share x when formatLeftoverMapCrossShare returns a usable badge, leftover-map unexplained leftover U when formatLeftoverMapUnexplained returns a usable badge, leftover residual R when formatLeftoverMapResidual returns a usable badge, and leftover observed Y on that comparison graphic when formatLeftoverMapObserved returns a usable badge; click a post marker or a pair button opens that post.leftover map comparison graphic leftover observed {label}so it stays distinct fromleftover observed {label}on the period-report graphic and from stripLeftover map comparison observed. Vietnamese copy names the leftover map. A missing or non-finiteYomits that leftover-map comparison graphic leftover observed caption and keeps leftover residualR, leftover-map unexplained leftoverU, leftover-map cross sharex, leftover-map unexplained leftover shares, leftover-map explained leftover sharee, leftover-map reconstructionR̂, leftover-map distanced, leftover-map comparison graphic coverage, leftover-map comparison graphic item coverage, leftover-map comparison graphic incomplete posts, and leftover-map comparison graphic incomplete items when those helpers return usable integers. Rank-0 origin cells still nameY 0.00when that persisted leftover observed is finite.YfromRandE, leftover residual, leftover-map reconstruction, leftover-map unexplained leftover, leftover-map distance, plotted coordinates, leftover-map rank, leftover-map axis share, leftover expected, leftover-map post coverage, leftover-map item coverage, leftover-map incomplete post coverage, leftover-map incomplete item coverage, leftover pair count, or the count of unused axes. A finite negative leftover is shown, never clamped. Never invent a leftover score. Never invent a theta. No new columns.Stack
Rebased onto #855 (
feat/leftover-map-compare-plot-residual-v2720@1087b16). Headcf3b6d4. Do not mix into other stacks. Leave open for independent review. Do not self-approve. Do not squash-merge without independent APPROVE + exact-head required success.Test plan
make seed, grouping comparison leftover pairs name leftover observed Y on the comparison graphic; click opens that post.