Skip to content

feat(reports): leftover expected on grouping comparison graphic (v2.74.0) - #857

Open
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-plot-observed-v2730from
feat/leftover-map-compare-plot-expected-v2740
Open

feat(reports): leftover expected on grouping comparison graphic (v2.74.0)#857
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-plot-observed-v2730from
feat/leftover-map-compare-plot-expected-v2740

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Caption leftover expected on the grouping comparison leftover-map graphic from already-named expected_response (ADR 0317 / v2.74.0).
  • After make seed, closest and farthest leftover pairs sit above the member list with the Gabriel biplot of already-named coordinates, leftover-map axis share when finite, leftover-map complete-case coverage when leftoverMapCoverageCounts returns usable complete-case integers, leftover-map item complete-case coverage when leftoverMapItemCoverageCounts returns usable complete-case integers, leftover-map incomplete post coverage when leftoverMapIncompletePostCount returns a usable dropped integer, leftover-map incomplete item coverage when leftoverMapIncompleteItemCount returns a usable dropped integer, leftover-map reconstruction R̂ when formatLeftoverMapReconstruction returns a usable signed badge, leftover-map explained leftover share e when formatLeftoverMapExplainedShare returns a usable badge, leftover-map unexplained leftover share s when formatLeftoverMapUnexplainedShare returns a usable badge, leftover-map cross share x when formatLeftoverMapCrossShare returns a usable badge, leftover-map unexplained leftover U when formatLeftoverMapUnexplained returns a usable badge, leftover residual R when formatLeftoverMapResidual returns a usable badge, leftover observed Y when formatLeftoverMapObserved returns a usable badge, and leftover expected E on that comparison graphic when formatLeftoverMapExpected returns a usable badge; click a post marker or a pair button opens that post.
  • Comparison copy uses accessible name leftover map comparison graphic leftover expected {label} so it stays distinct from leftover expected {label} on the period-report graphic and from strip Leftover map comparison expected. Vietnamese copy names the leftover map. A missing or non-finite E omits that leftover-map comparison graphic leftover expected caption and keeps leftover observed Y, leftover residual R, leftover-map unexplained leftover U, leftover-map cross share x, leftover-map unexplained leftover share s, leftover-map explained leftover share e, leftover-map reconstruction , leftover-map distance d, leftover-map comparison graphic coverage, leftover-map comparison graphic item coverage, leftover-map comparison graphic incomplete posts, and leftover-map comparison graphic incomplete items when those helpers return usable integers. Rank-0 origin cells still name E 0.00 when that persisted leftover expected is finite.
  • Leftover expected omits independently of leftover observed, leftover residual, leftover-map unexplained leftover, leftover-map cross share, leftover-map unexplained leftover share, leftover-map explained leftover share, leftover-map reconstruction, leftover-map distance, and coverage notes. This increment does not caption leftover-map rank on the comparison graphic with a distinct name.
  • Do not invent E from Y and R, leftover residual, leftover observed, leftover-map reconstruction, leftover-map unexplained leftover, leftover-map distance, plotted coordinates, leftover-map rank, leftover-map axis share, leftover-map post coverage, leftover-map item coverage, leftover-map incomplete post coverage, leftover-map incomplete item coverage, leftover pair count, or the count of unused axes. A finite negative leftover is shown, never clamped. Never invent a leftover score. Never invent a theta. No new columns.

Stack

Rebased onto #856 (feat/leftover-map-compare-plot-observed-v2730 @ cf3b6d4). Head ade9ed5. Do not mix into other stacks. Leave open for independent review. Do not self-approve. Do not squash-merge without independent APPROVE + exact-head required success.

Test plan

  • Frontend leftover expected, leftover observed, leftover-map plot, leftover residual, i18n, and App grouping-comparison tests (511 passed locally). oxlint clean on the changed files.
  • CI Full test suite and Frontend lint, test, build on this exact head.
  • After make seed, grouping comparison leftover pairs name leftover expected E on the comparison graphic; click opens that post.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5a028c4c-efa8-44d4-8111-5126d64c7caf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Exact head 9f34d2c stacked on #856 @ c7a8680. Comparison graphic leftover expected uses leftover map comparison graphic leftover expected {label} so it stays distinct from hyphen leftover expected {label} and strip Leftover map comparison expected. Independent APPROVE required on this leftover-expected increment before squash-merge. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open. Next buyer increment is leftover-map rank on this comparison graphic (ADR 0318 / v2.75.0), stacked here — not mixed into #74/#92.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31 08:19 KST: exact head 9f34d2c (v2.74.0 / ADR 0317 leftover expected on grouping comparison leftover-map graphic). Stacked on #856. Independent APPROVE still required. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open. Next buyer increment: leftover-map rank on this comparison graphic (ADR 0318 / v2.75.0).

…4.0)

Name leftover expected E on grouping comparison leftover-map pair
segments (ADR 0317). After make seed, closest and farthest leftover
pairs sit above the member list with leftover expected E next to
leftover observed Y on that comparison graphic; click opens that post.
Rank-0 unused axes still name E 0.00 when that persisted leftover
expected is finite. A missing or non-finite E omits that leftover-map
comparison graphic leftover expected caption and keeps leftover observed Y.
Never invent a leftover score. Never invent a theta.
@seonghobae
seonghobae force-pushed the feat/leftover-map-compare-plot-expected-v2740 branch from 9f34d2c to ade9ed5 Compare August 31, 2026 00:06

Copy link
Copy Markdown
Contributor Author

Rebased onto #856 @ cf3b6d4 after the leftover observed a11y rename. Head is now ade9ed5.

Comparison-graphic leftover expected uses distinct accessible name leftover map comparison graphic leftover expected {label} (same leftover-qualifier pattern as residual and observed). Vietnamese copy names the leftover map. Local oxlint 0; 511 tests passed (App 103, LeftoverMapPlot 58, leftoverMapPlotLayout 59, i18n 276, leftoverObservedExpected 10, leftoverResidual 5).

Leave open for independent review. Do not self-approve. Do not squash-merge without independent APPROVE + exact-head required success. Next buyer increment after this residual: leftover-map rank on the comparison graphic (ADR 0318 / v2.75.0).

Copy link
Copy Markdown
Contributor Author

Independent APPROVE still required on this leftover-expected head 9f34d2c (v2.74.0). #858 leftover-map rank (v2.75.0) is stacked here at 4b9184f. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant