Skip to content

feat(reports): leftover residual on grouping comparison graphic (v2.72.0) - #855

Open
seonghobae wants to merge 2 commits into
feat/leftover-map-compare-plot-unexplained-leftover-v2710from
feat/leftover-map-compare-plot-residual-v2720
Open

feat(reports): leftover residual on grouping comparison graphic (v2.72.0)#855
seonghobae wants to merge 2 commits into
feat/leftover-map-compare-plot-unexplained-leftover-v2710from
feat/leftover-map-compare-plot-residual-v2720

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Caption leftover residual on the grouping comparison leftover-map graphic from already-named leftover_residual (ADR 0315 / v2.72.0).
  • After make seed, closest and farthest leftover pairs sit above the member list with the Gabriel biplot of already-named coordinates, leftover-map axis share when finite, leftover-map complete-case coverage when leftoverMapCoverageCounts returns usable complete-case integers, leftover-map item complete-case coverage when leftoverMapItemCoverageCounts returns usable complete-case integers, leftover-map incomplete post coverage when leftoverMapIncompletePostCount returns a usable dropped integer, leftover-map incomplete item coverage when leftoverMapIncompleteItemCount returns a usable dropped integer, leftover-map reconstruction R̂ when formatLeftoverMapReconstruction returns a usable signed badge, leftover-map explained leftover share e when formatLeftoverMapExplainedShare returns a usable badge, leftover-map unexplained leftover share s when formatLeftoverMapUnexplainedShare returns a usable badge, leftover-map cross share x when formatLeftoverMapCrossShare returns a usable badge, leftover-map unexplained leftover U when formatLeftoverMapUnexplained returns a usable badge, and leftover residual R on that comparison graphic when formatLeftoverMapResidual returns a usable badge; click a post marker or a pair button opens that post.
  • Comparison copy uses accessible name leftover map comparison graphic residual {label} so it stays distinct from hyphen leftover residual {label} on the period-report graphic and from strip Leftover map comparison residual. A missing or non-finite R omits that leftover-map comparison graphic residual caption and keeps leftover-map unexplained leftover U, leftover-map cross share x, leftover-map unexplained leftover share s, leftover-map explained leftover share e, leftover-map reconstruction , leftover-map distance d, leftover-map comparison graphic coverage, leftover-map comparison graphic item coverage, leftover-map comparison graphic incomplete posts, and leftover-map comparison graphic incomplete items when those helpers return usable integers. Rank-0 origin cells still name R 0.00 when that persisted leftover residual is finite.
  • Leftover residual omits independently of leftover-map unexplained leftover, leftover-map cross share, leftover-map unexplained leftover share, leftover-map explained leftover share, leftover-map reconstruction, leftover-map distance, and coverage notes. This increment does not caption leftover observed on the comparison graphic with a distinct name.
  • Do not invent R from Y and E, from U and , leftover-map reconstruction, leftover-map unexplained leftover, leftover-map distance, plotted coordinates, leftover-map rank, leftover-map axis share, leftover expected, leftover observed, leftover-map post coverage, leftover-map item coverage, leftover-map incomplete post coverage, leftover-map incomplete item coverage, leftover pair count, or the count of unused axes. A finite negative leftover is shown, never clamped. Never invent a leftover score. Never invent a theta. No new columns.

Stack

Stacked on #854 (feat/leftover-map-compare-plot-unexplained-leftover-v2710 @ 935cdea). Do not mix into other stacks. Leave open for independent review. Do not self-approve. Do not squash-merge without independent APPROVE + exact-head required success.

Test plan

  • Frontend leftover residual, leftover-map plot, i18n, and App grouping-comparison tests (485 passed locally).
  • CI Full test suite and Frontend lint, test, build on this exact head.
  • After make seed, grouping comparison leftover pairs name leftover residual R on the comparison graphic; click opens that post.

Devin Review

…2.0)

Name leftover residual R on grouping comparison leftover-map pair
segments (ADR 0315). After make seed, closest and farthest leftover
pairs sit above the member list with leftover residual R next to
leftover-map unexplained leftover U on that comparison graphic; click
opens that post. Rank-0 unused axes still name R 0.00 when that
persisted leftover residual is finite. A missing or non-finite R omits
that leftover-map comparison graphic residual caption and keeps leftover-map
unexplained leftover U. Never invent a leftover score. Never invent a
theta.
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0a749b8b-8702-4496-8db5-82e94f871ddb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Stacked on #854 @ 935cdea. Independent APPROVE required on this exact head before squash-merge. Copilot review requested. Do not self-approve. Issues #79 and #87 stay open.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31 08:35 KST: exact head 4ffed4ae (v2.72.0 / ADR 0315 leftover residual on grouping comparison leftover-map graphic). Independent APPROVE still required. Do not self-approve. Do not squash-merge without independent APPROVE + exact-head required success. Next buyer increment on a stacked branch: leftover observed Y on that comparison graphic (ADR 0316 / v2.73.0). Copilot review requested this cycle.

Copy link
Copy Markdown
Contributor Author

Stacking leftover observed Y on this comparison graphic as v2.73.0 / ADR 0316 (feat/leftover-map-compare-plot-observed-v2730). Independent APPROVE is still required on this leftover-map stack before any squash-merge. Do not self-approve. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE.

Keep leftover map comparison graphic leftover residual {label} distinct
from leftover residual {label} on the period-report graphic and from
strip Leftover map comparison residual (ADR 0315). Vietnamese copy
names the leftover map. Do not invent R. Never invent a leftover score.
Never invent a theta. No new columns.

Copy link
Copy Markdown
Contributor Author

Exact head now 1087b16 (a11y: leftover map comparison graphic leftover residual {label} distinct from hyphen leftover residual {label} and strip Leftover map comparison residual). Independent APPROVE still required on this leftover-residual increment before squash-merge. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open. Next buyer increment is leftover observed Y on this comparison graphic (ADR 0316 / v2.73.0), stacked here — not mixed into #74/#92.

Copy link
Copy Markdown
Contributor Author

Independent APPROVE still required on this exact leftover-residual head 1087b16 (v2.72.0). #856 leftover observed (v2.73.0) is stacked here at c7a8680. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant