test: lift ask_time_axis.py coverage 78% to 100% - #772
Conversation
8 direct-branch tests: row-get guards (mapping, mapping-like, sequence misuse, None), Seoul calendar date handling (None, naive UTC-treated, aware, non-date), event/created clock fallback, evidence-fact active-clock naming, and window matching for absent clocks and out-of-range dates. ask_time_axis.py 10 -> 0 missing (100%). Package line coverage 96.0%. 1720 Python tests green; tests-only change.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Changes시간 축 헬퍼 테스트
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds focused coverage without altering runtime behavior or product functionality; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Cycle 2026-08-28T10:00 KST: exact head |
|
Exact-head reminder (2026-08-28 10:22 KST): this PR is still BLOCKED on independent APPROVE. Auto-merge squash is already enabled. Bot COMMENT is not APPROVE. I will not self-approve. Independent collaborator review of exact head |
|
Scheduled review-feedback autofix for this PR head.
|
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head governance/ancestry finding: live compare against protected main@83eba56149eb802cd63642c507c324c9976ec78e is diverged (behind_by=6, merge base b0e94aa2a6f7a943f96dc5c4f2fdecd0021978a1) while this PR's valid delta remains exactly one added test file, tests/test_ask_time_axis_edges.py. The PR body is also stale: it declares predecessor head eb50ef4c... and protected base 3f61c824..., but GitHub reports current head a8d58fbf... and base SHA b0e94aa2.... This is a wrong-base/live-authority repair finding, not a close reason. Preserve the test-only delta and non-force converge it onto the current protected tree; do not transfer predecessor checks/reviews.
1 participant
Scope
Tests-only coverage work for
ask_time_axis.py: row guards, Seoul calendar conversion, event/created clock fallback, evidence naming, and active-window matching. No production code, schema, UI, provider, or canonical-owner authority changes.Current repair lineage
Fresh review
5117229610found that the branch had diverged from protectedmain: live compare frommain@83eba56149eb802cd63642c507c324c9976ec78eto predecessor heada8d58fbf55414a031123e3890f4443e43f97fdb8reported merge baseb0e94aa2a6f7a943f96dc5c4f2fdecd0021978a1,behind_by=6, while the valid PR delta remained exactly one added test file. The PR body also still named older base/head evidence.The branch was repaired non-destructively with two-parent commit
781ebb11a00b50bf1956ff3536eef46160271931: protectedmainsupplies the current product/workflow tree and the exact existing blob fortests/test_ask_time_axis_edges.pyis preserved. No force push, destructive rebase, production-code rewrite, or predecessor evidence transfer was used.Exact live boundary
main@83eba56149eb802cd63642c507c324c9976ec78e781ebb11a00b50bf1956ff3536eef46160271931ahead, merge base exactly protectedmain,behind_by=0tests/test_ask_time_axis_edges.py(+74/-0)33913133104: completed / skipped under Draft admission33913133023, CodeQL33913133045, SAST33913133060: queued at this snapshotKeep this Draft while central exact-head gates and independent review are non-terminal. Do not transfer older coverage/check evidence, self-approve, bypass, or broaden this test-only slice into production policy.