Skip to content

Conversation

@BigSpaceships
Copy link
Contributor

No description provided.

@sentry
Copy link

sentry bot commented Oct 21, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: conditional/util/member.py

Function Unhandled Issue
gatekeep_status NameError: name 'request' is not defined dashboar...
Event Count: 3
gatekeep_status AttributeError: type object 'CommitteeMeeting' has no attribute 'date' dashboar...
Event Count: 2
gatekeep_status AttributeError: 'Query' object has no attribute 'filtgatekeep_statuser' dashboa...
Event Count: 1
gatekeep_status AttributeError: type object 'MemberSeminarAttendance' has no attribute 'meeting_id' ...
Event Count: 1
gatekeep_status AttributeError: type object 'TechnicalSeminar' has no attribute 'date' dashboar...
Event Count: 1

@goosenotduck
Copy link
Contributor

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: conditional/util/member.py
Function Unhandled Issue
gatekeep_status NameError: name 'request' is not defined dashboar...
Event Count: 3
gatekeep_status AttributeError: type object 'CommitteeMeeting' has no attribute 'date' dashboar...
Event Count: 2
gatekeep_status AttributeError: 'Query' object has no attribute 'filtgatekeep_statuser' dashboa...
Event Count: 1
gatekeep_status AttributeError: type object 'MemberSeminarAttendance' has no attribute 'meeting_id' ...
Event Count: 1
gatekeep_status AttributeError: type object 'TechnicalSeminar' has no attribute 'date' dashboar...
Event Count: 1

These can safely be ignored, from my dev by accident

costowell
costowell previously approved these changes Oct 21, 2025
Copy link
Contributor

@costowell costowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@goosenotduck goosenotduck self-requested a review October 21, 2025 16:34
goosenotduck
goosenotduck previously approved these changes Oct 21, 2025
Copy link
Contributor

@goosenotduck goosenotduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested fine, but lowkey realized that gatekeep 500s if the user doesn't exist. New pr time 🪇

@costowell costowell mentioned this pull request Oct 21, 2025
@goosenotduck goosenotduck changed the title move status for gatekeep response to route move status for gatekeep response to route + fix 500 if user does not exist Oct 21, 2025
@BigSpaceships BigSpaceships dismissed stale reviews from goosenotduck and costowell via b48db4f October 21, 2025 17:15
@BigSpaceships BigSpaceships merged commit 46ea5d2 into develop Oct 21, 2025
4 checks passed
@BigSpaceships BigSpaceships deleted the refactor-for-418 branch October 21, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants