Skip to content

move status for gatekeep response to route + fix 500 if user does not exist #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2025
Merged

move status for gatekeep response to route + fix 500 if user does not exist #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e636482
move status for gatekeep response to route
BigSpaceships Oct 21, 2025
888b082
fix me being dumb :)
BigSpaceships Oct 21, 2025
b48db4f
fix 500 error when requesting gatekeep for a user that doesn't exist
BigSpaceships Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions conditional/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,12 @@ def gatekeep(username):
token = request.headers.get("X-VOTE-TOKEN", "")
if token != app.config["VOTE_TOKEN"]:
return "Users cannot access this page", 403
try:
gatekeep_data = gatekeep_status(username)
except KeyError:
return "", 404

return gatekeep_status(username)


return gatekeep_data, 200


@app.errorhandler(404)
Expand Down
4 changes: 2 additions & 2 deletions conditional/util/member.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def get_voting_members():
for intro_member in passed_fall:
voting_set.add(intro_member.uid)

voting_list = list(username for username in voting_set if gatekeep_status(username)[0]["result"])
voting_list = list(username for username in voting_set if gatekeep_status(username)["result"])
return voting_list


Expand Down Expand Up @@ -238,4 +238,4 @@ def gatekeep_status(username):
"h_meetings": h_meetings,
"c_meetings": d_meetings,
"t_seminars": t_seminars,
}, 200
}