Skip to content

Warn about outdated NVIDIA drivers during fresh install #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 1 commit into from
Feb 4, 2026
Merged

Warn about outdated NVIDIA drivers during fresh install #1581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/install/installationManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ export class InstallationManager implements HasTelemetry {
useDesktopConfig().set('basePath', installOptions.installPath);
useDesktopConfig().set('versionConsentedMetrics', __COMFYUI_DESKTOP_VERSION__);
useDesktopConfig().set('selectedDevice', device);
await this.warnIfNvidiaDriverTooOld(device);

// Load the next page
const page = device === 'unsupported' ? 'not-supported' : 'server-start';
Expand Down Expand Up @@ -381,7 +382,7 @@ export class InstallationManager implements HasTelemetry {
try {
await installation.virtualEnvironment.installComfyUIRequirements(callbacks);
await installation.virtualEnvironment.installComfyUIManagerRequirements(callbacks);
await this.warnIfNvidiaDriverTooOld(installation);
await this.warnIfNvidiaDriverTooOld(installation.virtualEnvironment.selectedDevice);
// Disable automatic NVIDIA torch upgrades so users control large downloads.
// await installation.virtualEnvironment.ensureRecommendedNvidiaTorch(callbacks);
await installation.validate();
Expand All @@ -393,11 +394,11 @@ export class InstallationManager implements HasTelemetry {

/**
* Warns the user if their NVIDIA driver is too old for the required CUDA build.
* @param installation The current installation.
* @param device The device selected for installation.
*/
private async warnIfNvidiaDriverTooOld(installation: ComfyInstallation): Promise<void> {
private async warnIfNvidiaDriverTooOld(device: InstallOptions['device'] | undefined): Promise<void> {
if (process.platform !== 'win32') return;
if (installation.virtualEnvironment.selectedDevice !== 'nvidia') return;
if (device !== 'nvidia') return;

const driverVersion =
(await this.getNvidiaDriverVersionFromSmi()) ?? (await this.getNvidiaDriverVersionFromSmiFallback());
Expand Down
Loading