Remove rocm-sdk-devel from AMD ROCm SDK install#1519
Conversation
📝 WalkthroughWalkthroughA single AMD ROCm SDK devel wheel URL entry was removed from the AMD_ROCM_SDK_PACKAGES constant array in src/constants.ts. The constant's export signature and type remain unchanged; only the array contents were modified. Changes
Possibly related PRs
✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes the rocm-sdk-devel package from the AMD ROCm SDK installation list for Windows AMD installs, completing the removal that was started in PR #1511.
Key Changes:
- Removed the
rocm_sdk_develwheel URL from theAMD_ROCM_SDK_PACKAGESconstant inconstants.ts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Remove rocm-sdk-devel from AMD ROCm SDK install list.
What changed
Why
Evidence
yarn lint,yarn typescriptReferences
┆Issue is synchronized with this Notion page by Unito