Remove rocm-sdk-devel from AMD requirements

[benceruleanlu]

Summary

• drop rocm-sdk-devel from AMD Windows requirements
• update compiled AMD lockfile accordingly

Testing

• yarn format
• yarn lint
• yarn typescript

Relates to #1510

┆Issue is synchronized with this Notion page by Unito

[coderabbitai]

📝 Walkthrough

Walkthrough

Removes the rocm-sdk-devel package entry from AMD ROCm requirements files. The changes are reflected in both the source requirements file and its compiled lock file, while preserving other ROCm packages.

Changes

Cohort / File(s)	Summary
AMD ROCm dependencies assets/requirements/amd_requirements.txt, assets/requirements/windows_amd.compiled	Removed rocm-sdk-devel package specification from both the base requirements and compiled lock file; other ROCm packages (rocm-sdk-core, rocm-sdk-libraries-custom, rocm) remain unchanged

Possibly related PRs

• Add AMD GPU Support #1501: Directly relates to the same AMD ROCm package management lines being modified in this PR's requirements files.

---

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a6bb2b0 and 3afcac3.

📒 Files selected for processing (2)

• assets/requirements/amd_requirements.txt
• assets/requirements/windows_amd.compiled

💤 Files with no reviewable changes (2)

• assets/requirements/windows_amd.compiled
• assets/requirements/amd_requirements.txt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build-and-test-e2e-windows / integration-windows-test

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[socket-security]

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert  (click "▶" to expand/collapse)
Warn		Obfuscated code: npm entities is 91.0% likely obfuscated Confidence: 0.91 Location: Package overview From: ? → npm/entities@4.5.0 ℹ Read more on: This package | This alert | What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/entities@4.5.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

[Copilot]

Pull request overview

This PR removes the rocm-sdk-devel package from AMD Windows requirements, simplifying the ROCm SDK dependencies. The change addresses issue #1510 by eliminating an unnecessary development package from the runtime requirements.

• Removed rocm-sdk-devel from the AMD requirements source file
• Updated the compiled Windows AMD lockfile to reflect the removal

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
assets/requirements/amd_requirements.txt	Removed rocm-sdk-devel package dependency line
assets/requirements/windows_amd.compiled	Removed corresponding compiled entries for rocm-sdk-devel with its metadata

The changes are clean, consistent, and complete. Both the source requirements file and the compiled lockfile have been properly updated to remove the rocm-sdk-devel package. The remaining ROCm packages (rocm-sdk-core, rocm-sdk-libraries-custom, and rocm) are intact and properly referenced. No other files in the codebase reference this package, confirming the removal is thorough.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.