Update AMD ROCm 7.2 package pins#1564
Conversation
📝 WalkthroughWalkthroughUpdates AMD ROCm package versions and URLs from release 7.1.1 to 7.2 across configuration files and constants. PyTorch-related wheels (torch, torchaudio, torchvision) and ROCm SDK packages (rocm-sdk-core, rocm-sdk-libraries-custom, rocm) are bumped to their 7.2 equivalents with corresponding build identifiers. Changes
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows AMD ROCm package pins to target the ROCm 7.2 SDK and corresponding PyTorch wheels, keeping installer constants, overrides, and compiled requirements consistent.
Changes:
- Updated
AMD_ROCM_SDK_PACKAGESandAMD_TORCH_PACKAGESinsrc/constants.tsto point to ROCm 7.2.0.dev0 SDK artifacts and 2.9.1/0.24.1 AMD PyTorch wheels underrocm-rel-7.2. - Aligned
assets/requirements/amd_requirements.txtwith the new ROCm 7.2 SDK package URLs. - Updated
assets/requirements/windows_amd.compiledandassets/override_amd.txtso the compiled and override requirement sets match the new ROCm 7.2 and PyTorch wheel URLs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/constants.ts |
Bumps AMD ROCm SDK and PyTorch wheel URL constants to ROCm 7.2 and PyTorch 2.9.1/torchvision 0.24.1, keeping them in sync with NVIDIA versions and the installer logic. |
assets/requirements/windows_amd.compiled |
Updates pinned ROCm SDK and PyTorch wheel URLs in the compiled Windows AMD requirements to the ROCm 7.2 / 2.9.1 set. |
assets/requirements/amd_requirements.txt |
Switches base AMD ROCm SDK package pins for Windows to the ROCm 7.2.0.dev0 artifacts. |
assets/override_amd.txt |
Updates override entries to enforce installation of the ROCm 7.2 PyTorch/torchaudio/torchvision wheels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Links here: https://rocm.docs.amd.com/projects/radeon-ryzen/en/latest/docs/install/installryz/windows/install-pytorch.html
Tested on an RDNA4 machine and install works, packages resolve, inference happens
┆Issue is synchronized with this Notion page by Unito