Skip to content

Update AMD ROCm 7.2 package pins#1564

Merged
christian-byrne merged 1 commit intomainfrom
chore/amd-rocm-7-2
Jan 29, 2026
Merged

Update AMD ROCm 7.2 package pins#1564
christian-byrne merged 1 commit intomainfrom
chore/amd-rocm-7-2

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Jan 28, 2026

Summary

  • update Windows AMD ROCm SDK URLs to 7.2.0.dev0 packages
  • update AMD ROCm torch/torchaudio/torchvision wheel URLs to the 7.2 build
  • keep override and compiled requirements in sync with installer constants

Links here: https://rocm.docs.amd.com/projects/radeon-ryzen/en/latest/docs/install/installryz/windows/install-pytorch.html

Tested on an RDNA4 machine and install works, packages resolve, inference happens

┆Issue is synchronized with this Notion page by Unito

@benceruleanlu benceruleanlu requested a review from a team as a code owner January 28, 2026 20:05
Copilot AI review requested due to automatic review settings January 28, 2026 20:05
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. dependencies labels Jan 28, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

Updates AMD ROCm package versions and URLs from release 7.1.1 to 7.2 across configuration files and constants. PyTorch-related wheels (torch, torchaudio, torchvision) and ROCm SDK packages (rocm-sdk-core, rocm-sdk-libraries-custom, rocm) are bumped to their 7.2 equivalents with corresponding build identifiers.

Changes

Cohort / File(s) Summary
AMD ROCm 7.2 Dependency Updates
assets/override_amd.txt, assets/requirements/amd_requirements.txt, assets/requirements/windows_amd.compiled, src/constants.ts
Updated AMD ROCm package URLs and versions from 7.1.1 to 7.2 across all asset files and constants. PyTorch-related wheels migrated to 2.9.1+rocmsdk20260116 variants, and ROCm SDK packages updated to 7.2.0.dev0 builds. No new packages added; purely version and URL migrations.

Possibly related PRs

Poem

🐰 hops excitedly
ROCm rises from 7.1 to 7.2,
With torches and wheels all shiny and new,
AMD's SDK packages bloom and grow,
Constants and configs in harmony flow,
Updates cascade like carrots in spring! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title 'Update AMD ROCm 7.2 package pins' clearly and specifically summarizes the main change—upgrading AMD ROCm packages from 7.1.1 to 7.2 across multiple configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: ?npm/entities@4.5.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/entities@4.5.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Windows AMD ROCm package pins to target the ROCm 7.2 SDK and corresponding PyTorch wheels, keeping installer constants, overrides, and compiled requirements consistent.

Changes:

  • Updated AMD_ROCM_SDK_PACKAGES and AMD_TORCH_PACKAGES in src/constants.ts to point to ROCm 7.2.0.dev0 SDK artifacts and 2.9.1/0.24.1 AMD PyTorch wheels under rocm-rel-7.2.
  • Aligned assets/requirements/amd_requirements.txt with the new ROCm 7.2 SDK package URLs.
  • Updated assets/requirements/windows_amd.compiled and assets/override_amd.txt so the compiled and override requirement sets match the new ROCm 7.2 and PyTorch wheel URLs.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/constants.ts Bumps AMD ROCm SDK and PyTorch wheel URL constants to ROCm 7.2 and PyTorch 2.9.1/torchvision 0.24.1, keeping them in sync with NVIDIA versions and the installer logic.
assets/requirements/windows_amd.compiled Updates pinned ROCm SDK and PyTorch wheel URLs in the compiled Windows AMD requirements to the ROCm 7.2 / 2.9.1 set.
assets/requirements/amd_requirements.txt Switches base AMD ROCm SDK package pins for Windows to the ROCm 7.2.0.dev0 artifacts.
assets/override_amd.txt Updates override entries to enforce installation of the ROCm 7.2 PyTorch/torchaudio/torchvision wheels.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 29, 2026
@christian-byrne christian-byrne merged commit 1459202 into main Jan 29, 2026
28 of 29 checks passed
@christian-byrne christian-byrne deleted the chore/amd-rocm-7-2 branch January 29, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants