Skip to content

[backport cloud/1.37] Make sure toggle visibility checks remote config #8087

Closed
AustinMroz wants to merge 9 commits intomainfrom
backport-8086
Closed

[backport cloud/1.37] Make sure toggle visibility checks remote config #8087
AustinMroz wants to merge 9 commits intomainfrom
backport-8086

Conversation

@AustinMroz
Copy link
Collaborator

Manual backport

comfy-pr-bot and others added 9 commits January 13, 2026 20:43
…wright tests despite DisableWarnings setting (#8039)

Backport of #8036 to `cloud/1.37`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8039-backport-cloud-1-37-fix-version-mismatch-warning-appearing-in-Playwright-tests-despite-2e86d73d3650817d9534c0449798e7b1)
by [Unito](https://www.unito.io)

Co-authored-by: Christian Byrne <cbyrne@comfy.org>
…#8049)

Backport of #7966 to `cloud/1.37`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8049-backport-cloud-1-37-API-Nodes-add-price-badges-for-Meshy-3D-nodes-2e86d73d3650815b8df4c0f4c2957f65)
by [Unito](https://www.unito.io)

Co-authored-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com>
Backport of #8031 to `cloud/1.37`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8051-backport-cloud-1-37-Fix-Update-for-Image-Widget-test-2e86d73d365081bba5e0e5f75aa8a7d9)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Alexander Brown <448862+DrJKL@users.noreply.github.com>
…prices (#8059)

Backport of #8046 to `cloud/1.37`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8059-backport-cloud-1-37-feat-price-badges-add-ByteDance-SeeDance-1-5-prices-2e96d73d3650817894e2e7350ccfb8c5)
by [Unito](https://www.unito.io)

Co-authored-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com>
Backport of #8054 to `cloud/1.37`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8072-backport-cloud-1-37-Linear-mode-bug-fixes-2e96d73d365081dfa542f08405043203)
by [Unito](https://www.unito.io)

Co-authored-by: AustinMroz <austin@comfy.org>
…wing node bounds (#8082)

Backport of #8070 to `cloud/1.37`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8082-backport-cloud-1-37-fix-prevent-Record-Audio-waveform-from-overflowing-node-bounds-2e96d73d36508112b881df2c4bf5fd3c)
by [Unito](https://www.unito.io)

Co-authored-by: Terry Jia <terryjia88@gmail.com>
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 16, 2026
@AustinMroz AustinMroz closed this Jan 16, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

This pull request introduces linear mode, a simplified workflow UI for sequential asset processing. It adds new components for image preview and drag-and-drop workflows, integrates feature flags and mode toggles, expands Meshy node pricing calculations, refactors node data extraction, and includes design system enhancements, localization updates, and various UI/styling improvements.

Changes

Cohort / File(s) Summary
Linear Mode UI Components
src/renderer/extensions/linearMode/{DropZone,ImagePreview,LinearControls,LinearPreview,OutputHistory,Preview3d,VideoPreview}.vue, src/renderer/extensions/linearMode/mediaTypes.ts
New Vue components for linear mode workflow: drag-and-drop zone, image/video/3D preview, run controls with batching, output history with navigation, and media type utilities. High complexity in LinearControls (queue, execution, subscription state) and OutputHistory (infinite scroll, selection).
Linear Mode Integration
src/components/sidebar/{ModeToggle,SideToolbar}.vue, src/views/{LinearView,GraphView}.vue, src/stores/menuItemStore.ts
Add mode toggle button and integrate linear mode into sidebar and main views. LinearView significantly refactored with responsive mobile/desktop layouts and new component composition. Adds hasSeenLinear tracking.
Zoom & Layout Components
src/components/ui/{ZoomPane,Popover,TypeformPopoverButton}.vue
New reusable UI primitives: ZoomPane for interactive zoom/pan, Popover for grouped actions with reka-ui, TypeformPopoverButton for dynamic feedback embed.
Feature Flags & Configuration
src/composables/useFeatureFlags.ts, src/platform/remoteConfig/types.ts, src/locales/en/{commands,main}.json
Add LINEAR_TOGGLE_ENABLED feature flag with remoteConfig support. Update command/UI labels ("toggle linear mode" → "Toggle Simple Mode"). Expand linearMode localization with new keys (linearMode, graphMode, beta, etc.). Add asset pluralization and text filter.
Meshy Node Pricing
src/composables/node/useNodePricing.ts
Introduce MESHY_CREDIT_PRICE_USD and helper functions (meshyCreditsToUsd, calculateMeshyImageToModelPrice, calculateMeshyMultiImageToModelPrice). Add pricing entries for 7 Meshy nodes and widget-relevance mappings (should_texture). Update ByteDance nodes with generate_audio widget.
Node Data Extraction & Widget Refactoring
src/composables/graph/useGraphNodeManager.ts, src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.ts, src/lib/litegraph/src/types/widgets.ts, src/renderer/extensions/vueNodes/widgets/{components/LGraphNode,composables/useComboWidget}.vue|.ts
Refactor node data extraction: introduce extractVueNodeData (public) replacing isValidWidgetValue, make safeWidgetMapper private. Update asset widget to use openModal callback via IWidgetAssetOptions. Move light-theme color logic to runtime checks in nodeStyleUtils.
Version & State Management
src/platform/updates/common/{useFrontendVersionMismatchWarning,versionCompatibilityStore}.ts, src/platform/workflow/{core/services/workflowService,management/stores/workflowStore}.ts
Add async/await nextTick to version mismatch watcher for reactive synchronization. Extract warningsDisabled into computed for reuse. Sync linearMode state between workflow data and canvas store on load; remove redundant canvas sync from workflowStore.
UI & Styling Refinements
src/components/topbar/{TopMenuHelpButton,WorkflowTab}.vue, src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue, src/renderer/extensions/vueNodes/utils/nodeStyleUtils.ts, src/components/sidebar/tabs/WorkflowsSidebarTab.vue
Wrap help button text in responsive div; add linear-mode icon to inactive workflow tabs. Tighten WidgetRecordAudio layout (reduced gap/padding, shrink-0, overflow fixes). Inline header style with applyLightThemeColor call. Add v-bind="$attrs" forwarding to SidebarTabTemplate.
Design System
packages/design-system/src/css/style.css
Add new --success-background custom property (mapped to --color-jade-600) and public alias --color-success-background in both light and dark theme sections.
Testing & Utilities
browser_tests/tests/widget.spec.ts, src/utils/dateTimeUtil.ts, src/renderer/extensions/linearMode/mediaTypes.ts, src/scripts/app.ts, src/stores/imagePreviewStore.ts, src/platform/workflow/templates/composables/useTemplateWorkflows.ts, vite.config.mts
Update image widget test: replace noWaitAfter with nextFrame stabilization. Add formatDuration utility. Guard fitView with visible_area size check. Rename latestOutput to latestPreview. Simplify template workflow loading flow. Add vendor-reka-ui Vite chunk.
Command & Mode Toggle
src/composables/useCoreCommands.ts
Update Comfy.ToggleLinear command to synchronize linearMode across app.rootGraph.extra, workflowStore change tracker, and canvas store in multi-step flow instead of direct assignment.

Possibly related PRs

Suggested reviewers

  • shinshin86
  • KarryCharon
  • PabloWiedemann
  • Yorha4D

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AustinMroz AustinMroz deleted the backport-8086 branch January 16, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants