Skip to content

fix: prevent Record Audio waveform from overflowing node bounds#8070

Merged
jtydhr88 merged 1 commit intomainfrom
fix/record-audio-waveform-overflow
Jan 15, 2026
Merged

fix: prevent Record Audio waveform from overflowing node bounds#8070
jtydhr88 merged 1 commit intomainfrom
fix/record-audio-waveform-overflow

Conversation

@jtydhr88
Copy link
Collaborator

@jtydhr88 jtydhr88 commented Jan 15, 2026 •
edited by sync-by-unito bot
Loading

Summary

Add min-w-0 to flex containers to allow shrinking, reduce gaps and padding, and use shrink-0 on fixed-size elements to ensure the waveform area clips properly when the node is at minimum width.

Screenshots (if applicable)

before
https://github.com/user-attachments/assets/215455aa-555b-4ade-9b36-9e89ac7c14aa

after
https://github.com/user-attachments/assets/bf56028b-ae02-4388-be83-460c7b1f14e1

┆Issue is synchronized with this Notion page by Unito

@jtydhr88 jtydhr88 requested a review from a team as a code owner January 15, 2026 02:51
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 15, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 15, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

This change adjusts the layout styling of a Vue audio widget component by modifying CSS class attributes. Changes include reducing padding and gaps, altering overflow behavior, adding flex shrink constraints, and removing some minimum width classes to improve layout flexibility.

Changes

Cohort / File(s) Summary
Widget Audio Recording Layout Adjustments
src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue		 Reduced padding (px-4 → px-3) and gap (gap-4 → gap-2); added min-w-0 and shrink-0 to improve flex layout behavior; changed overflow-x-clip to overflow-hidden; removed minimum width constraints from status text elements

Suggested reviewers

  • DrJKL
  • Myestery
📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 29f727a and 87d103d.

📒 Files selected for processing (1)
  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
🧰 Additional context used
📓 Path-based instructions (7)
src/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions

src/**/*.vue: Use Vue 3 Single File Components (SFCs) with Composition API only
Use <script setup lang="ts"> for component logic in Vue SFCs
Avoid <style> blocks in Vue components - use Tailwind 4 styling instead
Use vue-i18n for all string literals in Vue components - place translation entries in src/locales/en/main.json
Use Tailwind utility classes instead of dark: variant - use semantic values from style.css theme (e.g., bg-node-component-surface)
Use cn() utility from @/utils/tailwindUtil for merging Tailwind class names instead of :class="[]" or hardcoding
Never use !important or ! Tailwind prefix - fix interfering classes instead
Use Tailwind fraction utilities instead of arbitrary percentage values (e.g., w-4/5 instead of w-[80%])
Use TypeScript Vue 3.5 style default prop declaration with reactive props destructuring - avoid withDefaults or runtime props
Prefer defineModel over separately defining a prop and emit for v-model bindings
Define slots via template usage, not via defineSlots
Use same-name shorthand for slot prop bindings (e.g., :isExpanded instead of :is-expanded="isExpanded")
Do not import Vue macros unnecessarily
Avoid new usage of PrimeVue components
Use Tailwind's plurals system via i18n instead of hardcoding ...

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: Use separate import type statements instead of inline type in mixed imports
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, 80-character width
Sort and group imports by plugin, run pnpm format before committing
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue
Write code that is expressive and self-documenting - avoid unnecessary comments
Do not add or retain redundant comments - clean as you go
Avoid mutable state - prefer immutability and assignment at point of declaration
Watch out for Code Smells and refactor to avoid them

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
src/**/*.{ts,vue}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,vue}: Use ref for reactive state, computed() for derived values, and watch/watchEffect for side effects in Composition API
Avoid using ref with watch if a computed would suffice - minimize refs and derived state
Use provide/inject for dependency injection only when simpler alternatives (Store or shared composable) won't work
Leverage VueUse functions for performance-enhancing composables
Use VueUse function for useI18n in composition API for string literals

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
🧠 Learnings (12)
📓 Common learnings 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:44.374Z
Learning: Comfy-Org/ComfyUI_frontend uses Tailwind CSS v4 utilities, including the new “safe” overflow-alignment classes. Do not flag items-center-safe, justify-*-safe, or place-*-safe utilities as invalid in src/**/*.vue or stories.
📚 Learning: 2025-12-09T03:49:52.828Z 
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
📚 Learning: 2025-12-09T21:40:12.361Z 
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.

Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
📚 Learning: 2025-12-16T22:26:49.463Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
📚 Learning: 2025-12-22T21:36:08.369Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
📚 Learning: 2026-01-08T02:26:18.357Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:18.357Z
Learning: In components that use the cn utility from '@/utils/tailwindUtil' with tailwind-merge, rely on the behavior that conflicting Tailwind classes are resolved by keeping the last one. For example, cn('base-classes bg-default', propClass) will have any conflicting background class from propClass override bg-default. This additive pattern is intentional and aligns with the shadcn-ui convention; ensure you document or review expectations accordingly in Vue components.

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
📚 Learning: 2025-12-11T03:55:51.755Z 
Learnt from: simula-r
Repo: Comfy-Org/ComfyUI_frontend PR: 7252
File: src/renderer/extensions/vueNodes/components/ImagePreview.vue:151-158
Timestamp: 2025-12-11T03:55:51.755Z
Learning: In Vue components under src/renderer/extensions/vueNodes (e.g., ImagePreview.vue and LGraphNode.vue), implement image gallery keyboard navigation so that it responds to the node's focus state rather than requiring focus inside the image preview wrapper. Achieve this by wiring keyEvent handling at the node focus level and injecting or propagating key events (arrow keys) to the gallery when the node is focused/selected. This improves accessibility and aligns navigation with node-level focus behavior.

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
📚 Learning: 2025-12-11T12:25:15.470Z 
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
📚 Learning: 2025-12-18T02:07:38.870Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
📚 Learning: 2025-12-18T21:15:46.862Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
📚 Learning: 2025-12-21T01:06:02.786Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
📚 Learning: 2026-01-12T17:39:27.738Z 
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7906
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:545-552
Timestamp: 2026-01-12T17:39:27.738Z
Learning: In Vue/TypeScript files (src/**/*.{ts,tsx,vue}), prefer if/else statements over ternary operators when performing side effects or actions (e.g., mutating state, calling methods with side effects). Ternaries should be reserved for computing and returning values.

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: deploy-and-comment
  • GitHub Check: setup
  • GitHub Check: lint-and-format
  • GitHub Check: test
  • GitHub Check: collect
🔇 Additional comments (4)
src/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vue (4)

13-16: LGTM! Proper flex overflow prevention pattern.

Adding min-w-0 to the flex container correctly allows children to shrink below their intrinsic minimum width, which is essential for preventing overflow. The reduced padding and gap values appropriately accommodate smaller node widths.

18-31: Good use of shrink-0 for fixed-content elements.

Applying shrink-0 to the status container ensures the text labels remain readable and don't compress, while the waveform area (with flex-1) absorbs any necessary shrinking. This is the correct approach for preserving important UI text.

33-42: Correct overflow handling for the waveform visualization.

The combination of min-w-0 (allowing the flex item to shrink below content width) and overflow-hidden (clipping overflowing bars) properly addresses the overflow issue. This ensures the waveform clips gracefully when the node is resized to minimum width.

44-70: Appropriate shrink-0 on fixed-size control buttons.

Adding shrink-0 to all control buttons prevents them from being compressed in the flex layout. Since these buttons have explicit fixed dimensions (size-8), this ensures they maintain their intended appearance and remain easily tappable regardless of the container's available width.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 15, 2026 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 01/15/2026, 02:53:32 AM UTC

🔗 Links

🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Jan 15, 2026 •
edited
Loading

🎭 Playwright Tests: ⚠️ Passed with flaky tests

Results: 503 passed, 0 failed, 2 flaky, 8 skipped (Total: 513)

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 493 / ❌ 0 / ⚠️ 1 / ⏭️ 8)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

@coderabbitai coderabbitai bot requested review from DrJKL and Myestery January 15, 2026 02:52
@github-actions
Copy link

github-actions bot commented Jan 15, 2026

Bundle Size Report

Summary

  • Raw size: 19.7 MB baseline 19.7 MB — 🔴 +25 B
  • Gzip: 4.01 MB baseline 4.01 MB — 🔴 +6 B
  • Brotli: 3.06 MB baseline 3.06 MB — 🟢 -86 B
  • Bundles: 99 current • 99 baseline • 38 added / 38 removed

Category Glance
Other 🔴 +25 B (5.25 MB) · Vendor & Third-Party ⚪ 0 B (9.34 MB) · App Entry Points ⚪ 0 B (3.34 MB) · Graph Workspace ⚪ 0 B (1.15 MB) · Panels & Settings ⚪ 0 B (372 kB) · UI Components ⚪ 0 B (209 kB) · + 3 more

Per-category breakdown
App Entry Points — 3.34 MB (baseline 3.34 MB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-BEcNU0Ot.js (removed) 3.14 MB — 🟢 -3.14 MB 🟢 -657 kB 🟢 -499 kB
assets/index-DBuxV2Ze.js (new) — 3.14 MB 🔴 +3.14 MB 🔴 +657 kB 🔴 +499 kB
assets/index-BUolqGS6.js (new) — 200 kB 🔴 +200 kB 🔴 +44 kB 🔴 +36.5 kB
assets/index-DuGghTnm.js (removed) 200 kB — 🟢 -200 kB 🟢 -44 kB 🟢 -36.4 kB
assets/index-Bs3pd5wf.js (new) — 345 B 🔴 +345 B 🔴 +244 B 🔴 +233 B
assets/index-DrtsZ6q4.js (removed) 345 B — 🟢 -345 B 🟢 -246 B 🟢 -202 B

Status: 3 added / 3 removed

Graph Workspace — 1.15 MB (baseline 1.15 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-CjSYMz9D.js (new) — 1.15 MB 🔴 +1.15 MB 🔴 +220 kB 🔴 +165 kB
assets/GraphView-SP99TtgG.js (removed) 1.15 MB — 🟢 -1.15 MB 🟢 -220 kB 🟢 -165 kB

Status: 1 added / 1 removed

Views & Navigation — 6.66 kB (baseline 6.66 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/UserSelectView-DMpz6yrH.js (removed) 6.66 kB — 🟢 -6.66 kB 🟢 -2.16 kB 🟢 -1.91 kB
assets/UserSelectView-j4A-gqYg.js (new) — 6.66 kB 🔴 +6.66 kB 🔴 +2.16 kB 🔴 +1.91 kB

Status: 1 added / 1 removed

Panels & Settings — 372 kB (baseline 372 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/LegacyCreditsPanel-C9ZI06NT.js (new) — 25.2 kB 🔴 +25.2 kB 🔴 +5.76 kB 🔴 +5.01 kB
assets/LegacyCreditsPanel-DvkWKWMK.js (removed) 25.2 kB — 🟢 -25.2 kB 🟢 -5.76 kB 🟢 -5.02 kB
assets/KeybindingPanel-ApEuOX6_.js (removed) 14.9 kB — 🟢 -14.9 kB 🟢 -3.59 kB 🟢 -3.14 kB
assets/KeybindingPanel-BJuWKu65.js (new) — 14.9 kB 🔴 +14.9 kB 🔴 +3.59 kB 🔴 +3.13 kB
assets/ExtensionPanel-943usnLG.js (new) — 11.1 kB 🔴 +11.1 kB 🔴 +2.63 kB 🔴 +2.31 kB
assets/ExtensionPanel-MQnu84Wn.js (removed) 11.1 kB — 🟢 -11.1 kB 🟢 -2.63 kB 🟢 -2.31 kB
assets/AboutPanel-BWjybvQl.js (new) — 9.2 kB 🔴 +9.2 kB 🔴 +2.48 kB 🔴 +2.22 kB
assets/AboutPanel-CNCcWicC.js (removed) 9.2 kB — 🟢 -9.2 kB 🟢 -2.47 kB 🟢 -2.23 kB
assets/ServerConfigPanel-7za6-1fa.js (new) — 7.55 kB 🔴 +7.55 kB 🔴 +2.06 kB 🔴 +1.82 kB
assets/ServerConfigPanel-dIbItxwR.js (removed) 7.55 kB — 🟢 -7.55 kB 🟢 -2.06 kB 🟢 -1.83 kB
assets/UserPanel-BHVbFuwx.js (removed) 6.92 kB — 🟢 -6.92 kB 🟢 -1.81 kB 🟢 -1.58 kB
assets/UserPanel-CzA6iMQY.js (new) — 6.92 kB 🔴 +6.92 kB 🔴 +1.81 kB 🔴 +1.58 kB
assets/settings-BGQfQzTx.js 25.6 kB 25.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BVE4KHTw.js 22.7 kB 22.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BVtpJmlU.js 30.9 kB 30.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-C2aO00Dz.js 28.6 kB 28.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-Cm3ieBXR.js 27.8 kB 27.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CzQKMdK3.js 26.2 kB 26.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CzYUIUnL.js 27.1 kB 27.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DwKpL7jw.js 26.3 kB 26.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DX8feV4n.js 25.3 kB 25.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-mWzYycGc.js 22 kB 22 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-U4AdZ8Rl.js 34.9 kB 34.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 6 added / 6 removed

UI Components — 209 kB (baseline 209 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/LazyImage.vue_vue_type_script_setup_true_lang-CwMqtpea.js (removed) 69.6 kB — 🟢 -69.6 kB 🟢 -14.2 kB 🟢 -12.3 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-Dum0lkdV.js (new) — 69.6 kB 🔴 +69.6 kB 🔴 +14.2 kB 🔴 +12.3 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-BtlgLWpR.js (removed) 56.4 kB — 🟢 -56.4 kB 🟢 -8.78 kB 🟢 -7.55 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-Dgyad8gw.js (new) — 56.4 kB 🔴 +56.4 kB 🔴 +8.78 kB 🔴 +7.53 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-6nuypd2K.js (removed) 48.1 kB — 🟢 -48.1 kB 🟢 -10.4 kB 🟢 -9 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-nGB2Hv__.js (new) — 48.1 kB 🔴 +48.1 kB 🔴 +10.4 kB 🔴 +9 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-Cp2rcqsj.js (new) — 16.4 kB 🔴 +16.4 kB 🔴 +4.11 kB 🔴 +3.64 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-DGzk8-6A.js (removed) 16.4 kB — 🟢 -16.4 kB 🟢 -4.11 kB 🟢 -3.64 kB
assets/ComfyQueueButton-BKNNoZ-1.js (new) — 8.87 kB 🔴 +8.87 kB 🔴 +2.6 kB 🔴 +2.31 kB
assets/ComfyQueueButton-C8Jea8DJ.js (removed) 8.87 kB — 🟢 -8.87 kB 🟢 -2.6 kB 🟢 -2.31 kB
assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-BeUN3ei_.js (new) — 3.75 kB 🔴 +3.75 kB 🔴 +1.47 kB 🔴 +1.33 kB
assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-DaNi360P.js (removed) 3.75 kB — 🟢 -3.75 kB 🟢 -1.47 kB 🟢 -1.33 kB
assets/WidgetButton-nRbfp1zG.js (new) — 2.25 kB 🔴 +2.25 kB 🔴 +1.01 kB 🔴 +913 B
assets/WidgetButton-U03IDX91.js (removed) 2.25 kB — 🟢 -2.25 kB 🟢 -1.01 kB 🟢 -915 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-DgF28yMI.js (removed) 2.14 kB — 🟢 -2.14 kB 🟢 -891 B 🟢 -773 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-NRD-Xqd1.js (new) — 2.14 kB 🔴 +2.14 kB 🔴 +891 B 🔴 +767 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-IJTLOeU1.js 1.34 kB 1.34 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 8 added / 8 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/keybindingService-Bp5ibD6p.js (new) — 7.51 kB 🔴 +7.51 kB 🔴 +1.83 kB 🔴 +1.57 kB
assets/keybindingService-BZtgVvVj.js (removed) 7.51 kB — 🟢 -7.51 kB 🟢 -1.83 kB 🟢 -1.57 kB
assets/audioService-BQnxfEX4.js (removed) 2.2 kB — 🟢 -2.2 kB 🟢 -961 B 🟢 -833 B
assets/audioService-Du5rG8uU.js (new) — 2.2 kB 🔴 +2.2 kB 🔴 +962 B 🔴 +829 B
assets/serverConfigStore-DyIvWaGz.js 2.83 kB 2.83 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/audioUtils-27cHnfGR.js (removed) 1.41 kB — 🟢 -1.41 kB 🟢 -650 B 🟢 -542 B
assets/audioUtils-CUQ136au.js (new) — 1.41 kB 🔴 +1.41 kB 🔴 +652 B 🔴 +548 B

Status: 1 added / 1 removed

Vendor & Third-Party — 9.34 MB (baseline 9.34 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-chart-DZdD68iT.js 452 kB 452 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-other-C9GFBFnP.js 3.93 MB 3.93 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-primevue-NX-4NPlN.js 1.95 MB 1.95 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-reka-ui-7Sidv1he.js 111 kB 111 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-three-Bz1zdJb0.js 2.08 MB 2.08 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-tiptap-DFkXpum7.js 232 kB 232 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-vue-DMH2Ziq4.js 165 kB 165 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-xterm-BF8peZ5_.js 420 kB 420 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Other — 5.25 MB (baseline 5.25 MB) • 🔴 +25 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/SubscriptionRequiredDialogContent-B1zzAvtx.js (removed) 29.3 kB — 🟢 -29.3 kB 🟢 -6.5 kB 🟢 -5.66 kB
assets/SubscriptionRequiredDialogContent-CeQ9n0s3.js (new) — 29.3 kB 🔴 +29.3 kB 🔴 +6.51 kB 🔴 +5.65 kB
assets/WidgetRecordAudio-tWHS0xO6.js (new) — 20.5 kB 🔴 +20.5 kB 🔴 +5.24 kB 🔴 +4.65 kB
assets/WidgetRecordAudio-RaQywv7a.js (removed) 20.5 kB — 🟢 -20.5 kB 🟢 -5.25 kB 🟢 -4.65 kB
assets/AudioPreviewPlayer-CLpCLjIC.js (new) — 13.4 kB 🔴 +13.4 kB 🔴 +3.36 kB 🔴 +3.01 kB
assets/AudioPreviewPlayer-CQDqMAsg.js (removed) 13.4 kB — 🟢 -13.4 kB 🟢 -3.36 kB 🟢 -3 kB
assets/ValueControlPopover-DFwMYZW3.js (new) — 5.53 kB 🔴 +5.53 kB 🔴 +1.72 kB 🔴 +1.53 kB
assets/ValueControlPopover-DLLZywZF.js (removed) 5.53 kB — 🟢 -5.53 kB 🟢 -1.72 kB 🟢 -1.53 kB
assets/WidgetGalleria-BpiFv0DO.js (removed) 4.14 kB — 🟢 -4.14 kB 🟢 -1.46 kB 🟢 -1.32 kB
assets/WidgetGalleria-C9MiIK7c.js (new) — 4.14 kB 🔴 +4.14 kB 🔴 +1.46 kB 🔴 +1.32 kB
assets/WidgetColorPicker-inD58tF7.js (new) — 3.44 kB 🔴 +3.44 kB 🔴 +1.4 kB 🔴 +1.25 kB
assets/WidgetColorPicker-L2KPuoKc.js (removed) 3.44 kB — 🟢 -3.44 kB 🟢 -1.4 kB 🟢 -1.25 kB
assets/WidgetTextarea-B6Fs5sQw.js (removed) 3.12 kB — 🟢 -3.12 kB 🟢 -1.23 kB 🟢 -1.11 kB
assets/WidgetTextarea-DsxQcC_R.js (new) — 3.12 kB 🔴 +3.12 kB 🔴 +1.23 kB 🔴 +1.09 kB
assets/WidgetMarkdown-BY0IRa92.js (removed) 3.12 kB — 🟢 -3.12 kB 🟢 -1.3 kB 🟢 -1.14 kB
assets/WidgetMarkdown-DBihORC-.js (new) — 3.12 kB 🔴 +3.12 kB 🔴 +1.29 kB 🔴 +1.14 kB
assets/WidgetAudioUI-CPWD9WIj.js (new) — 2.93 kB 🔴 +2.93 kB 🔴 +1.18 kB 🔴 +1.07 kB
assets/WidgetAudioUI-CYHjWbCj.js (removed) 2.93 kB — 🟢 -2.93 kB 🟢 -1.18 kB 🟢 -1.07 kB
assets/WidgetToggleSwitch-BKALIGtL.js (new) — 2.7 kB 🔴 +2.7 kB 🔴 +1.14 kB 🔴 +1.03 kB
assets/WidgetToggleSwitch-CnfZGEqF.js (removed) 2.7 kB — 🟢 -2.7 kB 🟢 -1.14 kB 🟢 -1.03 kB
assets/WidgetInputText-4o9fbw2d.js (new) — 2.03 kB 🔴 +2.03 kB 🔴 +936 B 🔴 +867 B
assets/WidgetInputText-DXSPKFmI.js (removed) 2.03 kB — 🟢 -2.03 kB 🟢 -935 B 🟢 -861 B
assets/Media3DTop-DBsSwjRY.js (new) — 1.53 kB 🔴 +1.53 kB 🔴 +781 B 🔴 +671 B
assets/Media3DTop-DXJJsMlz.js (removed) 1.53 kB — 🟢 -1.53 kB 🟢 -782 B 🟢 -672 B
assets/WidgetSelect-CircntNd.js (removed) 772 B — 🟢 -772 B 🟢 -377 B 🟢 -352 B
assets/WidgetSelect-D1WLGLWK.js (new) — 772 B 🔴 +772 B 🔴 +378 B 🔴 +356 B
assets/WidgetInputNumber-AV_KFNCu.js (removed) 712 B — 🟢 -712 B 🟢 -361 B 🟢 -326 B
assets/WidgetInputNumber-B5U1Enz3.js (new) — 712 B 🔴 +712 B 🔴 +361 B 🔴 +327 B
assets/Load3D-DJHUbsED.js (new) — 463 B 🔴 +463 B 🔴 +282 B 🔴 +241 B
assets/Load3D-rj29YKyb.js (removed) 463 B — 🟢 -463 B 🟢 -284 B 🟢 -238 B
assets/WidgetLegacy-CbW8vPQA.js (removed) 403 B — 🟢 -403 B 🟢 -254 B 🟢 -213 B
assets/WidgetLegacy-DEo9YjE4.js (new) — 403 B 🔴 +403 B 🔴 +252 B 🔴 +213 B
assets/commands-B32ZbeYu.js 16.5 kB 16.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-B7wQT83I.js 17 kB 17 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BK3JVjMG.js 15.7 kB 15.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-C6twMpaZ.js 15.5 kB 15.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CDUWpEwM.js 18.3 kB 18.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CfZ6FPZ-.js 15.7 kB 15.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-COIPP_pv.js 17 kB 17 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CoPn_77e.js 14.7 kB 14.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CuRNS4XD.js 14.9 kB 14.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DBHjCSPA.js 16.2 kB 16.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DZJaRLKH.js 15.7 kB 15.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-8eC7XcBf.js 95 kB 95 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BpcYE6Bq.js 109 kB 109 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BRhbiQsB.js 129 kB 129 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BrWdnTiG.js 113 kB 113 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-C-cUNbuc.js 123 kB 123 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CGe0e9vH.js 106 kB 106 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Cv9Dlj-b.js 107 kB 107 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CzsdJqwO.js 94.3 kB 94.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Dbu4m_fl.js 133 kB 133 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DwAX_AEJ.js 149 kB 149 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-kiVYDd2_.js 110 kB 110 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaAudioTop-DUiRGHAk.js 1.46 kB 1.46 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaImageTop-bDoNEAep.js 1.75 kB 1.75 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaVideoTop-BrNs2ijx.js 2.65 kB 2.65 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-B-XzzBeS.js 317 kB 317 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BGwoeek4.js 329 kB 329 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-C6xl5-mL.js 358 kB 358 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CRZGOJB7.js 310 kB 310 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-D8-Yzlzh.js 289 kB 289 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Du8VrAwA.js 320 kB 320 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-jjlLVrIs.js 317 kB 317 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-JQwk1kgy.js 292 kB 292 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-JuuXdMpv.js 391 kB 391 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-l2Y20bod.js 314 kB 314 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-VLMdhOwo.js 357 kB 357 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/OBJLoader2WorkerModule-DTMpvldF.js 109 kB 109 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetChart-CTa5K4p_.js 2.48 kB 2.48 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetImageCompare-BAyqYPiH.js 3.21 kB 3.21 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js 1.28 kB 1.28 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 16 added / 16 removed

@christian-byrne christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.37 Backport PRs for core 1.37 cloud/1.37 Backport PRs for cloud 1.37 labels Jan 15, 2026
@Myestery
Copy link
Contributor

Myestery commented Jan 15, 2026

It will be nice to have the waveform fill the whole width when the node is resized

@christian-byrne christian-byrne assigned jtydhr88 and unassigned Myestery Jan 15, 2026
@jtydhr88 jtydhr88 merged commit aff7f2a into main Jan 15, 2026
41 of 42 checks passed
@jtydhr88 jtydhr88 deleted the fix/record-audio-waveform-overflow branch January 15, 2026 20:49
github-actions bot pushed a commit that referenced this pull request Jan 15, 2026
@jtydhr88 @github-actions
fix: prevent Record Audio waveform from overflowing node bounds (#8070)
6834fe4 
## Summary

Add min-w-0 to flex containers to allow shrinking, reduce gaps and
padding, and use shrink-0 on fixed-size elements to ensure the waveform
area clips properly when the node is at minimum width.

## Screenshots (if applicable)
before

https://github.com/user-attachments/assets/215455aa-555b-4ade-9b36-9e89ac7c14aa


after

https://github.com/user-attachments/assets/bf56028b-ae02-4388-be83-460c7b1f14e1

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8070-fix-prevent-Record-Audio-waveform-from-overflowing-node-bounds-2e96d73d3650816b9660e5532ffa0bc3)
by [Unito](https://www.unito.io)
github-actions bot pushed a commit that referenced this pull request Jan 15, 2026
@jtydhr88 @github-actions
fix: prevent Record Audio waveform from overflowing node bounds (#8070)
3fac816 
## Summary

Add min-w-0 to flex containers to allow shrinking, reduce gaps and
padding, and use shrink-0 on fixed-size elements to ensure the waveform
area clips properly when the node is at minimum width.

## Screenshots (if applicable)
before

https://github.com/user-attachments/assets/215455aa-555b-4ade-9b36-9e89ac7c14aa


after

https://github.com/user-attachments/assets/bf56028b-ae02-4388-be83-460c7b1f14e1

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8070-fix-prevent-Record-Audio-waveform-from-overflowing-node-bounds-2e96d73d3650816b9660e5532ffa0bc3)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot mentioned this pull request Jan 15, 2026
Merged
@comfy-pr-bot
Copy link
Member

comfy-pr-bot commented Jan 15, 2026

@jtydhr88 Successfully backported to #8081

@comfy-pr-bot comfy-pr-bot mentioned this pull request Jan 15, 2026
Merged
@comfy-pr-bot
Copy link
Member

comfy-pr-bot commented Jan 15, 2026

@jtydhr88 Successfully backported to #8082

@github-actions github-actions bot removed the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Jan 15, 2026
DrJKL pushed a commit that referenced this pull request Jan 15, 2026
@comfy-pr-bot @jtydhr88
[backport core/1.37] fix: prevent Record Audio waveform from overflow…
64be988 
…ing node bounds (#8081)

Backport of #8070 to `core/1.37`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8081-backport-core-1-37-fix-prevent-Record-Audio-waveform-from-overflowing-node-bounds-2e96d73d365081fc85eddf301c4624e1)
by [Unito](https://www.unito.io)

Co-authored-by: Terry Jia <terryjia88@gmail.com>
DrJKL pushed a commit that referenced this pull request Jan 15, 2026
@comfy-pr-bot @jtydhr88
[backport cloud/1.37] fix: prevent Record Audio waveform from overflo…
a3cd630 
…wing node bounds (#8082)

Backport of #8070 to `cloud/1.37`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8082-backport-cloud-1-37-fix-prevent-Record-Audio-waveform-from-overflowing-node-bounds-2e96d73d36508112b881df2c4bf5fd3c)
by [Unito](https://www.unito.io)

Co-authored-by: Terry Jia <terryjia88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrJKL DrJKL DrJKL approved these changes

@Myestery Myestery Awaiting requested review from Myestery

Assignees

@jtydhr88 jtydhr88

Labels

cloud/1.37 Backport PRs for cloud 1.37 core/1.37 Backport PRs for core 1.37 size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jtydhr88 @Myestery @comfy-pr-bot @DrJKL @christian-byrne