Skip to content

[backport cloud/1.37] fix: version mismatch warning appearing in Playwright tests despite DisableWarnings setting#8039

Merged
christian-byrne merged 1 commit intocloud/1.37from
backport-8036-to-cloud-1.37
Jan 14, 2026
Merged

[backport cloud/1.37] fix: version mismatch warning appearing in Playwright tests despite DisableWarnings setting#8039
christian-byrne merged 1 commit intocloud/1.37from
backport-8036-to-cloud-1.37

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Jan 14, 2026

Backport of #8036 to cloud/1.37

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

…isableWarnings setting (#8036)

PR #7004 added a setting to disable version warnings in e2e tests, but
it wasn't working on release branches. The issue was a race condition
(hypothesis): the version check ran before settings finished loading
from the backend, so the DisableWarnings setting read its default value
(false) instead of the configured value (true).

Fixed by making the warningsDisabled check reactive so it updates when
settings load and adding `nextTick` (settings are loaded, but ref
updates flush in a microtask. The immediate `whenever` runs before that
flush, so computeds may see stale/default values -- `nextTick` waits for
reactive microtasks to flush, so computeds will be correct. It's fine).

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8036-fix-version-mismatch-warning-appearing-in-Playwright-tests-despite-DisableWarnings-setti-2e86d73d36508132b4d1fd73ade76e63)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jan 14, 2026
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner January 14, 2026 02:29
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 14, 2026
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 01/14/2026, 02:31:13 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

🎭 Playwright Tests: ❌ Failed

Results: 500 passed, 1 failed, 2 flaky, 8 skipped (Total: 511)

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 490 / ❌ 1 / ⚠️ 1 / ⏭️ 8)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

@christian-byrne christian-byrne merged commit c77f0cb into cloud/1.37 Jan 14, 2026
32 of 33 checks passed
@christian-byrne christian-byrne deleted the backport-8036-to-cloud-1.37 branch January 14, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants