Conversation
Contributor
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughReplaces many CLAUDE.md files with single-line references to AGENTS.md and adds multiple AGENTS.md and docs/guidance/*.md documentation files across the repository. All changes are documentation-only; no runtime code or public API modifications. (≈27 words) Changes
Sequence Diagram(s)(omitted — changes are documentation-only and do not introduce new runtime control flow) Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Tests:
|
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/16/2026, 09:23:01 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.36 MB (baseline 3.36 MB) • ⚪ 0 BMain entry bundles and manifests
Graph Workspace — 1.14 MB (baseline 1.14 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Views & Navigation — 6.66 kB (baseline 6.66 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 372 kB (baseline 372 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
UI Components — 203 kB (baseline 203 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 9.34 MB (baseline 9.34 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 5.38 MB (baseline 5.38 MB) • ⚪ 0 BBundles that do not match a named category
|
Amp-Thread-ID: https://ampcode.com/threads/T-019bbe37-10be-70dc-ab60-71db7c9071f6 Co-authored-by: Amp <amp@ampcode.com>
DrJKL
force-pushed
the
agents
branch
2 times, most recently
from
a913df2 to
a608727
Compare
DrJKL
changed the title
dosubot
bot
added
the
size:M
christian-byrne
previously approved these changes
Jan 15, 2026
## Summary Consolidates AGENTS.md files and adds glob-based guidance per [Amp Manual patterns](https://ampcode.com/manual#granular-guidance). **Depends on:** #8052 (rename CLAUDE.md to AGENTS.md) ## Changes ### New Glob-Based Guidance (`docs/guidance/`) | File | Globs | Purpose | |------|-------|---------| | `vue-components.md` | `**/*.vue` | PrimeVue migrations, VueUse patterns | | `typescript.md` | `**/*.ts`, `**/*.tsx` | Type safety, API utilities | | `vitest.md` | `**/*.test.ts` | Unit test conventions | | `playwright.md` | `**/*.spec.ts` | E2E test conventions | | `storybook.md` | `**/*.stories.ts` | Story structure | ### Root AGENTS.md Updates - Added `@docs/guidance/*.md` reference - Added Development Workflow section (from CLAUDE.md) - Added Git Conventions section (from CLAUDE.md) - Added `pnpm storybook` command ### Redundancies Eliminated - PrimeVue migrations (was in 3 files → vue-components.md) - API utilities (was in 2 files → src/AGENTS.md only) - Vue 3 patterns (was in 3 files → root AGENTS.md only) - vue-i18n guidance (was in 3 files → root AGENTS.md only) - Build commands (was in 3 files → root AGENTS.md only) ## Results | Metric | Before | After | |--------|--------|-------| | Redundant topics | 10 | 0 | | Glob-based files | 0 | 5 | | Lines changed | - | -53 net | ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8053-refactor-consolidate-guidance-and-add-glob-based-docs-2e86d73d3650813f9547e2434eb7815e) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com>
dosubot
bot
added
size:XL
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 10
🤖 Fix all issues with AI agents
In @.storybook/CLAUDE.md:
- Around line 1-2: Remove the HTML comment that references Anthropic ("<!--
Though standards bloom in open fields so wide, Anthropic walks a path of lonely
pride. -->") from CLAUDE.md; locate the comment string in the file and delete it
(or replace it with neutral documentation text if context requires), ensuring no
mentions of Claude/Anthropic remain and the file contains only appropriate,
non-AI-referential content.
In `@browser_tests/AGENTS.md`:
- Around line 3-8: Add three critical best-practice bullets to the Best
Practices section: (1) Prohibit use of waitForTimeout and instead prefer Locator
actions and retrying assertions (e.g., use Locator.click()/fill() and
expect(...).toHaveText()/toBeVisible() with automatic retries) to avoid
flakiness; (2) Enforce browser test naming conventions (reference your repo's
naming rules: e.g., test files and test titles follow the project's spec) so
tests are discoverable and consistent; (3) Require use of test tags like `@mobile`
and `@2x` for configuration-aware selection to ensure correct viewport/device
runs; mention these as explicit guidelines under the Best Practices heading.
In `@browser_tests/CLAUDE.md`:
- Line 3: Add a top-level heading at the start of CLAUDE.md to satisfy
markdownlint; open the file and insert a descriptive H1 (for example "# CLAUDE"
or "# Agents — CLAUDE") as the very first line above the existing content (the
line containing "@AGENTS.md") so the document has proper markdown structure.
- Around line 1-2: Remove the HTML comment containing the Claude/AI metaphor
("<!-- In gardens where the agents freely play, One stubborn flower turns the
other way. -->") from the file content so no Claude/AI references remain; simply
delete that comment block and leave the rest of the document intact, then run
the tests/lint to ensure no formatting issues.
In `@docs/guidance/vitest.md`:
- Around line 18-22: Add a new "Test Structure" section to the vitest guidance
that states to prefer using test (not it) for defining test cases and to prefer
test.extend via importing test as baseTest from vitest instead of using loose
variables; reference the symbols `test`, `it`, `test.extend`, and `test as
baseTest` so readers know which conventions to follow and place this section
adjacent to the existing "Test Quality" or mocking guidance.
In `@src/components/AGENTS.md`:
- Around line 1-6: Add concise guidance to the Component Guidelines noting to
prefer Vue's defineModel for v-model bindings instead of manually pairing a prop
and an emit, and to always declare props and emits explicitly (using
defineProps/defineEmits or typed options) with clear names and types; reference
existing patterns (defineExpose for imperative APIs and emit/@event-name for
state changes) and show that defineModel should be used for two-way bindings
while props and emits definitions should be used to document and type all
inputs/outputs of a component.
In `@src/components/CLAUDE.md`:
- Around line 1-2: Remove the HTML comment that contains the lines "Play nice
with others," and "But Claude prefers its own file name instead" from CLAUDE.md;
simply delete that comment block so the file no longer references Claude/AI and
retains only relevant documentation text.
In `@src/lib/litegraph/AGENTS.md`:
- Around line 20-23: Add a blank line above the fenced code block that contains
the npm command; locate the fenced block shown as ```bash followed by pnpm
lint:fix and ensure there is a single empty line immediately before the opening
```bash, fix the fence so it reads a proper code block (```bash newline pnpm
lint:fix newline ```), and then run the linter/formatter (pnpm lint:fix) if
needed to validate Markdown formatting.
In `@src/lib/litegraph/CLAUDE.md`:
- Line 3: Add a top-level heading to the start of CLAUDE.md (above the existing
"@AGENTS.md" line) to satisfy markdownlint; insert a brief H1 like "Claude" or
"Agents — Claude" as the first line so the file has proper Markdown structure
and the reference remains below it.
- Around line 1-2: Remove the HTML comment at the top of CLAUDE.md that reads
"<!-- The graphs connect, the nodes align with grace, Yet Claude alone won't
join the commonplace. -->"; delete that comment entirely (or replace it with a
neutral, professional comment or nothing) so the file no longer mentions
Claude/Anthropic or contains snarky language.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (19)
.github/AGENTS.md.github/CLAUDE.md.storybook/AGENTS.md.storybook/CLAUDE.mdAGENTS.mdCLAUDE.mdbrowser_tests/AGENTS.mdbrowser_tests/CLAUDE.mddocs/guidance/playwright.mddocs/guidance/storybook.mddocs/guidance/typescript.mddocs/guidance/vitest.mddocs/guidance/vue-components.mdsrc/AGENTS.mdsrc/CLAUDE.mdsrc/components/AGENTS.mdsrc/components/CLAUDE.mdsrc/lib/litegraph/AGENTS.mdsrc/lib/litegraph/CLAUDE.md
🧰 Additional context used
🧠 Learnings (80)
📚 Learning: 2025-12-16T17:41:58.464Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-16T17:41:58.464Z
Learning: Never mention Claude/AI in commits
Applied to files:
browser_tests/CLAUDE.md.storybook/CLAUDE.mdsrc/components/CLAUDE.mdsrc/CLAUDE.mdsrc/lib/litegraph/CLAUDE.md.github/CLAUDE.mdCLAUDE.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to browser_tests/**/*.spec.ts : Follow Playwright best practices for E2E testing
Applied to files:
browser_tests/CLAUDE.mdbrowser_tests/AGENTS.mddocs/guidance/playwright.md
📚 Learning: 2025-11-24T19:47:22.909Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: browser_tests/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:22.909Z
Learning: Applies to browser_tests/**/*.{e2e,spec}.{ts,tsx,js,jsx} : Test user workflows in browser tests
Applied to files:
browser_tests/CLAUDE.mddocs/guidance/storybook.mdbrowser_tests/AGENTS.mddocs/guidance/playwright.md.storybook/AGENTS.md
📚 Learning: 2025-11-24T19:47:22.909Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: browser_tests/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:22.909Z
Learning: Applies to browser_tests/**/*.{e2e,spec}.{ts,tsx,js,jsx} : Follow naming conventions for browser tests
Applied to files:
browser_tests/CLAUDE.mddocs/guidance/storybook.mdbrowser_tests/AGENTS.mddocs/guidance/playwright.mddocs/guidance/typescript.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to browser_tests/**/*.spec.ts : E2E tests use Playwright and belong in `browser_tests/**/*.spec.ts`
Applied to files:
browser_tests/CLAUDE.mdbrowser_tests/AGENTS.mddocs/guidance/playwright.md
📚 Learning: 2025-11-24T19:47:22.909Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: browser_tests/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:22.909Z
Learning: Applies to browser_tests/**/*.{e2e,spec}.{ts,tsx,js,jsx} : Use Playwright fixtures for browser tests
Applied to files:
browser_tests/CLAUDE.mdbrowser_tests/AGENTS.mddocs/guidance/playwright.md
📚 Learning: 2025-11-24T19:47:22.909Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: browser_tests/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:22.909Z
Learning: Applies to browser_tests/**/*.{e2e,spec}.{ts,tsx,js,jsx} : Prefer specific selectors in browser tests
Applied to files:
browser_tests/CLAUDE.mdbrowser_tests/AGENTS.mddocs/guidance/playwright.md
📚 Learning: 2025-11-24T19:47:22.909Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: browser_tests/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:22.909Z
Learning: Applies to browser_tests/**/*.{e2e,spec}.{ts,tsx,js,jsx} : Check assets/ directory for test data when writing tests
Applied to files:
browser_tests/CLAUDE.mddocs/guidance/storybook.mdbrowser_tests/AGENTS.mddocs/guidance/playwright.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Write tests for all changes, especially bug fixes to catch future regressions
Applied to files:
browser_tests/CLAUDE.mdbrowser_tests/AGENTS.mddocs/guidance/playwright.mddocs/guidance/typescript.mddocs/guidance/vitest.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src|browser_tests)/**/*.+(test.ts|spec.ts) : Be parsimonious in testing - do not write redundant tests
Applied to files:
browser_tests/CLAUDE.mdsrc/lib/litegraph/AGENTS.mdsrc/lib/litegraph/CLAUDE.mddocs/guidance/playwright.mddocs/guidance/vitest.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to browser_tests/**/*.spec.ts : Use tags like `mobile`, `2x` in Playwright tests for configuration-aware test selection
Applied to files:
browser_tests/CLAUDE.mdbrowser_tests/AGENTS.mddocs/guidance/playwright.md
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/*.{vue,ts,tsx} : Follow Vue 3 composition API style guide
Applied to files:
.storybook/CLAUDE.mddocs/guidance/storybook.mdsrc/components/CLAUDE.mddocs/guidance/vue-components.mdsrc/CLAUDE.mdsrc/AGENTS.md.storybook/AGENTS.mddocs/guidance/typescript.md
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Follow Vue 3 style guide and naming conventions
Applied to files:
docs/guidance/storybook.mdsrc/components/CLAUDE.mddocs/guidance/vue-components.mdsrc/CLAUDE.mdsrc/AGENTS.md.storybook/AGENTS.mdAGENTS.md
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`
Applied to files:
docs/guidance/storybook.mddocs/guidance/vue-components.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Use Vue Test Utils for Component testing and follow best practices for making components easy to test
Applied to files:
docs/guidance/storybook.mdsrc/components/CLAUDE.mddocs/guidance/vue-components.md.storybook/AGENTS.mddocs/guidance/vitest.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Unit and component tests belong in `tests-ui/` or `src/**/*.test.ts` using Vitest
Applied to files:
docs/guidance/storybook.mddocs/guidance/vitest.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.vue : Use `<script setup lang="ts">` for component logic in Vue SFCs
Applied to files:
docs/guidance/storybook.mddocs/guidance/vue-components.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,tsx} : Minimize nesting (if statements, for loops, etc.)
Applied to files:
docs/guidance/storybook.mddocs/guidance/typescript.md
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{test,spec}.{ts,tsx} : Use provided test helpers `createTestSubgraph` and `createTestSubgraphNode` from `./fixtures/subgraphHelpers` for consistent subgraph test setup
Applied to files:
src/lib/litegraph/AGENTS.mdsrc/lib/litegraph/CLAUDE.md
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Run ESLint instead of manually figuring out whitespace fixes or other trivial style concerns using the `pnpm lint:fix` command
Applied to files:
src/lib/litegraph/AGENTS.mdsrc/lib/litegraph/CLAUDE.mdAGENTS.md
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{test,spec}.{ts,tsx} : When writing tests for subgraph-related code, always import from the barrel export at `@/lib/litegraph/src/litegraph` to avoid circular dependency issues
Applied to files:
src/lib/litegraph/AGENTS.mdsrc/lib/litegraph/CLAUDE.md
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{test,spec}.{js,ts,jsx,tsx} : When adding features, always write vitest unit tests using cursor rules in @.cursor
Applied to files:
src/lib/litegraph/AGENTS.mdsrc/lib/litegraph/CLAUDE.mddocs/guidance/vitest.md
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{ts,tsx} : Type assertions are an absolute last resort. In almost all cases, they are a crutch that leads to brittle code
Applied to files:
src/lib/litegraph/AGENTS.mdsrc/lib/litegraph/CLAUDE.md
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : When writing methods, prefer returning idiomatic JavaScript `undefined` over `null`
Applied to files:
src/lib/litegraph/AGENTS.mdsrc/lib/litegraph/CLAUDE.md
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Prefer single line `if` syntax over adding curly braces, when the statement has a very concise expression and concise, single line statement
Applied to files:
src/lib/litegraph/AGENTS.mdsrc/lib/litegraph/CLAUDE.md
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Take advantage of `TypedArray` `subarray` when appropriate
Applied to files:
src/lib/litegraph/AGENTS.mdsrc/lib/litegraph/CLAUDE.md
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Do not replace `&&=` or `||=` with `=` when there is no reason to do so. If you do find a reason to remove either `&&=` or `||=`, leave a comment explaining why the removal occurred
Applied to files:
src/lib/litegraph/AGENTS.mdsrc/lib/litegraph/CLAUDE.md
📚 Learning: 2025-11-24T19:47:22.909Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: browser_tests/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:22.909Z
Learning: Create browser tests as appropriate after code changes
Applied to files:
browser_tests/AGENTS.md
📚 Learning: 2025-11-24T19:47:22.909Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: browser_tests/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:22.909Z
Learning: Applies to browser_tests/**/*.{e2e,spec}.{ts,tsx,js,jsx} : Test across multiple viewports
Applied to files:
browser_tests/AGENTS.mddocs/guidance/playwright.md
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Prefer emit/event-name for state changes over other communication patterns
Applied to files:
src/components/AGENTS.mdsrc/components/CLAUDE.md
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Applied to files:
src/components/AGENTS.md
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Define proper props and emits definitions in Vue components
Applied to files:
src/components/AGENTS.mdsrc/components/CLAUDE.mddocs/guidance/vue-components.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.vue : Prefer `defineModel` over separately defining a prop and emit for v-model bindings
Applied to files:
src/components/AGENTS.md
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Implement proper props and emits definitions
Applied to files:
src/components/AGENTS.md
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Applied to files:
src/components/CLAUDE.mddocs/guidance/vue-components.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,vue} : Use `ref` for reactive state, `computed()` for derived values, and `watch`/`watchEffect` for side effects in Composition API
Applied to files:
src/components/CLAUDE.mddocs/guidance/vue-components.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.vue : Use Vue 3 Single File Components (SFCs) with Composition API only
Applied to files:
src/components/CLAUDE.mddocs/guidance/vue-components.md
📚 Learning: 2025-12-09T03:50:03.127Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:50:03.127Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, when avoiding PrimeVue components, prefer using the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) rather than plain HTML buttons. These components wrap PrimeVue with custom design system styling.
Applied to files:
src/components/CLAUDE.md.storybook/AGENTS.mdCLAUDE.md
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use ref/reactive for state management in Vue 3 Composition API
Applied to files:
src/components/CLAUDE.mddocs/guidance/vue-components.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.vue : Use TypeScript Vue 3.5 style default prop declaration with reactive props destructuring - avoid `withDefaults` or runtime props
Applied to files:
docs/guidance/vue-components.md
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Applied to files:
docs/guidance/vue-components.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,vue} : Leverage VueUse functions for performance-enhancing composables
Applied to files:
docs/guidance/vue-components.md
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Leverage VueUse functions for performance-enhancing styles
Applied to files:
docs/guidance/vue-components.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.vue : Avoid `<style>` blocks in Vue components - use Tailwind 4 styling instead
Applied to files:
docs/guidance/vue-components.md
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{services,composables}/**/*.{ts,tsx} : Use `api.apiURL()` for backend endpoints instead of constructing URLs directly
Applied to files:
src/CLAUDE.mdsrc/AGENTS.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Watch out for Code Smells and refactor to avoid them
Applied to files:
src/CLAUDE.mdsrc/AGENTS.mddocs/guidance/typescript.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Write code that is expressive and self-documenting - avoid unnecessary comments
Applied to files:
src/CLAUDE.mdsrc/AGENTS.md
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Implement proper error handling
Applied to files:
src/AGENTS.md
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Implement proper TypeScript types throughout the codebase
Applied to files:
src/AGENTS.mddocs/guidance/typescript.md
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Avoid using ts-expect-error; use proper TypeScript types instead
Applied to files:
src/AGENTS.mddocs/guidance/typescript.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to browser_tests/**/*.spec.ts : Do not use waitForTimeout in Playwright tests - use Locator actions and retrying assertions instead
Applied to files:
docs/guidance/playwright.md
📚 Learning: 2025-12-11T12:25:24.164Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:24.164Z
Learning: The project has CI automation that handles code formatting (pnpm format) automatically, so manual formatting suggestions should not be provided in code reviews for the Comfy-Org/ComfyUI_frontend repository.
Applied to files:
.github/CLAUDE.mdAGENTS.md
📚 Learning: 2025-12-05T06:11:09.383Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7177
File: src/platform/assets/components/UploadModelFooter.vue:72-78
Timestamp: 2025-12-05T06:11:09.383Z
Learning: For the ComfyUI_frontend repository, avoid suggesting comments that would be redundant when the code is already self-explanatory through descriptive naming (e.g., filenames, prop names, aria-labels). The project prefers clean code without unnecessary documentation comments.
Applied to files:
.github/CLAUDE.md
📚 Learning: 2025-12-16T17:41:58.464Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-16T17:41:58.464Z
Learning: Prerequisites for repository setup: Node.js >= 24, Git repository, available ports for dev server and storybook
Applied to files:
.storybook/AGENTS.mdAGENTS.mdCLAUDE.md
📚 Learning: 2025-12-22T21:36:46.909Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: tests-ui/tests/platform/cloud/subscription/components/SubscriptionPanel.test.ts:189-194
Timestamp: 2025-12-22T21:36:46.909Z
Learning: In the Comfy-Org/ComfyUI_frontend repository test files: Do not stub primitive UI components or customized primitive components (e.g., Button). Instead, import and register the real components in test setup. This ensures tests accurately reflect production behavior and component API usage.
Applied to files:
.storybook/AGENTS.mdCLAUDE.md
📚 Learning: 2025-11-24T19:48:09.318Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursor/rules/unit-test.mdc:0-0
Timestamp: 2025-11-24T19:48:09.318Z
Learning: Applies to test/**/*.{test,spec}.{js,ts,jsx,tsx} : Mocks should be cleanly written and easy to understand, with reusable mocks where possible
Applied to files:
.storybook/AGENTS.md
📚 Learning: 2025-12-16T17:30:29.719Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7559
File: .storybook/preview.ts:61-61
Timestamp: 2025-12-16T17:30:29.719Z
Learning: In .storybook/preview.ts for the Comfy-Org/ComfyUI_frontend repository, using `document.body.classList.add('[&_*]:!font-inter')` is the correct approach for applying the Inter font to all Storybook story elements. The simpler `font-inter` class alone does not work in this context. This runtime arbitrary variant pattern is valid and should not be flagged as an issue.
Applied to files:
.storybook/AGENTS.md
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.ts : Use TypeScript for type safety
Applied to files:
docs/guidance/typescript.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{js,jsx} : Use TypeScript exclusively - no new JavaScript files
Applied to files:
docs/guidance/typescript.md
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/stores/**/*.{ts,tsx} : Use TypeScript for type safety in state management stores
Applied to files:
docs/guidance/typescript.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Use separate `import type` statements instead of inline `type` in mixed imports
Applied to files:
docs/guidance/typescript.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Never use `as any` type assertions - fix the underlying type issue
Applied to files:
docs/guidance/typescript.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Never use `any` type - use proper TypeScript types
Applied to files:
docs/guidance/typescript.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, 80-character width
Applied to files:
docs/guidance/typescript.md
📚 Learning: 2025-11-24T19:48:09.318Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursor/rules/unit-test.mdc:0-0
Timestamp: 2025-11-24T19:48:09.318Z
Learning: Applies to test/**/*.{test,spec}.{js,ts,jsx,tsx} : Use `vitest` for unit testing in this project
Applied to files:
docs/guidance/vitest.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Leverage Vitest's utilities for mocking where possible
Applied to files:
docs/guidance/vitest.md
📚 Learning: 2025-11-24T19:48:09.318Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursor/rules/unit-test.mdc:0-0
Timestamp: 2025-11-24T19:48:09.318Z
Learning: Applies to test/**/*.{test,spec}.{js,ts,jsx,tsx} : Use `test` instead of `it` for defining test cases in vitest
Applied to files:
docs/guidance/vitest.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Keep module mocks contained - do not use global mutable state within test files; use `vi.hoisted()` if necessary
Applied to files:
docs/guidance/vitest.md
📚 Learning: 2025-11-24T19:48:09.318Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .cursor/rules/unit-test.mdc:0-0
Timestamp: 2025-11-24T19:48:09.318Z
Learning: Applies to test/**/*.{test,spec}.{js,ts,jsx,tsx} : Prefer the use of `test.extend` over loose variables; import `test as baseTest` from `vitest`
Applied to files:
docs/guidance/vitest.md
📚 Learning: 2025-12-30T01:31:11.188Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7797
File: tests-ui/tests/lib/litegraph/src/widgets/ComboWidget.test.ts:648-648
Timestamp: 2025-12-30T01:31:11.188Z
Learning: In Vitest v4, when mocking functions that may be called as constructors (with `new` keyword), the mock implementation must use `function()` or `class` syntax instead of arrow functions. Arrow functions will cause `<anonymous> is not a constructor` errors. This is a breaking change from Vitest v3 where mocks used `mock.apply`.
Applied to files:
docs/guidance/vitest.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Aim for behavioral coverage of critical and new features in unit tests
Applied to files:
docs/guidance/vitest.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to +(tests-ui|src)/**/*.test.ts : Do not write tests dependent on non-behavioral features like utility classes or styles
Applied to files:
docs/guidance/vitest.md
📚 Learning: 2025-12-16T17:41:58.464Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-16T17:41:58.464Z
Learning: Check README updates during development workflow
Applied to files:
AGENTS.mdCLAUDE.md
📚 Learning: 2025-12-16T17:41:58.464Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-16T17:41:58.464Z
Learning: Consider updates to docs.comfy.org during development workflow
Applied to files:
AGENTS.md
📚 Learning: 2025-12-16T17:41:58.464Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-16T17:41:58.464Z
Learning: Run tests, typecheck, lint, and format checks during development workflow
Applied to files:
AGENTS.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Run quality gates before PR: `pnpm lint`, `pnpm typecheck`, `pnpm knip`, and ensure relevant tests pass
Applied to files:
AGENTS.md
📚 Learning: 2026-01-10T00:24:17.695Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Sort and group imports by plugin, run `pnpm format` before committing
Applied to files:
AGENTS.md
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Be sure to typecheck when you're done making a series of code changes using `pnpm typecheck`
Applied to files:
AGENTS.md
📚 Learning: 2025-12-18T21:15:54.349Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:54.349Z
Learning: For Vue components in Comfy-Org/ComfyUI_frontend: Do not suggest adding aria-label to buttons that already have visible text content (e.g., <span> elements with labels). The visible text automatically provides the accessible name. aria-label should only be used for elements without visible labels, such as icon-only buttons.
Applied to files:
CLAUDE.md
📚 Learning: 2025-12-16T17:41:58.464Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-16T17:41:58.464Z
Learning: Run `/setup_repo` Claude command for first-time repository setup to bootstrap monorepo dependencies, builds, tests, and dev server verification
Applied to files:
CLAUDE.md
🪛 LanguageTool
src/lib/litegraph/AGENTS.md
[grammar] ~11-~11: Use a hyphen to join words.
Context: ...formance ## Code Style - Prefer single line if syntax for concise expressions...
(QB_NEW_EN_HYPHEN)
docs/guidance/typescript.md
[style] ~14-~14: Consider using a different verb for a more formal wording.
Context: ...ittle code - Avoid @ts-expect-error - fix the underlying issue instead ## Utilit...
(FIX_RESOLVE)
🪛 markdownlint-cli2 (0.18.1)
browser_tests/CLAUDE.md
3-3: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
src/lib/litegraph/AGENTS.md
21-21: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
src/CLAUDE.md
3-3: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
src/lib/litegraph/CLAUDE.md
3-3: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: setup
- GitHub Check: test
- GitHub Check: collect
- GitHub Check: lint-and-format
🔇 Additional comments (15)
.storybook/AGENTS.md (1)
1-28: LGTM! Well-structured Storybook guidance.This documentation provides comprehensive and well-organized guidance for Storybook development, including:
- Clear command references
- Story structure conventions with proper cross-references
- Mock data expectations
- Available context for story authors
- Practical troubleshooting tips
The separation of concerns (referencing
docs/guidance/storybook.mdfor patterns) is a good practice.docs/guidance/playwright.md (1)
1-33: LGTM! Comprehensive Playwright guidance.This documentation effectively covers E2E testing conventions with:
- Proper glob-based scoping using YAML frontmatter
- Critical best practices including the important "do NOT use
waitForTimeout" warning- Test tag documentation for configuration-aware selection
- Clear command references with examples
- Good cross-references to additional documentation
The content aligns well with the learnings and Playwright best practices.
docs/guidance/vitest.md (1)
10-16: Strong test quality guidance.The Test Quality section provides excellent guidance on avoiding common anti-patterns:
- No change detector tests
- No tests dependent on non-behavioral features
- No tests that just test mocks
- Be parsimonious
This helps ensure a maintainable and valuable test suite.
Based on learnings.
AGENTS.md (3)
3-4: LGTM! Clear reference to glob-based guidance.The addition of the reference to glob-based guidance files aligns well with the PR objectives to consolidate documentation and reduce redundancy.
51-52: LGTM! Useful Storybook command addition.The addition of the
pnpm storybookcommand is helpful and aligns with the new Storybook guidance documentation being added in this PR.
53-65: LGTM! Clear and actionable workflow guidance.The new Development Workflow and Git Conventions sections provide clear, step-by-step guidance that aligns with the project's best practices and retrieved learnings.
src/lib/litegraph/AGENTS.md (1)
1-49: LGTM! Clear and comprehensive Litegraph guidelines.The file provides excellent guidance for Litegraph code, with particularly strong emphasis on the critical circular dependency issue. The examples are clear and actionable.
CLAUDE.md (1)
1-1: LGTM! Appropriate reference to AGENTS.md.The simplified reference is consistent with the PR objectives to consolidate guidance. The past review comments confirm that additional content will be added in the follow-up PR
#8053.docs/guidance/storybook.md (1)
1-55: LGTM! Excellent Storybook guidance with glob-based scoping.This file provides clear, practical guidance for writing Storybook stories. The YAML front matter with glob patterns is a great approach for auto-loading file-type-specific guidance. The story structure example is complete and follows best practices, and the required variants section ensures consistent story coverage.
src/AGENTS.md (1)
1-40: LGTM! Well-structured source code guidelines.This file effectively consolidates key source code guidelines with clear examples. The API Calls section's correct vs. incorrect examples are particularly helpful, and all guidance aligns with the project's established best practices and retrieved learnings.
docs/guidance/vue-components.md (1)
1-48: LGTM! Well-structured Vue component guidance.The documentation comprehensively covers Vue 3 Composition API conventions, component communication patterns, and VueUse composables. The guidance aligns perfectly with project standards and retrieved learnings.
.github/CLAUDE.md (1)
1-3: LGTM! Clean redirect to consolidated guidance.The minimal placeholder approach effectively redirects to the new AGENTS.md location while maintaining backward compatibility for tools that look for CLAUDE.md files.
src/CLAUDE.md (1)
1-3: The target src/AGENTS.md file exists. The redirect approach in src/CLAUDE.md is valid..github/AGENTS.md (1)
1-14: The referenced file.claude/commands/comprehensive-pr-review.mdexists in the repository, so the documentation cross-reference is valid.docs/guidance/typescript.md (1)
1-36: LGTM! Comprehensive TypeScript guidance.The documentation covers essential TypeScript conventions and aligns well with project standards. The API utilities section with code examples is particularly helpful for developers. The examples correctly reference the existing
api.apiURL()andapi.fileURL()helper functions defined insrc/scripts/api.ts, which are widely used throughout the codebase.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@browser_tests/AGENTS.md`:
- Around line 3-11: Update the "Prefer specific selectors" bullet to explicitly
recommend accessibility-focused selectors: list Playwright-style examples such
as getByRole, getByLabelText / getByLabel, getByText, accessible name and
aria-label, and note to prefer these over data-testid except when absolutely
necessary; edit the existing "Prefer specific selectors" line to include these
examples and a short one-line note to reserve data-testid for when no accessible
selector exists.
christian-byrne
previously approved these changes
Jan 16, 2026
src/AGENTS.md
Outdated
Comment on lines
5
to
15
| - Use `api.apiURL()` for backend endpoints | ||
| - Use `api.fileURL()` for static files | ||
|
|
||
| ```typescript | ||
| // ✅ Correct | ||
| const response = await api.get(api.apiURL('/prompt')) | ||
| const template = await fetch(api.fileURL('/templates/default.json')) | ||
|
|
||
| // ❌ Wrong - direct URL construction | ||
| const response = await fetch('/api/prompt') | ||
| ``` |
Contributor
There was a problem hiding this comment.
This is duplicated in docs/guidance/typescript.md. Not sure if necessary.
Contributor
Author
There was a problem hiding this comment.
Not sure how valuable the API Utilities suggestion is.
Contributor
Author
There was a problem hiding this comment.
(Not your suggestion, the suggestion that was in the md file to begin with)
Contributor
There was a problem hiding this comment.
I added this because in the past it would always just use fetch, which will break on different distributions or when auth is required.
|
|
||
| ## Development Workflow | ||
|
|
||
| 1. **First-time setup**: Run `/setup_repo` Claude command |
Contributor
There was a problem hiding this comment.
Should we remove this if we are no longer suggesting it or planning to maintain it? (setup_repo command in .claude)?
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure rename of CLAUDE.md files to AGENTS.md (no content changes).
Changes
.github/CLAUDE.md.github/AGENTS.md.storybook/CLAUDE.md.storybook/AGENTS.mdbrowser_tests/CLAUDE.mdbrowser_tests/AGENTS.mdsrc/CLAUDE.mdsrc/AGENTS.mdsrc/components/CLAUDE.mdsrc/components/AGENTS.mdsrc/lib/litegraph/CLAUDE.mdsrc/lib/litegraph/AGENTS.mdRoot
CLAUDE.mddeleted (content will be merged intoAGENTS.mdin follow-up PR).Follow-up
A second PR will add glob-based guidance files and consolidate redundancies.