Skip to content

refactor: consolidate guidance and add glob-based docs#8053

Merged
christian-byrne merged 5 commits intoagentsfrom
agents-consolidate
Jan 16, 2026
Merged

refactor: consolidate guidance and add glob-based docs#8053
christian-byrne merged 5 commits intoagentsfrom
agents-consolidate

Conversation

@DrJKL
Copy link
Contributor

@DrJKL DrJKL commented Jan 14, 2026

Summary

Consolidates AGENTS.md files and adds glob-based guidance per Amp Manual patterns.

Depends on: #8052 (rename CLAUDE.md to AGENTS.md)

Changes

New Glob-Based Guidance (docs/guidance/)

File Globs Purpose
vue-components.md **/*.vue PrimeVue migrations, VueUse patterns
typescript.md **/*.ts, **/*.tsx Type safety, API utilities
vitest.md **/*.test.ts Unit test conventions
playwright.md **/*.spec.ts E2E test conventions
storybook.md **/*.stories.ts Story structure

Root AGENTS.md Updates

  • Added @docs/guidance/*.md reference
  • Added Development Workflow section (from CLAUDE.md)
  • Added Git Conventions section (from CLAUDE.md)
  • Added pnpm storybook command

Redundancies Eliminated

  • PrimeVue migrations (was in 3 files → vue-components.md)
  • API utilities (was in 2 files → src/AGENTS.md only)
  • Vue 3 patterns (was in 3 files → root AGENTS.md only)
  • vue-i18n guidance (was in 3 files → root AGENTS.md only)
  • Build commands (was in 3 files → root AGENTS.md only)

Results

Metric Before After
Redundant topics 10 0
Glob-based files 0 5
Lines changed - -53 net

┆Issue is synchronized with this Notion page by Unito

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 14, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

🎭 Playwright Tests: ⚠️ Passed with flaky tests

Results: 503 passed, 0 failed, 2 flaky, 8 skipped (Total: 513)

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 493 / ❌ 0 / ⚠️ 1 / ⏭️ 8)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 01/15/2026, 10:13:13 PM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@viva-jinyi viva-jinyi removed their assignment Jan 15, 2026
@DrJKL DrJKL assigned viva-jinyi and christian-byrne and unassigned DrJKL Jan 15, 2026
@DrJKL DrJKL marked this pull request as ready for review January 15, 2026 02:58
@DrJKL DrJKL requested a review from a team as a code owner January 15, 2026 02:58
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 15, 2026
Copy link
Member

@viva-jinyi viva-jinyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit hard to review when files are moved and changed in same PR. I can't be 100% sure I know what was just moved vs. what content was actually changed as well.

@DrJKL
Copy link
Contributor Author

DrJKL commented Jan 15, 2026

It's a bit hard to review when files are moved and changed in same PR. I can't be 100% sure I know what was just moved vs. what content was actually changed as well.

That's why the move happened in the parent PR. The other way it looks like the content from the old files was just deleted and the new files created without history.

Removed deprecated PrimeVue components and their replacements from the documentation.
@DrJKL DrJKL removed their assignment Jan 16, 2026
@christian-byrne christian-byrne merged commit 2a34282 into agents Jan 16, 2026
25 checks passed
@christian-byrne christian-byrne deleted the agents-consolidate branch January 16, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants