Conversation
dosubot
bot
added
the
size:L
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/28/2026, 01:58:57 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Tests: ✅ PassedResults: 507 passed, 0 failed, 0 flaky, 8 skipped (Total: 515) 📊 Browser Reports
|
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughLarge-scale formatting and normalization pass across configuration files, documentation, test fixtures, and localization files. Primary changes include quote style standardization in YAML workflows, JSON array compression, documentation expansions, and empty object literal normalization across locale files. Changes
Possibly related PRs
Suggested reviewers
Comment |
DrJKL
force-pushed
the
drjkl/oxfmt-pass
branch
from
90b8f8e to
22a557f
Compare
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 23.6 kB (baseline 23.6 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 960 kB (baseline 960 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 470 kB (baseline 470 kB) • 🟢 -8 BConfiguration panels, inspectors, and settings screens
Status: 12 added / 12 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.9 kB (baseline 2.9 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 33.7 kB (baseline 33.7 kB) • ⚪ 0 BReusable component library chunks
Status: 4 added / 4 removed Data & Services — 2.7 MB (baseline 2.7 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 9 added / 9 removed Utilities & Hooks — 25.5 kB (baseline 25.5 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 7 added / 7 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.04 MB (baseline 7.04 MB) • 🟢 -200 BBundles that do not match a named category
Status: 37 added / 37 removed |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 11
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
docs/guidance/storybook.md (1)
47-48: Consider scope: Content additions in a formatting PR.While these are valuable additions (Error and Empty are standard story variants), they represent content changes rather than pure formatting. The PR is described as a "formatting pass," but these lines add new documentation content.
This is a minor observation—the additions are beneficial and align with Storybook best practices. However, for future PRs, consider separating content additions from pure formatting changes to maintain clear commit history.
.claude/commands/create-frontend-release.md (1)
774-790: Standardize “pre-release/prerelease” wording.Lines 774 and 790 mix “pre-release” and “prerelease.” Please pick one and use it consistently across the document.
🛠️ Suggested consistency fix
-### Scenario 4: Pre-release Testing +### Scenario 4: Prerelease Testing @@ -- For pre-release versions (e.g., 1.24.0-rc.1), the next stable release should be the same version without the suffix (1.24.0) +- For prerelease versions (e.g., 1.24.0-rc.1), the next stable release should be the same version without the suffix (1.24.0)
🤖 Fix all issues with AI agents
In @.claude/commands/create-frontend-release.md:
- Around line 199-229: Multiple fenced code blocks (e.g., the block containing
the <task>...</task> example and other fence regions) are missing language
specifiers and surrounding blank lines; update each fenced block by adding an
explicit language tag (e.g., change ``` to ```text or ```bash as appropriate)
and ensure there's a blank line before and after every fenced code block to
satisfy MD040 and MD031; search for all occurrences of ``` and fix the blocks
around snippets like the <task> example and the other reported regions
(previously at the example fences) so every code fence has a language and is
separated from adjacent content by blank lines.
In @.github/workflows/ci-tests-storybook.yaml:
- Line 5: The inline comments in the GitHub Actions workflow under the
workflow_dispatch key and other places (the commented lines around where
workflow definitions exist) have too few spaces before the comment marker;
update those inline comments to ensure there are at least two spaces before the
"#" so yaml-lint no longer flags "too few spaces before comment". Locate the
occurrences around the workflow_dispatch declaration and the other mentioned
comment blocks and adjust spacing so comments are aligned (e.g.,
"workflow_dispatch: # Allow manual triggering").
In `@browser_tests/README.md`:
- Around line 19-20: The markdown contains malformed emphasis/escaping around
the devtools name (e.g., "ComfyUI*devtools" and "\_ComfyUI_devtools"); update
the README so the tool name is rendered correctly by using inline code or plain
text (for example: `ComfyUI_devtools` or ComfyUI devtools) and remove stray
asterisks/backslashes; ensure the occurrences near "tools/devtools/" and
"custom_nodes" use the consistent corrected name.
In `@docs/extensions/core.md`:
- Around line 100-115: The fenced JavaScript code block around the example using
app.registerExtension is missing blank lines before and after it which trips
markdownlint; fix by inserting a single blank line immediately before the
opening ```javascript fence and a single blank line immediately after the
closing ``` fence so the block is properly separated from surrounding text
(locate the example that contains app.registerExtension and the hooks init and
beforeRegisterNodeDef to apply this change).
In `@docs/FEATURE_FLAGS.md`:
- Around line 220-233: The ordered lists violate markdownlint MD029; replace
increasing numbers with "1." for each list item in the affected sections (the
"Direct API access:" list shown in the diff and the other occurrences around the
"Also applies to" ranges) so every ordered item starts with "1."; locate the
list headers/labels (e.g., "Direct API access:" and the following list entries
and similar sections referenced) and update their numeric prefixes to use "1."
consistently.
In `@packages/design-system/src/css/style.css`:
- Around line 1410-1417: Replace the invalid CSS property name backgroundcolor
with the correct kebab-case background-color in the style block that contains
position: absolute; z-index: 8889; pointer-events: none; etc., (the rule that
currently includes outline: 1px dashed black and box-shadow: 0 0 0 1px white) so
the background rule is applied correctly by browsers.
In `@packages/design-system/src/icons/README.md`:
- Around line 103-107: The example icon element has duplicate class attributes
(e.g., class="icon-[lucide--info]" and later class="cursor-pointer") so the
second overwrites the first; merge them into a single class attribute on the <i>
element combining both values and keep the v-tooltip attribute intact; update
the same pattern wherever present in this README (the tooltip examples and other
occurrences of the <i> icon examples) so each icon element uses one class
attribute that contains all classes (e.g., "icon-[lucide--info] cursor-pointer")
to preserve both icon styling and cursor behavior.
In `@src/lib/litegraph/CONTRIBUTING.md`:
- Around line 5-9: Change the heading "### Do not commit files from build
folder" to an H2 (prepend with "##") so heading levels don't jump from H1 to H3,
and wrap the bare URL
"https://github.com/jagenjo/litegraph.js/pull/155#issuecomment-656602861" in
angle brackets (<...>) to satisfy markdown linting; update the line containing
that URL and the heading text accordingly in CONTRIBUTING.md.
In `@src/lib/litegraph/README.md`:
- Line 5: Replace the typo in the README sentence "Some APIs may by unchanged,
however it is largely incompatible with the original." changing "by" to "be",
and add the missing period after "etc.)" wherever that fragment occurs so the
sentence ends with proper punctuation; update the exact sentence that begins "It
is a fork of the original `litegraph.js`..." and the note containing "etc.)" to
reflect these corrections.
- Around line 9-11: The three list items contain bare URLs that violate
markdownlint MD034; update each one by converting the plain URL into a markdown
link (for example replace "https://github.com/Comfy-Org/litegraph.js/pull/1"
with "[Comfy-Org/litegraph.js PR
`#1`](https://github.com/Comfy-Org/litegraph.js/pull/1)"), doing the same for the
PR `#3` and PR `#7` links in the README list so each URL is wrapped with descriptive
link text.
- Around line 153-158: Standardize the spelling in the README section titled
"### Pre-release" to use a single "prerelease" form: rename the header "###
Pre-release" to "### Prerelease" (or keep capitalization consistent with other
headings), and replace all occurrences of "pre-release", "Pre-release ID
(suffix)" and "pre-release suffix" in that paragraph with "prerelease",
"Prerelease ID (suffix)" and "prerelease suffix" respectively so the section
uses one consistent spelling.
|
|
||
| on: | ||
| workflow_dispatch: # Allow manual triggering | ||
| workflow_dispatch: # Allow manual triggering |
Contributor
There was a problem hiding this comment.
Fix yaml-lint inline comment spacing (Lines 5, 91, 113-115).
yaml-lint flags “too few spaces before comment”; align inline comments to avoid CI noise/failures.
✅ Proposed fix
- workflow_dispatch: # Allow manual triggering
+ workflow_dispatch: # Allow manual triggering
@@
- fetch-depth: 0 # Required for Chromatic baseline
+ fetch-depth: 0 # Required for Chromatic baseline
@@
- autoAcceptChanges: 'main' # Auto-accept changes on main branch
- exitOnceUploaded: true # Don't wait for UI tests to complete
- onlyChanged: true # Only capture changed stories
+ autoAcceptChanges: 'main' # Auto-accept changes on main branch
+ exitOnceUploaded: true # Don't wait for UI tests to complete
+ onlyChanged: true # Only capture changed storiesAlso applies to: 91-91, 113-115
🧰 Tools
🪛 GitHub Check: yaml-lint
[warning] 5-5:
5:22 [comments] too few spaces before comment: expected 2
🤖 Prompt for AI Agents
In @.github/workflows/ci-tests-storybook.yaml at line 5, The inline comments in
the GitHub Actions workflow under the workflow_dispatch key and other places
(the commented lines around where workflow definitions exist) have too few
spaces before the comment marker; update those inline comments to ensure there
are at least two spaces before the "#" so yaml-lint no longer flags "too few
spaces before comment". Locate the occurrences around the workflow_dispatch
declaration and the other mentioned comment blocks and adjust spacing so
comments are aligned (e.g., "workflow_dispatch: # Allow manual triggering").
Comment on lines
100
to
115
| ```javascript | ||
| app.registerExtension({ | ||
| name: "MyExtension", | ||
| name: 'MyExtension', | ||
|
|
||
| // Hook implementations | ||
| async init() { | ||
| // Implementation | ||
| }, | ||
|
|
||
| async beforeRegisterNodeDef(nodeType, nodeData, app) { | ||
| // Implementation | ||
| } | ||
|
|
||
| // Other hooks as needed | ||
| }); | ||
| }) | ||
| ``` |
Contributor
There was a problem hiding this comment.
Missing blank lines around fenced code block.
Static analysis (markdownlint) flags that fenced code blocks should be surrounded by blank lines. The code block starting at line 100 appears to be missing proper blank line separation.
📝 Suggested fix
Extensions are registered using the `app.registerExtension()` method:
+
```javascript
app.registerExtension({
name: 'MyExtension',
// Hook implementations
async init() {
// Implementation
},
async beforeRegisterNodeDef(nodeType, nodeData, app) {
// Implementation
}
// Other hooks as needed
})Extension Hooks
</details>
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
```suggestion
Extensions are registered using the `app.registerExtension()` method:
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
103-103: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
106-106: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
🤖 Prompt for AI Agents
In `@docs/extensions/core.md` around lines 100 - 115, The fenced JavaScript code
block around the example using app.registerExtension is missing blank lines
before and after it which trips markdownlint; fix by inserting a single blank
line immediately before the opening ```javascript fence and a single blank line
immediately after the closing ``` fence so the block is properly separated from
surrounding text (locate the example that contains app.registerExtension and the
hooks init and beforeRegisterNodeDef to apply this change).
Comment on lines
220
to
+233
| 1. **Direct API access:** | ||
|
|
||
| ```typescript | ||
| // Check boolean feature | ||
| if (api.serverSupportsFeature('supports_preview_metadata')) { | ||
| // Feature is supported | ||
| // Feature is supported | ||
| } | ||
|
|
||
| // Get feature value with default | ||
| const maxSize = api.getServerFeature('max_upload_size', 100 * 1024 * 1024) | ||
| ``` | ||
|
|
||
| 2. **Using the composable (recommended for reactive components):** | ||
|
|
Contributor
There was a problem hiding this comment.
Fix ordered list numbering to satisfy MD029.
markdownlint expects ordered lists to use 1. for each item in these sections.
✏️ Proposed fix
-2. **Using the composable (recommended for reactive components):**
+1. **Using the composable (recommended for reactive components):**
-3. **Reactive usage in templates:**
+1. **Reactive usage in templates:**
-2. **For extension features**, update the composable to add convenience accessors:
+1. **For extension features**, update the composable to add convenience accessors:Also applies to: 248-250, 318-320
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
232-232: Ordered list item prefix
Expected: 1; Actual: 2; Style: 1/1/1
(MD029, ol-prefix)
🤖 Prompt for AI Agents
In `@docs/FEATURE_FLAGS.md` around lines 220 - 233, The ordered lists violate
markdownlint MD029; replace increasing numbers with "1." for each list item in
the affected sections (the "Direct API access:" list shown in the diff and the
other occurrences around the "Also applies to" ranges) so every ordered item
starts with "1."; locate the list headers/labels (e.g., "Direct API access:" and
the following list entries and similar sections referenced) and update their
numeric prefixes to use "1." consistently.
Comment on lines
+103
to
107
| <i | ||
| class="icon-[lucide--info]" | ||
| v-tooltip="'Click for more information'" | ||
| class="cursor-pointer" | ||
| /> |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Check if the file exists and read lines around 103-107
wc -l packages/design-system/src/icons/README.mdRepository: Comfy-Org/ComfyUI_frontend
Length of output: 116
🏁 Script executed:
# Read the specific section mentioned (lines 100-110 to get context)
sed -n '100,110p' packages/design-system/src/icons/README.mdRepository: Comfy-Org/ComfyUI_frontend
Length of output: 221
🏁 Script executed:
# Search for all duplicate class attributes in this file
rg -n 'class="[^"]*".*class="' packages/design-system/src/icons/README.mdRepository: Comfy-Org/ComfyUI_frontend
Length of output: 601
Merge duplicate class attributes in the tooltip example.
Lines 104–106 declare class twice; the second overwrites the first, dropping the icon styling. Merge into one attribute.
Note: This pattern appears throughout the file (lines 31, 44, 179–192). Consider fixing all instances for consistency.
Suggested fix
<i
- class="icon-[lucide--info]"
+ class="icon-[lucide--info] cursor-pointer"
v-tooltip="'Click for more information'"
- class="cursor-pointer"
/>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <i | |
| class="icon-[lucide--info]" | |
| v-tooltip="'Click for more information'" | |
| class="cursor-pointer" | |
| /> | |
| <i | |
| class="icon-[lucide--info] cursor-pointer" | |
| v-tooltip="'Click for more information'" | |
| /> |
🤖 Prompt for AI Agents
In `@packages/design-system/src/icons/README.md` around lines 103 - 107, The
example icon element has duplicate class attributes (e.g.,
class="icon-[lucide--info]" and later class="cursor-pointer") so the second
overwrites the first; merge them into a single class attribute on the <i>
element combining both values and keep the v-tooltip attribute intact; update
the same pattern wherever present in this README (the tooltip examples and other
occurrences of the <i> icon examples) so each icon element uses one class
attribute that contains all classes (e.g., "icon-[lucide--info] cursor-pointer")
to preserve both icon styling and cursor behavior.
Comment on lines
5
to
+9
| ### Do not commit files from build folder | ||
|
|
||
| > I usually have horrible merge conflicts when I upload the build version that take me too much time to solve, but I want to keep the build version in the repo, so I guess it would be better if only one of us does the built, which would be me. | ||
| > https://github.com/jagenjo/litegraph.js/pull/155#issuecomment-656602861 | ||
| Those files will be updated by owner. | ||
|
|
||
|
|
||
| > Those files will be updated by owner. |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Formatting changes look fine.
The blank lines and blockquote conversion improve visual separation. Note that static analysis flags two pre-existing issues in this file:
- Line 5: Heading level jumps from
h1toh3(skippingh2) - Line 8: Bare URL should be wrapped in angle brackets
These are optional fixes if you'd like to address them in this formatting pass:
📝 Optional: Address markdown lint warnings
# Contribution Rules
There are some simple rules that everyone should follow:
-### Do not commit files from build folder
+## Do not commit files from build folder
-> I usually have horrible merge conflicts when I upload the build version that take me too much time to solve, but I want to keep the build version in the repo, so I guess it would be better if only one of us does the built, which would be me.
-> https://github.com/jagenjo/litegraph.js/pull/155#issuecomment-656602861
+> I usually have horrible merge conflicts when I upload the build version that take me too much time to solve, but I want to keep the build version in the repo, so I guess it would be better if only one of us does the built, which would be me.
+> <https://github.com/jagenjo/litegraph.js/pull/155#issuecomment-656602861>
> Those files will be updated by owner.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| ### Do not commit files from build folder | |
| > I usually have horrible merge conflicts when I upload the build version that take me too much time to solve, but I want to keep the build version in the repo, so I guess it would be better if only one of us does the built, which would be me. | |
| > https://github.com/jagenjo/litegraph.js/pull/155#issuecomment-656602861 | |
| Those files will be updated by owner. | |
| > Those files will be updated by owner. | |
| ## Do not commit files from build folder | |
| > I usually have horrible merge conflicts when I upload the build version that take me too much time to solve, but I want to keep the build version in the repo, so I guess it would be better if only one of us does the built, which would be me. | |
| > <https://github.com/jagenjo/litegraph.js/pull/155#issuecomment-656602861> | |
| > Those files will be updated by owner. |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
5-5: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3
(MD001, heading-increment)
8-8: Bare URL used
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
In `@src/lib/litegraph/CONTRIBUTING.md` around lines 5 - 9, Change the heading
"### Do not commit files from build folder" to an H2 (prepend with "##") so
heading levels don't jump from H1 to H3, and wrap the bare URL
"https://github.com/jagenjo/litegraph.js/pull/155#issuecomment-656602861" in
angle brackets (<...>) to satisfy markdown linting; update the line containing
that URL and the heading text accordingly in CONTRIBUTING.md.
|
|
||
| This is the litegraph version used in [ComfyUI_frontend](https://github.com/Comfy-Org/ComfyUI_frontend). | ||
|
|
||
| It is a fork of the original `litegraph.js`. Some APIs may by unchanged, however it is largely incompatible with the original. |
Contributor
There was a problem hiding this comment.
Fix typos in the overview and server-side note.
There’s a simple typo (“by” → “be”) and a missing sentence period after “etc.)”.
💡 Proposed fix
-It is a fork of the original `litegraph.js`. Some APIs may by unchanged, however it is largely incompatible with the original.
+It is a fork of the original `litegraph.js`. Some APIs may be unchanged; however, it is largely incompatible with the original.
@@
-It also works server-side using NodeJS although some nodes do not work in server (audio, graphics, input, etc).
+It also works server-side using NodeJS although some nodes do not work in server (audio, graphics, input, etc.).Also applies to: 93-93
🤖 Prompt for AI Agents
In `@src/lib/litegraph/README.md` at line 5, Replace the typo in the README
sentence "Some APIs may by unchanged, however it is largely incompatible with
the original." changing "by" to "be", and add the missing period after "etc.)"
wherever that fragment occurs so the sentence ends with proper punctuation;
update the exact sentence that begins "It is a fork of the original
`litegraph.js`..." and the note containing "etc.)" to reflect these corrections.
Comment on lines
+9
to
+11
| - Accumulated comfyUI custom changes (2024-01 ~ 2024-05) (https://github.com/Comfy-Org/litegraph.js/pull/1) | ||
| - Type schema change for ComfyUI_frontend TS migration (https://github.com/Comfy-Org/litegraph.js/pull/3) | ||
| - Zoom fix (https://github.com/Comfy-Org/litegraph.js/pull/7) |
Contributor
There was a problem hiding this comment.
Replace bare URLs to satisfy markdownlint MD034.
Bare URLs can trip linting; wrap them as links for consistency with the rest of the list.
💡 Proposed fix
-- Accumulated comfyUI custom changes (2024-01 ~ 2024-05) (https://github.com/Comfy-Org/litegraph.js/pull/1)
-- Type schema change for ComfyUI_frontend TS migration (https://github.com/Comfy-Org/litegraph.js/pull/3)
-- Zoom fix (https://github.com/Comfy-Org/litegraph.js/pull/7)
+- Accumulated comfyUI custom changes (2024-01 ~ 2024-05) (<https://github.com/Comfy-Org/litegraph.js/pull/1>)
+- Type schema change for ComfyUI_frontend TS migration (<https://github.com/Comfy-Org/litegraph.js/pull/3>)
+- Zoom fix (<https://github.com/Comfy-Org/litegraph.js/pull/7>)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - Accumulated comfyUI custom changes (2024-01 ~ 2024-05) (https://github.com/Comfy-Org/litegraph.js/pull/1) | |
| - Type schema change for ComfyUI_frontend TS migration (https://github.com/Comfy-Org/litegraph.js/pull/3) | |
| - Zoom fix (https://github.com/Comfy-Org/litegraph.js/pull/7) | |
| - Accumulated comfyUI custom changes (2024-01 ~ 2024-05) (<https://github.com/Comfy-Org/litegraph.js/pull/1>) | |
| - Type schema change for ComfyUI_frontend TS migration (<https://github.com/Comfy-Org/litegraph.js/pull/3>) | |
| - Zoom fix (<https://github.com/Comfy-Org/litegraph.js/pull/7>) |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
9-9: Bare URL used
(MD034, no-bare-urls)
10-10: Bare URL used
(MD034, no-bare-urls)
11-11: Bare URL used
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
In `@src/lib/litegraph/README.md` around lines 9 - 11, The three list items
contain bare URLs that violate markdownlint MD034; update each one by converting
the plain URL into a markdown link (for example replace
"https://github.com/Comfy-Org/litegraph.js/pull/1" with "[Comfy-Org/litegraph.js
PR `#1`](https://github.com/Comfy-Org/litegraph.js/pull/1)"), doing the same for
the PR `#3` and PR `#7` links in the README list so each URL is wrapped with
descriptive link text.
Comment on lines
+153
to
+158
| ### Pre-release | ||
|
|
||
| The action directly translates `Version increment type` to the pnpm version command. `Pre-release ID (suffix)` is the option for the `--preid` argument. | ||
|
|
||
| e.g. Use `prerelease` increment type to automatically bump the patch version and create a pre-release version. Subsequent runs of prerelease will update the prerelease version only. | ||
| Use `patch` when ready to remove the pre-release suffix. |
Contributor
There was a problem hiding this comment.
Use a single “prerelease” spelling in this section.
The text mixes “pre-release” and “prerelease”; standardizing avoids inconsistency.
💡 Proposed fix
-### Pre-release
+### Prerelease
@@
-The action directly translates `Version increment type` to the pnpm version command. `Pre-release ID (suffix)` is the option for the `--preid` argument.
+The action directly translates `Version increment type` to the pnpm version command. `Prerelease ID (suffix)` is the option for the `--preid` argument.
@@
-e.g. Use `prerelease` increment type to automatically bump the patch version and create a pre-release version. Subsequent runs of prerelease will update the prerelease version only.
-Use `patch` when ready to remove the pre-release suffix.
+e.g. Use `prerelease` increment type to automatically bump the patch version and create a prerelease version. Subsequent runs of `prerelease` will update the prerelease version only.
+Use `patch` when ready to remove the prerelease suffix.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| ### Pre-release | |
| The action directly translates `Version increment type` to the pnpm version command. `Pre-release ID (suffix)` is the option for the `--preid` argument. | |
| e.g. Use `prerelease` increment type to automatically bump the patch version and create a pre-release version. Subsequent runs of prerelease will update the prerelease version only. | |
| Use `patch` when ready to remove the pre-release suffix. | |
| ### Prerelease | |
| The action directly translates `Version increment type` to the pnpm version command. `Prerelease ID (suffix)` is the option for the `--preid` argument. | |
| e.g. Use `prerelease` increment type to automatically bump the patch version and create a prerelease version. Subsequent runs of `prerelease` will update the prerelease version only. | |
| Use `patch` when ready to remove the prerelease suffix. |
🧰 Tools
🪛 LanguageTool
[uncategorized] ~157-~157: Do not mix variants of the same word (‘prerelease’ and ‘pre-release’) within a single text.
Context: ...n for the --preid argument. e.g. Use prerelease increment type to automatically bump t...
(EN_WORD_COHERENCY)
[uncategorized] ~157-~157: Do not mix variants of the same word (‘prerelease’ and ‘pre-release’) within a single text.
Context: ...pre-release version. Subsequent runs of prerelease will update the prerelease version only...
(EN_WORD_COHERENCY)
[uncategorized] ~157-~157: Do not mix variants of the same word (‘prerelease’ and ‘pre-release’) within a single text.
Context: ...uent runs of prerelease will update the prerelease version only. Use patch when ready to...
(EN_WORD_COHERENCY)
🤖 Prompt for AI Agents
In `@src/lib/litegraph/README.md` around lines 153 - 158, Standardize the spelling
in the README section titled "### Pre-release" to use a single "prerelease"
form: rename the header "### Pre-release" to "### Prerelease" (or keep
capitalization consistent with other headings), and replace all occurrences of
"pre-release", "Pre-release ID (suffix)" and "pre-release suffix" in that
paragraph with "prerelease", "Prerelease ID (suffix)" and "prerelease suffix"
respectively so the section uses one consistent spelling.
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
oxfmt: Format files. Commit to be added to the blame ignore. test: update vitest snapshots Amp-Thread-ID: https://ampcode.com/threads/T-019c0170-51a5-70f9-9a56-ba2a64b31ef8 Co-authored-by: Amp <amp@ampcode.com> Exclude Vitest snapshots
DrJKL
force-pushed
the
drjkl/oxfmt-pass
branch
from
c7133a7 to
bff8e73
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
.claude/commands/create-hotfix-release.md (2)
199-252: Fix markdownlint MD031: add blank lines around fenced block.
The fenced block under the PR-body update is missing blank lines around it.🧩 Proposed fix
- - Update the PR body with the release notes: - ```bash - gh pr edit ${PR_NUMBER} --body-file release-notes-${NEW_VERSION}.md - ``` + - Update the PR body with the release notes: + + ```bash + gh pr edit ${PR_NUMBER} --body-file release-notes-${NEW_VERSION}.md + ``` +
333-361: Fix markdownlint MD040/MD029 in the fork PR section.
The inner ``` block terminates the outer fence, which triggers MD040, and the nested list numbering trips MD029.🧩 Proposed fix
- ```bash + ````bash # Create PR using gh CLI from fork gh pr create \ --repo comfyanonymous/ComfyUI \ --title "Bump frontend to ${NEW_VERSION}" \ --body "$(cat <<EOF Bump frontend to ${NEW_VERSION} ``` @@ - Fix: [Brief description of hotfixes included] EOF )" - ``` + ```` @@ -5. **Clean up:** +1. **Clean up:**src/services/README.md (1)
33-56: Add a language identifier to the ASCII diagram code fence.
markdownlint MD040 flags fenced blocks without a language; usetext(orplaintext) here.🐛 Proposed fix
-``` +```text ┌─────────────────────────────────────────────────────────┐ │ UI Components │ └────────────────────────────┬────────────────────────────┘ ... └───────────────────────────┘ └─────────────────────────┘ -``` +```
🤖 Fix all issues with AI agents
In @.claude/commands/create-frontend-release.md:
- Line 774: The document uses both "Pre-release" and "prerelease" inconsistently
(e.g., the header "### Scenario 4: Pre-release Testing" vs other occurrences of
"prerelease"); update all instances to the single chosen form "prerelease" for
consistency—change the header "### Scenario 4: Pre-release Testing" and any
other "Pre-release" occurrences to "prerelease", and run a quick search/replace
across the file to ensure uniform usage.
- Around line 489-496: In the Markdown snippet in
.claude/commands/create-frontend-release.md around the code fence that starts
with ```bash (the block under step 5), add a blank line immediately before the
opening ```bash and another blank line immediately after the closing ``` so the
fenced code block is separated from surrounding text (fixes MD031); locate the
fenced block shown in the diff and update it so there is one blank line above
the ```bash and one blank line below the closing ``` before the "6. If workflow
triggered, monitor execution:" line.
Comment on lines
+489
to
+496
| 5. If workflow didn't trigger due to [skip ci]: | ||
| ```bash | ||
| echo "ERROR: Release workflow didn't trigger!" | ||
| echo "Options:" | ||
| echo "1. Create patch release (e.g., 1.24.1) to trigger workflow" | ||
| echo "2. Investigate manual release options" | ||
| ``` | ||
| 5. If workflow triggered, monitor execution: | ||
| 6. If workflow triggered, monitor execution: |
Contributor
There was a problem hiding this comment.
Add blank lines around fenced code blocks.
The code fence at lines 490-495 is missing blank lines before and after it, violating MD031. This was previously flagged but appears to have been reintroduced.
📝 Proposed fix
5. If workflow didn't trigger due to [skip ci]:
+
```bash
echo "ERROR: Release workflow didn't trigger!"
echo "Options:"
echo "1. Create patch release (e.g., 1.24.1) to trigger workflow"
echo "2. Investigate manual release options"
```
+
6. If workflow triggered, monitor execution:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| 5. If workflow didn't trigger due to [skip ci]: | |
| ```bash | |
| echo "ERROR: Release workflow didn't trigger!" | |
| echo "Options:" | |
| echo "1. Create patch release (e.g., 1.24.1) to trigger workflow" | |
| echo "2. Investigate manual release options" | |
| ``` | |
| 5. If workflow triggered, monitor execution: | |
| 6. If workflow triggered, monitor execution: | |
| 5. If workflow didn't trigger due to [skip ci]: |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
490-490: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
495-495: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
🤖 Prompt for AI Agents
In @.claude/commands/create-frontend-release.md around lines 489 - 496, In the
Markdown snippet in .claude/commands/create-frontend-release.md around the code
fence that starts with ```bash (the block under step 5), add a blank line
immediately before the opening ```bash and another blank line immediately after
the closing ``` so the fenced code block is separated from surrounding text
(fixes MD031); locate the fenced block shown in the diff and update it so there
is one blank line above the ```bash and one blank line below the closing ```
before the "6. If workflow triggered, monitor execution:" line.
| - Comprehensive breaking change analysis | ||
| - Migration guide generation | ||
|
|
||
| ### Scenario 4: Pre-release Testing |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider standardizing "pre-release" vs "prerelease" terminology.
The document uses both "Pre-release" (line 774) and "prerelease" (line 19, 782) inconsistently. While this doesn't affect functionality, standardizing to one form (preferably "prerelease" to match line 19 and line 782) would improve consistency.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~774-~774: Do not mix variants of the same word (‘pre-release’ and ‘prerelease’) within a single text.
Context: ...ation guide generation ### Scenario 4: Pre-release Testing ```bash /project:create-fronte...
(EN_WORD_COHERENCY)
🤖 Prompt for AI Agents
In @.claude/commands/create-frontend-release.md at line 774, The document uses
both "Pre-release" and "prerelease" inconsistently (e.g., the header "###
Scenario 4: Pre-release Testing" vs other occurrences of "prerelease"); update
all instances to the single chosen form "prerelease" for consistency—change the
header "### Scenario 4: Pre-release Testing" and any other "Pre-release"
occurrences to "prerelease", and run a quick search/replace across the file to
ensure uniform usage.
benceruleanlu
previously approved these changes
Jan 27, 2026
browser_tests/README.md
Outdated
|
|
||
| ComfyUI_devtools is included in this repository under `tools/devtools/`. During CI/CD, these files are automatically copied to the `custom_nodes` directory. | ||
| _ComfyUI_devtools adds additional API endpoints and nodes to ComfyUI for browser testing._ | ||
| ComfyUI*devtools is included in this repository under `tools/devtools/`. During CI/CD, these files are automatically copied to the `custom_nodes` directory. |
Contributor
Author
There was a problem hiding this comment.
Ah, I think it is interpreting the underscore as emphasis in the formatting
Comment on lines
1
to
4
| <!-- In gardens where the agents freely play, | ||
| One stubborn flower turns the other way. --> | ||
|
|
||
| @AGENTS.md |
Member
There was a problem hiding this comment.
nit: Hope this doesn't lead to parsing issues with the bots
Contributor
Author
There was a problem hiding this comment.
I don't think it will. I'm pretty sure they respond to @References anywhere in a file.
If I'm wrong, we can undo it and exclude these.
| Those files will be updated by owner. | ||
|
|
||
|
|
||
| > Those files will be updated by owner. |
Member
There was a problem hiding this comment.
nit: technically incorrect addition
Contributor
Author
There was a problem hiding this comment.
We should probably remove this file, huh?
@coderabbitai Open an issue to audit the litegraph documentation.
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Create GitHub issue to audit litegraph documentation
gh issue create \
--title "Audit litegraph documentation" \
--body "## Context
During review of PR `#8341` (oxfmt formatting pass), questions were raised about the accuracy and necessity of documentation files in the litegraph directory, specifically \`src/lib/litegraph/CONTRIBUTING.md\`.
## Request
Audit the litegraph documentation to:
- Verify accuracy of all documentation files
- Identify outdated or incorrect content
- Determine which files should be kept, updated, or removed
- Ensure documentation aligns with current project practices
## Related
- PR: https://github.com/Comfy-Org/ComfyUI_frontend/pull/8341
- Comment: https://github.com/Comfy-Org/ComfyUI_frontend/pull/8341#discussion_r2733959753
- Requested by: `@DrJKL`" \
--assignee DrJKL
Length of output: 57
@DrJKL, I've created issue #8347 to audit the litegraph documentation. The issue has been assigned to you and includes context from this PR discussion.
🧠 Learnings used
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/AGENTS.md:0-0
Timestamp: 2026-01-16T21:33:58.233Z
Learning: Applies to src/lib/litegraph/**/litegraph/**/*.test.{ts,tsx} : Always import from the barrel export for subgraph code to avoid circular dependencies between `LGraph` and `Subgraph`
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/AGENTS.md:0-0
Timestamp: 2026-01-16T21:33:58.233Z
Learning: Applies to src/lib/litegraph/**/*.{ts,tsx} : Type assertions are a last resort (acceptable for legacy code interop)
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/AGENTS.md:0-0
Timestamp: 2026-01-16T21:33:58.233Z
Learning: Applies to src/lib/litegraph/**/*.{ts,tsx,js,jsx} : Prefer single line `if` syntax for concise expressions
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:24.164Z
Learning: The project has CI automation that handles code formatting (pnpm format) automatically, so manual formatting suggestions should not be provided in code reviews for the Comfy-Org/ComfyUI_frontend repository.
DrJKL
pushed a commit
that referenced
this pull request
Feb 3, 2026
## Summary Audits and updates litegraph documentation files that came from the old litegraph.js repo merged via git subtree (per #8341 discussion). ## Changes - **Delete** `CONTRIBUTING.md` - completely outdated, referenced original jagenjo/litegraph.js from 2020 - **Fix** `API.md` - remove Subgraph from "Removed public interfaces" (actively used in 25+ files) - **Update** `README.md` - replace standalone releasing instructions with note about embedded subtree workflow - **Fix** `AGENTS.md` and `__fixtures__/README.md` - correct import path typos (`./fixtures/` → `./__fixtures__/`) Fixes #8347 cc @DrJKL <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Documentation * Updated release information to clarify that the library is embedded via git subtree and managed through the parent repository's release process * Removed contribution guidelines documentation file * Updated API documentation by removing Subgraph from the list of removed public interfaces * Updated documentation examples to align with current project structure <!-- end of auto-generated comment: release notes by coderabbit.ai --> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8588-docs-audit-and-update-litegraph-documentation-2fc6d73d365081fca335c78ce8493d3e) by [Unito](https://www.unito.io)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expanding the covered files to format. One-time formatting pass. To be added to the
.git-blame-ignore-revs┆Issue is synchronized with this Notion page by Unito