Fix: the wrong selection under the hand mode#7541
Conversation
dosubot
bot
added
the
size:XS
📝 WalkthroughWalkthroughAdds a guard condition in the node resize pointer-down handler that returns early unless Changes
Possibly related PRs
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (9)src/**/*.vue📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.{vue,ts}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
src/**/{composables,components}/**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
src/**/*.{vue,ts,tsx}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
src/**/{components,composables}/**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
**/*.vue📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx,js,jsx,vue,json}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (4)📚 Learning: 2025-12-11T03:55:51.755ZApplied to files:
📚 Learning: 2025-12-09T03:49:52.828ZApplied to files:
📚 Learning: 2025-12-09T21:40:12.361ZApplied to files:
📚 Learning: 2025-12-11T12:25:15.470ZApplied to files:
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Test Results⏰ Completed at: 12/16/2025, 09:19:58 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status
⏰ Started at: 12/16/2025, 04:18:34 AM UTC 🚀 Building Storybook
⏱️ Please wait while the Storybook build is in progress... |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.25 MB (baseline 3.25 MB) • ⚪ 0 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 990 kB (baseline 991 kB) • 🟢 -1.58 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 184 kB (baseline 184 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 3.18 kB (baseline 3.18 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.75 MB (baseline 3.75 MB) • ⚪ 0 BBundles that do not match a named category
Status: 19 added / 19 removed |
## Summary Fixed an inconsistency where nodes were resizable in Hand mode. Resizing is now restricted to Selection mode only tomatch standard LiteGraph behavior (Hand mode should only be for panning). ## Changes What: Disabled node resizing logic when the canvas is set to Hand mode. ## Review Focus Try toggling between Selection and Hand modes. Verify that resize handles are unresponsive in Hand mode but work normally in Selection mode. ## Screenshots Before https://github.com/user-attachments/assets/2707cdd9-93f5-4820-9282-893081778dff After https://github.com/user-attachments/assets/4d4ee027-b74a-481a-8b2a-97c58799534a ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7541-Fix-the-wrong-selection-under-the-hand-mode-2cb6d73d3650812b950ef385809130bb) by [Unito](https://www.unito.io)
christian-byrne
added
needs-backport
## Summary Fixed an inconsistency where nodes were resizable in Hand mode. Resizing is now restricted to Selection mode only tomatch standard LiteGraph behavior (Hand mode should only be for panning). ## Changes What: Disabled node resizing logic when the canvas is set to Hand mode. ## Review Focus Try toggling between Selection and Hand modes. Verify that resize handles are unresponsive in Hand mode but work normally in Selection mode. ## Screenshots Before https://github.com/user-attachments/assets/2707cdd9-93f5-4820-9282-893081778dff After https://github.com/user-attachments/assets/4d4ee027-b74a-481a-8b2a-97c58799534a ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7541-Fix-the-wrong-selection-under-the-hand-mode-2cb6d73d3650812b950ef385809130bb) by [Unito](https://www.unito.io)
|
## Summary Fixed an inconsistency where nodes were resizable in Hand mode. Resizing is now restricted to Selection mode only tomatch standard LiteGraph behavior (Hand mode should only be for panning). ## Changes What: Disabled node resizing logic when the canvas is set to Hand mode. ## Review Focus Try toggling between Selection and Hand modes. Verify that resize handles are unresponsive in Hand mode but work normally in Selection mode. ## Screenshots Before https://github.com/user-attachments/assets/2707cdd9-93f5-4820-9282-893081778dff After https://github.com/user-attachments/assets/4d4ee027-b74a-481a-8b2a-97c58799534a ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7541-Fix-the-wrong-selection-under-the-hand-mode-2cb6d73d3650812b950ef385809130bb) by [Unito](https://www.unito.io)
|
(cherry picked from commit 97386b0)
## Summary Fixed an inconsistency where nodes were resizable in Hand mode. Resizing is now restricted to Selection mode only tomatch standard LiteGraph behavior (Hand mode should only be for panning). ## Changes What: Disabled node resizing logic when the canvas is set to Hand mode. ## Review Focus Try toggling between Selection and Hand modes. Verify that resize handles are unresponsive in Hand mode but work normally in Selection mode. ## Screenshots Before https://github.com/user-attachments/assets/2707cdd9-93f5-4820-9282-893081778dff After https://github.com/user-attachments/assets/4d4ee027-b74a-481a-8b2a-97c58799534a ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7541-Fix-the-wrong-selection-under-the-hand-mode-2cb6d73d3650812b950ef385809130bb) by [Unito](https://www.unito.io)
…7716) ## Summary Backport of #7541 to cloud/1.35. Fixed an inconsistency where nodes were resizable in Hand mode. Resizing is now restricted to Selection mode only to match standard LiteGraph behavior (Hand mode should only be for panning). ## Changes - Added guard clause to prevent resize in Hand mode (`shouldHandleNodePointerEvents` check) - Added `event.button !== 0` check for non-primary mouse buttons ## Original PR #7541 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7716-backport-cloud-1-35-Fix-the-wrong-selection-under-the-hand-mode-2d16d73d365081c7b558f652952bb590) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com>
) ## Summary Backport of #7541 to core/1.35. Fixed an inconsistency where nodes were resizable in Hand mode. Resizing is now restricted to Selection mode only to match standard LiteGraph behavior (Hand mode should only be for panning). ## Changes - Added guard clause to prevent resize in Hand mode (`shouldHandleNodePointerEvents` check) ## Original PR #7541 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7720-backport-core-1-35-Fix-the-wrong-selection-under-the-hand-mode-2d16d73d3650813bb00ff906db0440c2) by [Unito](https://www.unito.io) --------- Co-authored-by: Kelly Yang <124ykl@gmail.com> Co-authored-by: GitHub Action <action@github.com>
## Summary Fixed an inconsistency where nodes were resizable in Hand mode. Resizing is now restricted to Selection mode only tomatch standard LiteGraph behavior (Hand mode should only be for panning). ## Changes What: Disabled node resizing logic when the canvas is set to Hand mode. ## Review Focus Try toggling between Selection and Hand modes. Verify that resize handles are unresponsive in Hand mode but work normally in Selection mode. ## Screenshots Before https://github.com/user-attachments/assets/2707cdd9-93f5-4820-9282-893081778dff After https://github.com/user-attachments/assets/4d4ee027-b74a-481a-8b2a-97c58799534a ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7541-Fix-the-wrong-selection-under-the-hand-mode-2cb6d73d3650812b950ef385809130bb) by [Unito](https://www.unito.io)
4 participants
Summary
Fixed an inconsistency where nodes were resizable in Hand mode. Resizing is now restricted to Selection mode only tomatch standard LiteGraph behavior (Hand mode should only be for panning).
Changes
What: Disabled node resizing logic when the canvas is set to Hand mode.
Review Focus
Try toggling between Selection and Hand modes. Verify that resize handles are unresponsive in Hand mode but work
normally in Selection mode.
Screenshots
Before
before.35.02.PM.mov
After
after.mp4
┆Issue is synchronized with this Notion page by Unito