[backport core/1.35] Fix: the wrong selection under the hand mode#7720
[backport core/1.35] Fix: the wrong selection under the hand mode#7720christian-byrne merged 2 commits intocore/1.35from
Conversation
## Summary Fixed an inconsistency where nodes were resizable in Hand mode. Resizing is now restricted to Selection mode only tomatch standard LiteGraph behavior (Hand mode should only be for panning). ## Changes What: Disabled node resizing logic when the canvas is set to Hand mode. ## Review Focus Try toggling between Selection and Hand modes. Verify that resize handles are unresponsive in Hand mode but work normally in Selection mode. ## Screenshots Before https://github.com/user-attachments/assets/2707cdd9-93f5-4820-9282-893081778dff After https://github.com/user-attachments/assets/4d4ee027-b74a-481a-8b2a-97c58799534a ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7541-Fix-the-wrong-selection-under-the-hand-mode-2cb6d73d3650812b950ef385809130bb) by [Unito](https://www.unito.io)
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/22/2025, 05:38:45 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 12/22/2025, 05:48:27 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
Summary
Backport of #7541 to core/1.35.
Fixed an inconsistency where nodes were resizable in Hand mode. Resizing is now restricted to Selection mode only to match standard LiteGraph behavior (Hand mode should only be for panning).
Changes
shouldHandleNodePointerEventscheck)Original PR
#7541
┆Issue is synchronized with this Notion page by Unito