Skip to content

[backport cloud/1.35] Fix: the wrong selection under the hand mode#7716

Merged
christian-byrne merged 2 commits intocloud/1.35from
backport-7541-to-cloud-1.35
Dec 22, 2025
Merged

[backport cloud/1.35] Fix: the wrong selection under the hand mode#7716
christian-byrne merged 2 commits intocloud/1.35from
backport-7541-to-cloud-1.35

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Dec 22, 2025

Summary

Backport of #7541 to cloud/1.35.

Fixed an inconsistency where nodes were resizable in Hand mode. Resizing is now restricted to Selection mode only to match standard LiteGraph behavior (Hand mode should only be for panning).

Changes

  • Added guard clause to prevent resize in Hand mode (shouldHandleNodePointerEvents check)
  • Added event.button !== 0 check for non-primary mouse buttons

Original PR

#7541

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne requested a review from a team as a code owner December 22, 2025 17:27
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Dec 22, 2025
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 22, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 22, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport-7541-to-cloud-1.35

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 12/22/2025, 05:38:20 PM UTC

📈 Summary

  • Total Tests: 503
  • Passed: 489 ✅
  • Failed: 1 ❌
  • Flaky: 4 ⚠️
  • Skipped: 9 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 479 / ❌ 1 / ⚠️ 3 / ⏭️ 9
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 12/22/2025, 05:29:23 PM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Prettier formatting

@christian-byrne christian-byrne merged commit af46a55 into cloud/1.35 Dec 22, 2025
3 checks passed
@christian-byrne christian-byrne deleted the backport-7541-to-cloud-1.35 branch December 22, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants