Implement workflow progress panel #6092
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- floating ui elements, refactor layout - move app menu to sidebar - add log in button - remove bottom menu setting - remove second row tabs setting
Fix window overflow issues
This reverts commit 6fe4920.
- fix extra splitter with sidebar open - update components bg to use menu not secondary
More resizing changes
…/ComfyUI_frontend into pysssss/v3-floating-ui
- fix focus mode in old menu mode - fix sizing with custom extension panels
- fix drag destination
- refactor styles - hide legacy action section when empty - general tidy
- Remove deprecated getMediaKindFromFilename function (no usages found) - Define MediaType using const assertion pattern - Apply as const to extension arrays with type guards - Use type assertions for type-safe includes checks
- Integrate AssetsStore with useNodeImageUpload - Automatically update input assets when uploading to input folder - Support drag & drop, paste, and file selection Solution 2 complete: Real-time assets sync with upload triggers Related: #6112 code review feedback applied
- Integrate AssetsStore with WidgetSelectDropdown component - Auto-refresh input assets after file upload via dropdown widget - Ensures Assets sidebar stays in sync with uploaded files Part of reactive assets update implementation for better UX
viva-jinyi
force-pushed
the
feature/media-asset-sidebar-tab
branch
from
21df448 to
4eac455
Compare
… into bl-execution
DrJKL
force-pushed
the
feature/media-asset-sidebar-tab
branch
from
d578518 to
208e522
Compare
viva-jinyi
force-pushed
the
feature/media-asset-sidebar-tab
branch
2 times, most recently
from
5780728 to
b778cde
Compare
## Summary See #6537, but for litegraph widget. Doesn't allow dragging the node through the rendered markdown yet, that would be more complicated (DOMWidget complication) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6560-Feat-Doubleclick-to-toggle-edit-for-Markdown-litegraph-2a06d73d36508189bf6eedd7cdeba6db) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <[email protected]>
## Summary Match (mostly) the header design for Modern Nodes' statuses. ## Changes - **What**: Styling to match designs for more states. ## Screenshot <img width="591" height="687" alt="image" src="https://github.com/user-attachments/assets/bf8fe5d1-bd42-455c-ab20-668632ab5049" /> <!-- Add screenshots or video recording to help explain your changes --> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6530-WIP-Pinned-and-Muted-styles-29f6d73d36508191bb89dc13674db8ba) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: github-actions <[email protected]>
Adds .pnpm-store to gitignore. It's a cache folder that sometimes appears in certain scenarios that would never need to be checked into git. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6566-Add-pnpm-store-to-gitignore-2a16d73d365081319220f90516cfad3c) by [Unito](https://www.unito.io)
This pull request makes a minor UI adjustment to the `FormDropdownMenu.vue` component. The change improves the dropdown menu's usability by allowing its contents to scroll vertically and adds a small top margin for better spacing. * UI improvement: Changed the dropdown list container to use `overflow-y-scroll` and added a top margin (`mt-2`) for improved scrolling and spacing. (`src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue`)- Add top margin (mt-2) for better spacing - Change overflow-hidden to overflow-y-scroll for scrollable list ## Current https://github.com/user-attachments/assets/40cb4600-ff4e-41a5-89d6-a9aee48fa633 ## Before https://github.com/user-attachments/assets/fbe7a399-06d5-4cda-b850-f28b09f20d73 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6570-fix-improve-FormDropdownMenu-scrolling-behavior-2a16d73d3650815c883fcfeb7d9a3ace) by [Unito](https://www.unito.io)
) ## Summary - Add meta tags plugin for social media previews (Twitter, Facebook, LinkedIn, etc.) - Include SEO meta tags (title, description, keywords) - Only applies to cloud distribution (`DISTRIBUTION === 'cloud'`) ## Changes - Added Open Graph meta tags for better social media link previews - Added Twitter Card meta tags for Twitter sharing - Added SEO meta tags (title, description, keywords) - Added `og-image.png` for preview image - Meta tags only inject when `DISTRIBUTION === 'cloud'` to avoid affecting other distributions ## Test plan - [x] Build with `DISTRIBUTION=cloud pnpm build` - [x] Verify meta tags appear in built HTML - [ ] Test link sharing on Twitter, Facebook, Slack - [ ] Verify meta tags don't appear in localhost/desktop builds 🤖 Generated with Claude Code ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6571-feat-Add-Open-Graph-and-Twitter-meta-tags-for-cloud-distribution-2a16d73d365081e58c73f6009513b2bb) by [Unito](https://www.unito.io)
) ## Summary - Resolves multiple cloud environment issues when accessing `/cloud/user-check` directly - Fixes API routing problems that caused 304 Not Modified errors and JSON parsing failures - Maintains compatibility with subpath deployments for OSS users ## Root Cause The `api_base` was incorrectly calculated as `/cloud` on cloud SPA routes, causing API calls to use wrong paths like `/cloud/api/user` instead of `/api/user`. ## Issues Fixed - ❌ `/cloud/user-check` direct access resulted in infinite loading - ❌ JSON parsing errors: `Unexpected token '<', "<!DOCTYPE "... is not valid JSON` - ❌ 304 Not Modified responses on `/cloud/api/user`, `/cloud/api/settings/onboarding_survey`, `/cloud/api/system_stats` ## Solution Added conditional `api_base` calculation in `ComfyApi` constructor: - **Cloud SPA routes** (`/cloud/*`): Use empty `api_base` → API calls use `/api/*` paths - **Regular deployments**: Keep existing logic → Supports subpath deployments ## Test Plan - [x] Verify `/cloud/user-check` direct access works without infinite loading - [x] Verify all API calls return 200 instead of 304 - [x] Verify OSS subpath deployment compatibility unchanged - [x] Test authentication flow completion 🤖 Generated with [Claude Code](https://claude.ai/code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6572-Fix-cloud-routing-issues-caused-by-incorrect-api_base-calculation-2a16d73d36508163aeb2cbf6347b427d) by [Unito](https://www.unito.io)
If below large breakpoint, hide the minimap by default. If the user has set the setting before (or closed minimap), their preference will override this. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6579-hide-minimap-on-mobile-by-default-2a16d73d365081db9c66d209ee046097) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <[email protected]>
## Summary - Replace hardcoded `<base href="/">` in index.html with dynamic vite base config - Set `base: DISTRIBUTION === 'cloud' ? '/' : ''` in vite.config.mts - Ensures proper asset loading across different deployment contexts ## Test plan - [ ] Verify cloud distribution builds work correctly - [ ] Verify localhost/desktop distributions work correctly - [ ] Test asset loading in both contexts ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6562-fix-vite-use-dynamic-base-URL-based-on-cloud-distribution-2a06d73d365081c8b5d2e58870ebd14d) by [Unito](https://www.unito.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently:
┆Issue is synchronized with this Notion page by Unito