fix(vite): use dynamic base URL based on cloud distribution #6562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hardcoding base href in index.html, set vite's base config dynamically based on DISTRIBUTION === 'cloud'. This ensures proper asset loading across different deployment contexts.
dosubot
bot
added
the
size:XS
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/04/2025, 07:35:32 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 11/04/2025, 07:54:59 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Contributor
Author
|
Going to see if I can change go server instead first, as I don't want a different base url across distributions - makes things inconsistent especially for FE 3p extension devs. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.28 MB (baseline 3.28 MB) • ⚪ 0 BMain entry bundles and manifests
Graph Workspace — 728 kB (baseline 728 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Views & Navigation — 8.18 kB (baseline 8.18 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 293 kB (baseline 293 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
UI Components — 12.6 kB (baseline 12.6 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 10.4 kB (baseline 10.4 kB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 BBundles that do not match a named category
|
Contributor
Author
|
Edit: still needed for nested paths. |
benceruleanlu
pushed a commit
that referenced
this pull request
Nov 4, 2025
## Summary - Replace hardcoded `<base href="/">` in index.html with dynamic vite base config - Set `base: DISTRIBUTION === 'cloud' ? '/' : ''` in vite.config.mts - Ensures proper asset loading across different deployment contexts ## Test plan - [ ] Verify cloud distribution builds work correctly - [ ] Verify localhost/desktop distributions work correctly - [ ] Test asset loading in both contexts ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6562-fix-vite-use-dynamic-base-URL-based-on-cloud-distribution-2a06d73d365081c8b5d2e58870ebd14d) by [Unito](https://www.unito.io)
Contributor
Author
|
The reason we don't want to set it for OSS is that some apps serve the application on a nested path IIRC and it may or may not break some extensions. The fact that extensions might behave differently on cloud vs. OSS is something we need to fix eventually for this - but server-side fix was a bit too involved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
<base href="/">in index.html with dynamic vite base configbase: DISTRIBUTION === 'cloud' ? '/' : ''in vite.config.mtsTest plan
┆Issue is synchronized with this Notion page by Unito