Fix cloud routing issues caused by incorrect api_base calculation #6572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/04/2025, 12:23:07 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 11/04/2025, 12:35:18 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
viva-jinyi
added
needs-backport
viva-jinyi
requested review from
DrJKL,
christian-byrne and
webfiltered
and removed request for
DrJKL
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.28 MB (baseline 3.28 MB) • 🔴 +45 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 728 kB (baseline 728 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 8.18 kB (baseline 8.18 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 293 kB (baseline 293 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 12.6 kB (baseline 12.6 kB) • ⚪ 0 BReusable component library chunks
Status: 1 added / 1 removed Data & Services — 10.4 kB (baseline 10.4 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 1 added / 1 removed Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 BBundles that do not match a named category
|
DrJKL
approved these changes
Nov 4, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
) ## Summary - Resolves multiple cloud environment issues when accessing `/cloud/user-check` directly - Fixes API routing problems that caused 304 Not Modified errors and JSON parsing failures - Maintains compatibility with subpath deployments for OSS users ## Root Cause The `api_base` was incorrectly calculated as `/cloud` on cloud SPA routes, causing API calls to use wrong paths like `/cloud/api/user` instead of `/api/user`. ## Issues Fixed - ❌ `/cloud/user-check` direct access resulted in infinite loading - ❌ JSON parsing errors: `Unexpected token '<', "<!DOCTYPE "... is not valid JSON` - ❌ 304 Not Modified responses on `/cloud/api/user`, `/cloud/api/settings/onboarding_survey`, `/cloud/api/system_stats` ## Solution Added conditional `api_base` calculation in `ComfyApi` constructor: - **Cloud SPA routes** (`/cloud/*`): Use empty `api_base` → API calls use `/api/*` paths - **Regular deployments**: Keep existing logic → Supports subpath deployments ## Test Plan - [x] Verify `/cloud/user-check` direct access works without infinite loading - [x] Verify all API calls return 200 instead of 304 - [x] Verify OSS subpath deployment compatibility unchanged - [x] Test authentication flow completion 🤖 Generated with [Claude Code](https://claude.ai/code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6572-Fix-cloud-routing-issues-caused-by-incorrect-api_base-calculation-2a16d73d36508163aeb2cbf6347b427d) by [Unito](https://www.unito.io)
Member
|
@viva-jinyi Successfully backported to #6578 |
github-actions
bot
removed
the
needs-backport
benceruleanlu
pushed a commit
that referenced
this pull request
Nov 4, 2025
) ## Summary - Resolves multiple cloud environment issues when accessing `/cloud/user-check` directly - Fixes API routing problems that caused 304 Not Modified errors and JSON parsing failures - Maintains compatibility with subpath deployments for OSS users ## Root Cause The `api_base` was incorrectly calculated as `/cloud` on cloud SPA routes, causing API calls to use wrong paths like `/cloud/api/user` instead of `/api/user`. ## Issues Fixed - ❌ `/cloud/user-check` direct access resulted in infinite loading - ❌ JSON parsing errors: `Unexpected token '<', "<!DOCTYPE "... is not valid JSON` - ❌ 304 Not Modified responses on `/cloud/api/user`, `/cloud/api/settings/onboarding_survey`, `/cloud/api/system_stats` ## Solution Added conditional `api_base` calculation in `ComfyApi` constructor: - **Cloud SPA routes** (`/cloud/*`): Use empty `api_base` → API calls use `/api/*` paths - **Regular deployments**: Keep existing logic → Supports subpath deployments ## Test Plan - [x] Verify `/cloud/user-check` direct access works without infinite loading - [x] Verify all API calls return 200 instead of 304 - [x] Verify OSS subpath deployment compatibility unchanged - [x] Test authentication flow completion 🤖 Generated with [Claude Code](https://claude.ai/code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6572-Fix-cloud-routing-issues-caused-by-incorrect-api_base-calculation-2a16d73d36508163aeb2cbf6347b427d) by [Unito](https://www.unito.io)
christian-byrne
pushed a commit
that referenced
this pull request
Nov 5, 2025
…ase calculation (#6578) Backport of #6572 to `rh-test` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6578-backport-rh-test-Fix-cloud-routing-issues-caused-by-incorrect-api_base-calculation-2a16d73d36508157a3edfca38af1cf03) by [Unito](https://www.unito.io) Co-authored-by: Jin Yi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/cloud/user-checkdirectlyRoot Cause
The
api_basewas incorrectly calculated as/cloudon cloud SPA routes, causing API calls to use wrong paths like/cloud/api/userinstead of/api/user.Issues Fixed
/cloud/user-checkdirect access resulted in infinite loadingUnexpected token '<', "<!DOCTYPE "... is not valid JSON/cloud/api/user,/cloud/api/settings/onboarding_survey,/cloud/api/system_statsSolution
Added conditional
api_basecalculation inComfyApiconstructor:/cloud/*): Use emptyapi_base→ API calls use/api/*pathsTest Plan
/cloud/user-checkdirect access works without infinite loading🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito