Skip to content

Comments

draft: ComfyUI-Manager v4#1737

Draft
ltdrdata wants to merge 128 commits intomainfrom
draft-v4
Draft

draft: ComfyUI-Manager v4#1737
ltdrdata wants to merge 128 commits intomainfrom
draft-v4

Conversation

@ltdrdata
Copy link
Member

@ltdrdata ltdrdata commented Apr 12, 2025

This PR is meant to be paired with:

This PR is based on branch:

TODO:

  • Disable eager requests made by legacy manager FE code
  • Publish initial version to pypi manually for easier testing
  • Implement cacheless
  • Test
    • Test: Can use legacy manager UI with --enable-manager-legacy-ui
      • Test: Model Manager with legacy ui
      • Test: Snapshot restore with legacy ui
      • Test: Node browsing with legacy ui
      • Test: Node management/actions with legacy ui
      • Test: Config/settings with legacy ui
      • Test: Updating and switching versions with legacy ui
      • Test: Misc. features with legacy ui
      • Test: Community Manual, Workflow Gallery, Nodes info with legacy ui
      • Test: Installing nodes with legacy ui
    • Test: Using every single feature and manager API endpoint with the full e2e setup
    • Test: Using with --disable-manager arg
    • Test: Using when manager custom node is still on user system
    • Test: ComfyUI updated but comfyui-frontend-package was not
      • Result: manager is just not useable, because no UI entry. Should be fine. Let the frontend warning in ComfyUI handle.
    • Test: Using --disable-manager arg then loading manager as a custom node This is not worth supporting--if the user wants the legacy version they can use --enable-manager-legacy-ui

ltdrdata and others added 24 commits March 19, 2025 07:41
modified: install_by_id - Change the install path of the CNR node added by the system to be based on the repo URL instead of the CNR ID.
POST /v2/manager/queue/batch
GET /v2/manager/queue/history_list
GET /v2/manager/queue/history?id={id}
GET /v2/manager/queue/abort_current
modified: install_by_id - Change the install path of the CNR node added by the system to be based on the repo URL instead of the CNR ID.
@socket-security
Copy link

socket-security bot commented Jul 25, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License

View full report

ltdrdata and others added 22 commits July 27, 2025 16:07
…ructure.

The glob/... version will be applied later after the cacheless implementation is completed.
* [feat] Add bulk import failure info API endpoint

- Add import_fail_info_bulk endpoint to both glob and legacy manager servers
- Supports bulk processing of cnr_ids and urls arrays in single request
- Maintains same error handling pattern as original import_fail_info API
- Reduces API calls from N to 1 for conflict detection optimization
- Validates input parameters and provides proper error responses

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* modified: remove manager button completely. Now, even when using the legacy UI, it must always be accessed through the menu.

* chore(api): Add temporary cache reload for import_fail_info_bulk

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Dr.Lt.Data <dr.lt.data@gmail.com>
- Regenerated Pydantic models from updated OpenAPI specification
- Updated import_fail_info_bulk route handler to use ImportFailInfoBulkRequest/Response models
- Replaced manual JSON validation with Pydantic model validation
- Added proper error handling with ValidationError
- Updated data_models/__init__.py to export new models

Following the process outlined in data_models/README.md for type safety and consistency.
…k-api

Add Pydantic validation to import_fail_info_bulk endpoint
modified: The matrix share feature is now only available when the `matrix-nio` dependency is installed.

If `matrix-nio` is not installed:
1. Apply a strikethrough to the matrix checkbox text in the share UI and display a tooltip.
2. A warning is logged at startup indicating that `matrix-nio` is missing, along with the installation command.

fixed: Corrected an issue where PR #2025 was merged into draft-v4 but applied only to `legacy/..` and not to `glob/..`
Revert "As a temporary measure, the new UI will use the legacy/... ba…
* fix: import failed info bulk api bug fix

* fix: Remove unused ImportFailInfoBulkResponse import
…he default channel

- Mismatch issue between ltdrdata/ and Comfy-Org/
modified: /v2/customnode/installed – cnr_id was being returned in a normalized form
modified: /v2/customnode/installed – when both an enabled nodepack and a disabled nodepack existed, modified to report only the enabled nodepack
fixed: Removed unnecessary warning messages printed during nodepack installation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants