[feat] Add bulk import failure info API endpoint#2035
Merged
ltdrdata merged 3 commits intoComfy-Org:draft-v4from Jul 29, 2025
Merged
[feat] Add bulk import failure info API endpoint#2035ltdrdata merged 3 commits intoComfy-Org:draft-v4from
ltdrdata merged 3 commits intoComfy-Org:draft-v4from
Conversation
- Add import_fail_info_bulk endpoint to both glob and legacy manager servers - Supports bulk processing of cnr_ids and urls arrays in single request - Maintains same error handling pattern as original import_fail_info API - Reduces API calls from N to 1 for conflict detection optimization - Validates input parameters and provides proper error responses 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
After merging, we will need to follow this process: On
On
On
Context: the openapi yaml is the source of truth for the types of data going back and forth between frontend client and ComfyUI-Manager server. We only need to change that then both the server and client generate the types both, ensuring type consistency is always maintained. |
Comment on lines
1664
to
1675
| # Basic validation - ensure we have either cnr_ids or urls | ||
| if not isinstance(json_data, dict): | ||
| return web.Response(status=400, text="Request body must be a JSON object") | ||
|
|
||
| if "cnr_ids" not in json_data and "urls" not in json_data: | ||
| return web.Response( | ||
| status=400, text="Either 'cnr_ids' or 'urls' field is required" | ||
| ) | ||
|
|
||
| results = {} | ||
|
|
||
| if "cnr_ids" in json_data: |
Contributor
There was a problem hiding this comment.
After generating the data models, we can use the Pydantic built-in validation 👍
…legacy UI, it must always be accessed through the menu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add bulk API endpoint for import failure information to reduce API calls from N to 1 for performance optimization.
Changes
/v2/customnode/import_fail_info_bulkcnr_idsand/orurlsarraysimport_fail_infoAPIAPI Details
Returns object with package IDs/URLs as keys and import failure info as values.
Test plan
🤖 Generated with Claude Code