Migrate matrix-client to matrix-nio#2025
Merged
ltdrdata merged 1 commit intoComfy-Org:mainfrom Jul 24, 2025
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ltdrdata
added a commit
that referenced
this pull request
Aug 22, 2025
modified: The matrix share feature is now only available when the `matrix-nio` dependency is installed. If `matrix-nio` is not installed: 1. Apply a strikethrough to the matrix checkbox text in the share UI and display a tooltip. 2. A warning is logged at startup indicating that `matrix-nio` is missing, along with the installation command. fixed: Corrected an issue where PR #2025 was merged into draft-v4 but applied only to `legacy/..` and not to `glob/..`
webfiltered
added a commit
that referenced
this pull request
Aug 27, 2025
This reverts commit d4715ae.
webfiltered
added a commit
to Comfy-Org/desktop
that referenced
this pull request
Aug 27, 2025
Updates ComfyUI-Manager to the latest commit, and reverts the following PRs: - Comfy-Org/ComfyUI-Manager#2025 - Follow-up commit: Comfy-Org/ComfyUI-Manager@4834874 This removes the requirement for every desktop user to download several new packages for the matrix share feature. This is an inconvenience for users wanting to use matrix share, however including this update will cause major update pain for many international users with network issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've mentioned this before in the Discussions:
#1185
And by now it's more pressing:
matrix-clientis no longer working (at least in my tests)matrix-client 0.4.0 depends on urllib3~=1.21is causing more troubles (e.g.gradiodepends on newerurllib3)So I made this PR (with some help from Copilot and matrix-nio examples).
My test screenshot: