Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom pipes design #31

Closed
wants to merge 4 commits into from
Closed

Custom pipes design #31

wants to merge 4 commits into from

Conversation

DaGuT
Copy link
Contributor

@DaGuT DaGuT commented Mar 10, 2018

No description provided.

@DaGuT DaGuT changed the title deleted extra images (cleanup) deleted extra images (cleanup) + reverted marshmallow pipes Mar 10, 2018
@DaGuT DaGuT closed this Mar 10, 2018
@DaGuT DaGuT reopened this Mar 10, 2018
@DaGuT DaGuT changed the title deleted extra images (cleanup) + reverted marshmallow pipes deleted extra images (cleanup) + reverted marshmallow pipes without peaks (it's funnier :) Mar 10, 2018
@shiffman
Copy link
Member

I'm happy to merge the deletion of the extra images but I'd like to accept #33 which this will conflict with I think.

@DaGuT
Copy link
Contributor Author

DaGuT commented Mar 10, 2018

@shiffman
#25 (comment)

This one had nice sweety unicorn stuff :D

If you merge #33 , I'll just pull everything that was updated and just will do that cleanup without this pipe changing, so no worries, do what you think should be done, I'll fix everything :D or may be even add something

Also, if you enjoy marshmallow style, merge this. If you prefer mario style, merge that. I'll fix everything as I said here before

@matcool matcool mentioned this pull request Mar 10, 2018
@DaGuT
Copy link
Contributor Author

DaGuT commented Mar 11, 2018

@shiffman dont you want these nasty pipes instead of green ones? :)

@DaGuT DaGuT mentioned this pull request Mar 13, 2018
@DaGuT DaGuT closed this Mar 13, 2018
@DaGuT DaGuT reopened this Mar 13, 2018
@DaGuT DaGuT changed the title deleted extra images (cleanup) + reverted marshmallow pipes without peaks (it's funnier :) Custom pipes design Mar 13, 2018
@DaGuT DaGuT closed this Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants