Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some unicorn horn textures for the pipes. #23

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Added some unicorn horn textures for the pipes. #23

merged 1 commit into from
Mar 9, 2018

Conversation

K1ngjulien
Copy link
Contributor

@K1ngjulien K1ngjulien commented Mar 9, 2018

The textures should line up at the top and bottom. In the paitDotNet folder there are the original files if you want to edit them.

I'll try to implement them later, maybe someone else will be faster

@K1ngjulien
Copy link
Contributor Author

Maybe they are a little to wide but that should be scaleable in javascript

@shiffman
Copy link
Member

shiffman commented Mar 9, 2018

Can you include a screenshot or link to your demo running via github pages? That would be helpful for reviewing the design changes!

@shiffman shiffman mentioned this pull request Mar 9, 2018
@K1ngjulien
Copy link
Contributor Author

They are not yet implemented into the game

@K1ngjulien
Copy link
Contributor Author

Is there a reason why this image is 500:400px in the first console.log and 1:1px in the second one?

image

All I've done with the images is load them like this

this.bodyImg = loadImage("graphics/horn_body_filled.png");
this.tipImg = loadImage("graphics/horn_tip_filled.png");

console.log(this.bodyImg);
console.log(this.bodyImg.width,this.bodyImg.height)

@K1ngjulien
Copy link
Contributor Author

Could it be that the images are loaded asynchronously?

@DaGuT
Copy link
Contributor

DaGuT commented Mar 9, 2018

you need to load images in preload() {} function

do you mind if I write that code for ya?
#25
Well. I already did, but if youre against, then I'll delete it

@K1ngjulien
Copy link
Contributor Author

sorry I havent worked with p5 much, i just read it in the documentation. Is it ok if I do it in setup like the background image?

@DaGuT
Copy link
Contributor

DaGuT commented Mar 9, 2018

first you need to load all images in preload, only this way you can be sure then we setup is being executed images are loaded. Otherwise, they 90% will not

@K1ngjulien
Copy link
Contributor Author

ok I have it now, sorry for noobieness :D

@DaGuT
Copy link
Contributor

DaGuT commented Mar 9, 2018

no worries, I'm with ya
Anyway, check the code that I linked...

@K1ngjulien
Copy link
Contributor Author

the background image is loaded in setup, should it be moved?

@DaGuT
Copy link
Contributor

DaGuT commented Mar 9, 2018

check the new code from original master branch. It's already in preload :)

753ebbc this commit

@DaGuT
Copy link
Contributor

DaGuT commented Mar 9, 2018

#25
this pull request relies on your work.
Do you mind if I do some coding for ya that I already did? They first need to merge your request, as mine relies on yours. Or I should go back to my code, so that you can later put your new tubes there?

screenshot for ya great work #25 (comment)

@meiamsome meiamsome merged commit 5c6c6f0 into CodingTrain:master Mar 9, 2018
DaGuT added a commit to DaGuT/Flappy-Bird-Clone that referenced this pull request Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants