-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wider tubes + proper tube look (merge #23 before, pls) #25
Conversation
now I added #25 these images so that you can use them in your video in 2h, when I'll be sleeping |
added collision fix for wide this.w |
Please don't include parallax in this PR - it is something that does not belong with these other changes and is going to be an issue with conflicts. PRs are usually preferred to be minimal changes (Pipe changes should be able to be the sprites and the width changes, I suppose). Can you explain why your comment says the collision model fails? As far as I can tell it shouldn't |
Also, I would check with @K1ngjulien whether they are OK with you using their sprites for your implementation. |
Previous collision was checking if ends of image were on opposite sites of tube, now when size of bird is less than tube, it cannot be true. So now it's working. I'm playing it right now. Gonna delete parallax, pls merge xD So that I can go sleeping |
Oh right, I saw that problem while I was on your branch and didn't realise I had already pulled it into master! |
Yeah, sry for that :) |
If you merge this #23 , mine code is gonna work and his commit will be seen. Or should I rever back to my old pipe? |
@meiamsome if you merge my pr #23 @DaGuT can implement my images if he wants to 😃 |
Thank you. Now I fully remade my code to use your images. They are no longer with my commits peaks are gonna be later, as it's 2:07 an :( |
Boom, and peaks are added Thx to #23 for his awesome paintings |
@meiamsome All my changes are just for tubes. So It's small pull request :) Now I'm gonna sleep, have a good day and please merge #23 with me :) |
Awesome is a bit of an overstatement but thank you 😄 |
merge this #23 first, as mine relies on that request