Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color Picker Modal remains open even after switching Color Palettes #2628

Closed
mghenciu opened this issue Mar 10, 2021 · 0 comments
Closed

Color Picker Modal remains open even after switching Color Palettes #2628

mghenciu opened this issue Mar 10, 2021 · 0 comments
Assignees
@preda-bogdan
Labels
bug This label could be used to identify issues that are caused by a defect in the product. small enhancement Small feature or change

Comments

@mghenciu
Copy link

Description:

If you try to paste a color value, adjust Transparency and then switch the Color Palette (without closing the color picket modal) -> the modal will remain open, until you close it manually. See the attached video.

How to reproduce:

  1. Open a fresh Gutenberg demo
  2. Go to Customizer -> Color Palettes
  3. Add #0e0d0f with 0.28 transparency as a Extra Color 1
  4. Without closing the modal, switch the color palette (click on another Palette)

Expected behaviour:

The color picker modal should close itself.

Current behaviour:

Apparently it does this only when using alpha options and when pasting color values.

Reference:

https://www.loom.com/share/9398e2229d474f928b4147d1457e5c1d
image

Technical info

  • WordPress 5.7
  • Theme Version: 2.10.2
@mghenciu mghenciu added bug This label could be used to identify issues that are caused by a defect in the product. small enhancement Small feature or change Global colors labels Mar 10, 2021
@selul selul assigned preda-bogdan and unassigned abaicus Apr 10, 2021
preda-bogdan added a commit that referenced this issue Apr 13, 2021
@preda-bogdan
fix: fragment id was not triggering component update #2628
af59bc9
@preda-bogdan preda-bogdan mentioned this issue Apr 13, 2021
Closed
@selul selul mentioned this issue Apr 23, 2021
Merged
abaicus added a commit that referenced this issue Apr 28, 2021
@abaicus
release: new version
018c07b 
- [Fix] Dropdowns (input select) in specific widgets do not respect global form styles  - #2581
- [Fix] Wrong text color inheritance in group blocks with color settings - #2540
- [Fix] Cart icon opening behavior when positioned on the left side of header - #2468
- [Fix] Improve accessibility for external links in the Neve page and customizer
- [Fix] Color Picker Modal remains open even after switching Color Palettes - #2628
- [Fix] Increase Templates Cloud visibility on Neve options page
- [Fix] Infinite scroll loads posts of incorrect language - #2696
- [Feat] Add global color as presets in beaver builder - #2328.
- [Feat] Ignore lazyload on above the fold images 
- [Feat] implement next page links for infinite scroll
- [Feat] Adds compatibility for meta association on template import/export for Neve Cloud
pirate-bot added a commit that referenced this issue Apr 28, 2021
@pirate-bot
chore(release): 2.11.2
c3f5670 
##### [Version 2.11.2](v2.11.1...v2.11.2) (2021-04-28)

- [Fix] Dropdowns (input select) in specific widgets do not respect global form styles  - #2581
- [Fix] Wrong text color inheritance in group blocks with color settings - #2540
- [Fix] Cart icon opening behavior when positioned on the left side of header - #2468
- [Fix] Improve accessibility for external links in the Neve page and customizer
- [Fix] Color Picker Modal remains open even after switching Color Palettes - #2628
- [Fix] Increase Templates Cloud visibility on Neve options page
- [Fix] Infinite scroll loads posts of incorrect language - #2696
- [Feat] Add global color as presets in beaver builder - #2328.
- [Feat] Ignore lazyload on above the fold images
- [Feat] implement next page links for infinite scroll
- [Feat] Adds compatibility for meta association on template import/export for Neve Cloud
@selul selul closed this as completed May 4, 2021
@preda-bogdan preda-bogdan mentioned this issue Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@preda-bogdan preda-bogdan

Labels
bug This label could be used to identify issues that are caused by a defect in the product. small enhancement Small feature or change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@selul @abaicus @preda-bogdan @mghenciu