Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/issue 2971 #3142

Merged
merged 2 commits into from
Oct 8, 2021
Merged

Feat/issue 2971 #3142

merged 2 commits into from
Oct 8, 2021

Conversation

preda-bogdan
Copy link
Contributor

Summary

Added a check for WordPress version and conditioned the load of the patched version of the ColorPicker based on that.

Will affect visual aspect of the product

NO

Test instructions

  1. Test the color pickers from Customizer with version higher or equal to 5.8
  2. Test the color pickers from Customizer with version lower than 5.8

The patched version was made for this issue: #2628
You can use the details provided there to test that no regression is introduced.

Closes #2971.

@github-actions
Copy link

github-actions bot commented Oct 5, 2021

Plugin build for 6ff69fb is ready 🛎️!

globals/utilities.php Outdated Show resolved Hide resolved
@irinelenache
Copy link
Contributor

@preda-bogdan Tested this PR and the Color picker works as expected with versions higher/lower than 5.8 👍

@selul selul merged commit 65ba3c7 into development Oct 8, 2021
@selul selul deleted the feat/issue_2971 branch October 8, 2021 14:22
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.0.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants