Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cart icon opening behaviour when positioned in the left side of the header #2468

Closed
rodica-andronache opened this issue Jan 12, 2021 · 1 comment · Fixed by #2741
Closed

Cart icon opening behaviour when positioned in the left side of the header #2468

rodica-andronache opened this issue Jan 12, 2021 · 1 comment · Fixed by #2741
Assignees
@mskapusuz
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@rodica-andronache
Copy link
Contributor

When the Cart Icon component is positioned on the left side of the header, it sometimes opens the mini-cart on the left side, and sometimes on the right-side, depending on the page, and if you add a new product in the cart. Couldn't find a distinct pattern, but I've tried to show the issue in the video.

https://www.loom.com/share/8555fb98a9f84184828693fb1e834505
@rodica-andronache rodica-andronache added the bug This label could be used to identify issues that are caused by a defect in the product. label Jan 12, 2021
@mskapusuz mskapusuz mentioned this issue Apr 11, 2021
Merged
@mskapusuz mskapusuz linked a pull request Apr 11, 2021 that will close this issue
fix: Fix cart icon opening behaviour when positioned in the left side… #2741
Merged
@selul selul mentioned this issue Apr 23, 2021
Merged
abaicus added a commit that referenced this issue Apr 28, 2021
@abaicus
release: new version
018c07b 
- [Fix] Dropdowns (input select) in specific widgets do not respect global form styles  - #2581
- [Fix] Wrong text color inheritance in group blocks with color settings - #2540
- [Fix] Cart icon opening behavior when positioned on the left side of header - #2468
- [Fix] Improve accessibility for external links in the Neve page and customizer
- [Fix] Color Picker Modal remains open even after switching Color Palettes - #2628
- [Fix] Increase Templates Cloud visibility on Neve options page
- [Fix] Infinite scroll loads posts of incorrect language - #2696
- [Feat] Add global color as presets in beaver builder - #2328.
- [Feat] Ignore lazyload on above the fold images 
- [Feat] implement next page links for infinite scroll
- [Feat] Adds compatibility for meta association on template import/export for Neve Cloud
pirate-bot added a commit that referenced this issue Apr 28, 2021
@pirate-bot
chore(release): 2.11.2
c3f5670 
##### [Version 2.11.2](v2.11.1...v2.11.2) (2021-04-28)

- [Fix] Dropdowns (input select) in specific widgets do not respect global form styles  - #2581
- [Fix] Wrong text color inheritance in group blocks with color settings - #2540
- [Fix] Cart icon opening behavior when positioned on the left side of header - #2468
- [Fix] Improve accessibility for external links in the Neve page and customizer
- [Fix] Color Picker Modal remains open even after switching Color Palettes - #2628
- [Fix] Increase Templates Cloud visibility on Neve options page
- [Fix] Infinite scroll loads posts of incorrect language - #2696
- [Feat] Add global color as presets in beaver builder - #2328.
- [Feat] Ignore lazyload on above the fold images
- [Feat] implement next page links for infinite scroll
- [Feat] Adds compatibility for meta association on template import/export for Neve Cloud
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.11.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Apr 28, 2021
@selul selul closed this as completed Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mskapusuz mskapusuz

Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix cart icon opening behaviour when positioned in the left side… Codeinwp/neve
4 participants
@rodica-andronache @selul @mskapusuz @pirate-bot