fix: Fix cart icon opening behaviour when positioned in the left side… #2741
Conversation
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||
|
@mskapusuz tested it and it works fine 👍 |
…opening-behaviour-in-left-side-header-issue-2468
|
@irinelenache Can you check again? I have made some refactoring, it can be tested now. thanks! |
|
It opens on the left side, and the right side ( https://www.loom.com/share/b591e646be164a63af9f43d2587646c7 ) |
…keep default behaviour
|
@tudor-themeisle Once mini cart is positioned on left, it was still staying there even if should be positioned on default. I have fixed this now. The expected behavior is if there is no space more than 350px in the left side of the mini cart, mini cart should be opened in right side. It's not related with the mobile view of the dev console. When you opened the console, the window width is changing. |
|
@tudor-themeisle I have detected an error, I'm fixing it now. Once is ready for testing, I will notify you on here. |
|
@Tudor-dev It is ready now for testing! |
|
Tested, It works fine. |
selul
deleted the
fix/cart-icon-opening-behaviour-in-left-side-header-issue-2468
branch
|
🎉 This PR is included in version 2.11.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
… of the header.
Summary
When the cart icon was positioned to the left, the mini cart was opening to the left. This caused the mini cart content to not be seen properly. With this pull request, when the mini cart icon is positioned to the left, the mini cart layout has been opened in the right direction.
Will affect visual aspect of the product
YES
Screenshots
Before:
After:
Test instructions
Closes #2468 .