Expand the useable weapons in melee training recipes#69427
Merged
Maleclypse merged 8 commits intoCleverRaven:masterfrom Nov 17, 2023
Merged
Expand the useable weapons in melee training recipes#69427Maleclypse merged 8 commits intoCleverRaven:masterfrom
Maleclypse merged 8 commits intoCleverRaven:masterfrom
Conversation
github-actions
bot
added
[JSON]
Termineitor244
suggested changes
Nov 16, 2023
Contributor
Termineitor244
left a comment
Termineitor244
left a comment
There was a problem hiding this comment.
I suppose you were using an old version of master? Since the changes from #69367 were being reverted.
Contributor
Author
Yep, I'm using an old version of the master branch. Sorry about that. |
Co-authored-by: Termineitor244 <termineitor244@hotmail.com>
Contributor
Don't worry! Thank you for the good work! |
github-actions
bot
added
the
BasicBuildPassed
Contributor
Termineitor244
left a comment
Termineitor244
left a comment
There was a problem hiding this comment.
Some misc suggestions for the requirements.
Co-authored-by: Termineitor244 <termineitor244@hotmail.com>
Co-authored-by: Termineitor244 <termineitor244@hotmail.com>
Co-authored-by: Termineitor244 <termineitor244@hotmail.com>
Co-authored-by: Termineitor244 <termineitor244@hotmail.com>
akrieger
reviewed
Nov 16, 2023
MNG-cataclysm
commented
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Balance "Expand the useable weapons in melee training recipes."
Purpose of change
Fix #69250, and revamp the useable weapons in melee training recipes by way of requirements.
Describe the solution
Add several new, organized requirement entries for melee weapons as tools, and use these in the melee practice recipes. This expands the useable weapons, simplifies item updating, and fixes problems with different steel type weapons.
Describe alternatives you've considered
Not doing this, or using tool qualities on individual items.
Testing
Went into the game and practiced with the new systems. Everything works great.
Additional context
I only allowed basic weapon items for lower-grade recipes because I didn't think they'd be useable as "true" weapons. I can change this later if need be.