Nested weapon combat practice#69367
Merged
Maleclypse merged 3 commits intoCleverRaven:masterfrom Nov 14, 2023
Merged
Conversation
Contributor
Author
|
Maybe I should remove "practice" from the nested groups names? |
Maleclypse
pushed a commit
to Maleclypse/Cataclysm-DDA
that referenced
this pull request
Nov 16, 2023
* Nesred weapon combat practice * Adjust difficulty * Removed "practice" from names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content "Adds nested groups to the weapon combat practice recipes"
Purpose of change
Since #68734 and later #69156 I had the idea of adding nested groups to the new combat practice recipes, since they were clearly a lot, but felt that the PR was already too big and I had already asked too many things so I decided to just do it myself after it was merged... And here we are!
Describe the solution
Adds several nested groups for most of the new combat practice recipes when appropriate, some are just too weird to be categorized with other weapons (Looking at you hooking weapons and flails >_>) but most of them could be grouped with similar weaponry for ease of finding and for the sanity of the player.
Describe alternatives you've considered
Maybe a group that includes unarmed combat and claws? Since claws are a semi unarmed weapon, but it felt too forced...
Also, maybe different names for the mixed groups? But I decided against since I wanted the player to easily know what recipes were inside...
Testing
The game loads, the recipes appear in their respective groups.
Additional context
Before:



After: