Add include directories to CMake SDL2 targets#68382
Merged
kevingranade merged 2 commits intoCleverRaven:masterfrom Sep 30, 2023
Merged
Add include directories to CMake SDL2 targets#68382kevingranade merged 2 commits intoCleverRaven:masterfrom
kevingranade merged 2 commits intoCleverRaven:masterfrom
Conversation
Contributor
|
Ha, beat me to it. One thing of note is that in my testing it was only SDL2_image that needed the extra property. I'm pretty sure this is just because (perhaps on macOS specifically) it ends up in a directory not picked up by FindSDL2. The rest incidentally line up on the default include path. I'm not totally sure what changed on my setup that only made CMake recently fail to build this, but regardless, this change compiles and runs for me. |
1c220c5 to
9e96cd4
Compare
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
perryprogfound the include dirs were missing in target definitions, so here they are.Describe the solution
Add
INTERFACE_INCLUDE_DIRECTORIEStoFindSDL2*.cmakeDescribe alternatives you've considered
Testing
Built in Visual Studio 2022 and VS Code in Docker Desktop WSL2 Dev Container. No attempt to run.
Let the CI build and see.
Additional context