Hotfix for #66273#66287
Merged
bombasticSlacks merged 2 commits intoCleverRaven:masterfrom Jun 18, 2023
Merged
Conversation
github-actions
bot
added
[C++]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
json-styled
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
astyled
This was referenced Jun 18, 2023
github-actions
bot
added
the
BasicBuildPassed
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "All directories starting with dot"
Purpose of change
Fixes #66273
Describe the solution
as_norm_dirreturns./if the directory normalizes to..Describe alternatives you've considered
Rewrite all code using paths as strings to use
fs::pathand its append operator.Testing
Run the executable, check for
.dir/s, Play Now!, save and exit, restart, load again.Additional context
Waiting for Actions work out linting issues