CMake install() changes, static linking build, mark directories with fs::path{}#65822
Merged
kevingranade merged 19 commits intoCleverRaven:masterfrom Jun 17, 2023
Merged
CMake install() changes, static linking build, mark directories with fs::path{}#65822kevingranade merged 19 commits intoCleverRaven:masterfrom
kevingranade merged 19 commits intoCleverRaven:masterfrom
Conversation
github-actions
bot
added
[C++]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
json-styled
Contributor
|
Why does the CMake definition need so much maintenance work? Or rather, what problem does this PR solve? |
github-actions
bot
added
the
astyled
Contributor
Author
I have expanded a bit the PR text, hope it answer your questions. |
github-actions
bot
added
astyled
github-actions
bot
added
the
<Bugfix>
alef
changed the title
Contributor
Author
|
Clang-tidy fails in code this PR did not changed. |
The FindSDL2*.cmake modules create the *::*-static imported targets like VCPKG does. This way we can reuse the same names and reduce the complexity in the main and src CMakeLists.txt.
The presets inherits from the configuration not using VCPKG
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Changes how CMake and some code handle paths.
Edit: Not fixing problems here. It is more about expanding what configurations can be build through CMake definitions: extended explanations on task list below.
Describe the solution
pkg-configwhere possible. This allows to discover static library files in Ubuntu which are not by packages' own.cmakeconfig filesfs::path{}Describe alternatives you've considered
A non-dynamic executable cannot really be built as in VCPKG, because not all requirements are there. It reduces anyway the dynamic dependencies.
Testing
Can't get SDL/TILES to run via WSL2's pulseaudio/CygwinX/Wayland transports.
Additional context
Will start with draft PR, responding to C/I issues