Update vcpkg configuration, again#64874
Merged
kevingranade merged 1 commit intoCleverRaven:masterfrom Apr 6, 2023
Merged
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Another package has evaporated from the internet, prompting us to need to update vcpkg again. Coincidentally, the
run-vcpkgaction recently updated and now uses built-in vcpkg caching machinery for build caching instead of its ad-hoc mechanism. We should use that because it'll be more granular and let us share packages across all three Windows builds we do (cdda, object creator and cdda release). To successfully maintain a consistent cachekey, though, we need to install a consistent version of cmake (as the cmake version feeds into the cachekey for many packages).Describe the solution
Use
lukka/get-cmakefor a consistent cmake in the builds. Updatelukka/run-vcpkgto v11 (implicitly .1 now that it is setup to automatically enable vcpkg's builtin caching). Update the vcpkg commit hash to the minimum version v11 needs.Describe alternatives you've considered
Testing
Pushed to my repo, got successful builds.
Pushed again to my repo, got some cache hits but not enough. Investigation showed it was due to a differing cmake version.
Pushed to my repo with get-cmake, cache keys were consistent again.
Additional context
Example inconsistent cache key output:
Workflow 1:
Workflow 2: