Fix CMake compilation and localization#63208
Merged
dseguin merged 1 commit intoCleverRaven:masterfrom Jan 22, 2023
Merged
Conversation
Localization: - Outdated .gitignore entry - Outdated documentation of .mo file compilation - Outdated .pot generation code Compilation: - `target_link_libraries` mixed signature error - Target name typo
github-actions
bot
added
<Documentation>
Willenbrink
pushed a commit
to Willenbrink/Cataclysm-DDA
that referenced
this pull request
Jan 25, 2023
Localization: - Outdated .gitignore entry - Outdated documentation of .mo file compilation - Outdated .pot generation code Compilation: - `target_link_libraries` mixed signature error - Target name typo
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build "Fix CMake mixed signature error and outdated localization code"
Purpose of change
Fix the following issues I found when compiling:
Compilation:
target_link_librariesmixed signature errorLocalization:
Describe the solution
Add explicit PUBLIC/PRIVATE keywords to target_link_libraries calls. Fix a target name that should be
cataclysm-commoninstead ofcataclysm-tiles-common.Remove outdated .gitignore entry of
en.poand update documentation of CMake localization. Replace the very outdated .pot generation code inlang/CMakeLists.txtwith a call toupdate_pot.shinstead.Testing
The game now compiles without the mixed signature error.
update_pot.shruns whentranslationstarget is specified.Additional context
N/A