Skip to content

Verify font can be rendered successfully at runtime #52133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevingranade merged 2 commits into from
Oct 7, 2021
Merged

Verify font can be rendered successfully at runtime #52133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aaf182
Verify font can be rendered successfully at runtime
BrettDong Oct 6, 2021
712d404
Fix clang-tidy warning
BrettDong Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/sdl_font.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,15 @@ SDL_Texture_Ptr CachedTTFFont::create_glyph( const SDL_Renderer_Ptr &renderer,

bool CachedTTFFont::isGlyphProvided( const std::string &ch ) const
{
return TTF_GlyphIsProvided( font.get(), UTF8_getch( ch ) );
// Just return false if the glyph is not provided by the font
if( !TTF_GlyphIsProvided( font.get(), UTF8_getch( ch ) ) ) {
return false;
}

// Test whether the glyph can actually be rendered
constexpr SDL_Color white{255, 255, 255, 0};
SDL_Surface_Ptr surface( TTF_RenderUTF8_Solid( font.get(), ch.c_str(), white ) );
return static_cast<bool>( surface );
}

void CachedTTFFont::OutputChar( const SDL_Renderer_Ptr &renderer, const GeometryRenderer_Ptr &,
Expand Down